From nobody Fri Feb 20 20:40:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fHhvQ6Q2nz6Sx6h for ; Fri, 20 Feb 2026 20:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fHhvQ5h6Bz3ZgD for ; Fri, 20 Feb 2026 20:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771620002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3ioUueBqM4JLm2rwe339vGmYUkUhH/bQW7SP/ReDobM=; b=Xck0+dTyzLxToXgWi8RMhzvDGIV8qlaK1i6f0/2zCKIshbF6aq4cs5BzV3VOQGd4JFghLn OwK8+1ao7l/Or8WrRU6Vviayf2iW3ef55BNrBx+afCEx9SyEt9Q4rTFQcw38JBsvOZSPJ1 ccHOn8N/7LhyjbyiMbyuSVeegPn9mFIUaRnznuIVzwyiYQ3Ih9g0YJgAQx8W0PEEDHerYj 8tctlM2n8npaf8id61o4mfyge+71gDJLjRoeD0OVbxV39eYgiQtS5Oxa3Q320asw2x0/BR ErTFYmu6je76Iki9LaKCRsMKNiyJPc1Y4q4mrhff6tYXwgWttVvCnphtBEz0YA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771620002; a=rsa-sha256; cv=none; b=dwEXFWZw3UK2YXDBIIU/eohFKv4uuMDVBHTzfisRyw1iu7i4+vGZCwMKvGa+uS1SjaxDmm GVefDeSlxnE+H/DTRMj80l9E1lXw/FLG+rNVdeXZNjkQLC8cK2dc9tc//Sqwf48wySRw9T PFVNWl1XjNQdN2ED8x5iM2TuuOKZcCEbNyaTRn410CbF7Ltk/eu5pkcL+i6oOPkyTBBw58 d1T9x2+ejxgNDyMAOnqphJ8EA0WqhELtrEZZ6A26ZSfUdK1rqVqX5mAXsp6H/RNbJ0oBxI xpSmFd/A/hqk7XJCKR8HrCZExIYuqi84tPpwG8oxxoPFDqANulFjPch2myroVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771620002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3ioUueBqM4JLm2rwe339vGmYUkUhH/bQW7SP/ReDobM=; b=MPbCU/wCyr4XK0ai1gac/Iw81EuYE75Uy0hzauCuCMpgL70hVQNy+hBsA+Hyfz5ZpCEpO0 kEgVT7FzDL4/z/eSrDEzht9L26EJ8FWDGJyqgZYlu5n6n51gfSrFbbIYXrx/tCFQF19YzS rKufPzKbgzVXJc7tKWiI/O/XpWjzQYhPtpT6HNyGphcWoaWualPTKA2/nOMf5z1K69VqAG GIzoWTnAdEap2HYx+v+78siDAD0vUTogwRISeqy6tJIpFlOhnqBNyQbmNSz21FUW8rsTBz pKUBWqh9tWIoCRHw/fLxv60VW89aQrUaSX9dDmccdlxp6Hsxcx8vn0EksmySbw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fHhvQ4zDMzkLl for ; Fri, 20 Feb 2026 20:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e0a0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Feb 2026 20:40:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 0788e7c40ddb - main - ctld: Honor the default maximum I/O queue size for NVMeoF controllers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0788e7c40ddbeedfd9713842440a8db2a8f7ea2f Auto-Submitted: auto-generated Date: Fri, 20 Feb 2026 20:40:02 +0000 Message-Id: <6998c6a2.1e0a0.1aeff8ce@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=0788e7c40ddbeedfd9713842440a8db2a8f7ea2f commit 0788e7c40ddbeedfd9713842440a8db2a8f7ea2f Author: John Baldwin AuthorDate: 2026-02-20 18:56:00 +0000 Commit: John Baldwin CommitDate: 2026-02-20 20:38:18 +0000 ctld: Honor the default maximum I/O queue size for NVMeoF controllers exports a constant to set the default maximum I/O queue size which is used by ctl(4) if an explicit size is not set. This value was chosen to match Linux's default, but it also avoids excessive resource usage for I/O queues. ctld was using the absolute maxium size as the default instead. Sponsored by: Chelsio Communications --- usr.sbin/ctld/nvmf.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/usr.sbin/ctld/nvmf.cc b/usr.sbin/ctld/nvmf.cc index eb116903f5c1..e1ecf8ccc552 100644 --- a/usr.sbin/ctld/nvmf.cc +++ b/usr.sbin/ctld/nvmf.cc @@ -165,7 +165,7 @@ nvmf_portal::prepare() "max_admin_qsize", NVME_MAX_ADMIN_ENTRIES, NVME_MIN_ADMIN_ENTRIES, NVME_MAX_ADMIN_ENTRIES); p_aparams.max_io_qsize = parse_number(nvl.get(), "max_io_qsize", - NVME_MAX_IO_ENTRIES, NVME_MIN_IO_ENTRIES, + NVMF_MAX_IO_ENTRIES, NVME_MIN_IO_ENTRIES, NVME_MAX_IO_ENTRIES); p_aparams.tcp.pda = 0; break; @@ -334,9 +334,6 @@ nvmf_port::kernel_create_port() nvlist_add_string(nvl.get(), "ctld_transport_group_name", pg->name()); nvlist_add_stringf(nvl.get(), "portid", "%u", pg->tag()); - if (!nvlist_exists_string(nvl.get(), "max_io_qsize")) - nvlist_add_stringf(nvl.get(), "max_io_qsize", "%u", - NVME_MAX_IO_ENTRIES); return ctl_create_port("nvmf", nvl.get(), &p_ctl_port); }