From nobody Fri Feb 20 10:13:26 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fHR0R18NBz6SZ7H for ; Fri, 20 Feb 2026 10:13:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fHR0Q58tbz442V for ; Fri, 20 Feb 2026 10:13:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771582406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NX7iQZqc3Z5t2Ket1EfOzAwtPmFOaMW2Un2HRP0h0gM=; b=hEjZv79L0OfGSBEDhNaKOwzTyv+fB7rEYQPOvYWE47MXRvKppvCpOp6HOOl3IGwvVVx9qK 1+yRVtE8Gw9QwyViLsBwum73GSmOofnjhsU1N+lj+YncsTcX4XPJjtOJD2uCiTYMX1ld/J zkna06uoYRg2nxFsQ4lUwA+fVQC1KeBqkaUtu05AO2p/kXaCBgclGCRm7BB5R1YN+25LI0 BjS3W4kEu6ywVM2Mi5YHhyYSWD1be2MH+6kTF1568NEvzvJwCqO88STabI2a0nOUg9gM4q KXE8nvJz++h+uMYMG0nOpTvqH2uljxgkJ/wTa6WG51OrGR7ETNoG69TBgB7YOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771582406; a=rsa-sha256; cv=none; b=tAGUcnbxV2rpgeyXcQr5rEBs62N9fwvGNar39b7BHpyqdv2N9QCpV0GQkfCUJ3b4t7HvyR CZu9NGCE3z6LzVZszcTEJMlwv1oi6g9xp44S6l1T67Ylyl9Aup+ajOuyzD1+ToLucG2rST Y7FqLnnm7G1oYzBGzq+IY8Ax7Nr6eDq5yZVudZzkTKontYLIdN6Ex+eevnM34aMkxI1XVk KVUvYxch2Gx8VvImMK6XnQEPxtNtYtcd97kOF8qPMsk9oFO1CsDFV3vXO3PGWOuwDoAvjY iBwYChzW5K7N3h2EcZlzAXWFqne9wjW+Xis2xVHjTSxqJFvGdXhvnwy02ssiwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771582406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NX7iQZqc3Z5t2Ket1EfOzAwtPmFOaMW2Un2HRP0h0gM=; b=Ct5HJjnU6v7v+ivDswuytuZlFwAVd7CuUNIeguBEd5YEyrg6MtolYutMy9ZmDil8l4j6zX fSrEnGAXl0CKQtL0Fv3RZBIOX1lVXAGdSVsbLvWmVY/3UxhBPfyfbvpf6KuoYqCEGt2ccm 69271XsP7+CKIvkG6wO2+xeFskoXZc+D8gkHE+HHT12mQ1s9uwgBFkgRcI+OxSxG7wHe/Z Cvhc6ngcV63guvFQZRt9E20TUDXXYdZEDgxy/PRGRc2n7lT0GYNzJPyGlm5DQKPO0gvalV bOEKfoEPIYJRGlZvFuATLSIWByoRj+Q6O9o3p/m187706wB3hf7Q0L36nGgG1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fHR0Q3wpbz85v for ; Fri, 20 Feb 2026 10:13:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 217e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Feb 2026 10:13:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 80d32a6b1d73 - main - hwpstate_amd(4): CPPC: Switch the default to maximum performance List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 80d32a6b1d73e0c81303417fa280ac74ef1f417a Auto-Submitted: auto-generated Date: Fri, 20 Feb 2026 10:13:26 +0000 Message-Id: <699833c6.217e1.1d5ae896@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=80d32a6b1d73e0c81303417fa280ac74ef1f417a commit 80d32a6b1d73e0c81303417fa280ac74ef1f417a Author: Olivier Certner AuthorDate: 2026-02-09 17:45:07 +0000 Commit: Olivier Certner CommitDate: 2026-02-20 10:12:53 +0000 hwpstate_amd(4): CPPC: Switch the default to maximum performance Set controls to maximum performance to avoid regressions now that CPPC is activated by default and to match what the P-state support does. Relnotes: yes Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D55253 --- sys/x86/cpufreq/hwpstate_amd.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/sys/x86/cpufreq/hwpstate_amd.c b/sys/x86/cpufreq/hwpstate_amd.c index 72fe6dbf6014..a1586f58166a 100644 --- a/sys/x86/cpufreq/hwpstate_amd.c +++ b/sys/x86/cpufreq/hwpstate_amd.c @@ -798,14 +798,6 @@ enable_cppc_cb(void *args) data->init_request = sc->cppc.request; data->request = sc->cppc.request; - /* - * In Intel's reference manual, the default value of EPP is 0x80u which - * is the balanced mode. For consistency, we set the same value in AMD's - * CPPC driver. - */ - SET_BITS_VALUE(data->request, AMD_CPPC_REQUEST_EPP_BITS, 0x80); - /* Enable autonomous mode by setting desired performance to 0. */ - SET_BITS_VALUE(data->request, AMD_CPPC_REQUEST_DES_PERF_BITS, 0); /* * Assuming reading MSR_AMD_CPPC_CAPS_1 succeeded, if it stays at its * reset value (0) before CPPC activation (not supposed to happen, but @@ -834,6 +826,16 @@ enable_cppc_cb(void *args) lowest_perf); SET_BITS_VALUE(data->request, AMD_CPPC_REQUEST_MAX_PERF_BITS, highest_perf); + /* + * Set controls to maximum performance to avoid regressions now that + * CPPC is activated by default and to match what the P-state support + * does. + */ + SET_BITS_VALUE(data->request, AMD_CPPC_REQUEST_EPP_BITS, 0); + /* 0 in "Desired Performance" is autonomous mode. */ + MPASS(highest_perf != 0); + SET_BITS_VALUE(data->request, AMD_CPPC_REQUEST_DES_PERF_BITS, + highest_perf); error = wrmsr_safe(MSR_AMD_CPPC_REQUEST, data->request); if (error != 0)