From nobody Thu Feb 19 17:16:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fH0R167n4z6S6mT for ; Thu, 19 Feb 2026 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fH0R15NXlz3F9D for ; Thu, 19 Feb 2026 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771521389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HkP4QbSWdKUkoqlbpNl0LkJIRLwgR946hGVeipIWX08=; b=r7oO+quU25oMOmgEpewkB9+nZdmlKQoMDMMUGn9o0NYMKKM3VI/Mg+4IgWyvk0iPOfRnxG 2z5ufhqFWW0rFLO8BRhN15seKG9ZRQO81qLuEL++fCtuXsO561g3N7u7LqRaALDNLORC+s 8GuSGCvHtPfZPyjfTJjB7/3FT3lRG5xS5uURepOvw3HB/hi79K83yT+HaYi98DvsoHg+to zZHX+VQnNTjy1bQZqm0332DbLKZeLqR4si7HbYnjDzki0pc4smS6Hkgntr07cWHo+8JwLG vy511AqF4eo221H9m+P+f/FWV1K7pUVRP90fhqXhdwUWYF67Tw26DmRbuNlrSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771521389; a=rsa-sha256; cv=none; b=v+4wVXs686pcEl+8BfB2iTRXKOzK1UKlx48sZ4XA43NwbMzf2FHFREJgipmeSi+pXQJRsh LuulxKNd0KWpMt/iWqoffGn8UNyiQO91jj3t/EzT7c1bcU3d7eIsvSD6FDpyIwap2Mxbe3 hY2JnewoGbVv0mtHQ8HevGEO93BmmRhOrs8PdHM/D3wqnmemZ2Rl04UYuojE7VZIDVRm4j 2xJ///WOJCc07m5kpyj1RggtWN04mHb+2evWntiPHmSxTTakkkKG8aGnQ7uloF2/jhtjIP +MTnLiVbIpmhKe+nZ4JiPgXWLxHfJ0XLzgSsKQfFyBqttWK/cV5TF+2pPLLKog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771521389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HkP4QbSWdKUkoqlbpNl0LkJIRLwgR946hGVeipIWX08=; b=tzE3nbWkIgDwkoU0nzocpPyVCFfoBba/CcjFPQxmNdjkzqc75Le+TEiiBmP2uhh6I2v18o OHMzBgFkGt708Zi+m2WPtvG69qUmsZ6d9vOwHdG61cgDjK2RZ+QR6Lw3ILiGPFcPoPnqeP mBypK6CHNZOcTopqvh56nrL24dOzmVpIzAnM+MwqS1mch+Ui/UxyGQJpW8RHqAdjn5CH4Z TCcAxsnZ0SuD5gMr+kImL6iHt6F6pEIx4zes6bQPsgfkSakaS9i0XsZEnb57mXgk/jFsz1 P2bdL9qMDUBwNLkcoM5t/eKPk9HdVPcIlzD3ISrHGMe9u/L74iyo39X8Qnq/Vw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fH0R14PvCzrPD for ; Thu, 19 Feb 2026 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38d06 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Feb 2026 17:16:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d4c05edd410e - main - vmm: Add privilege checks to vmmctl operations List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d4c05edd410e7925875c844c0642929410f22053 Auto-Submitted: auto-generated Date: Thu, 19 Feb 2026 17:16:29 +0000 Message-Id: <6997456d.38d06.65d34377@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d4c05edd410e7925875c844c0642929410f22053 commit d4c05edd410e7925875c844c0642929410f22053 Author: Mark Johnston AuthorDate: 2026-02-19 14:38:29 +0000 Commit: Mark Johnston CommitDate: 2026-02-19 17:16:15 +0000 vmm: Add privilege checks to vmmctl operations In preparation for supporting creation of VMs by unprivileged users, add some restrictions: - Disallow creation of non-transient VMs by unprivileged users. That is, if an unprivileged user creates a VM, the VM must be destroyed automatically once the last fd referencing it is gone. - Disallow destroying VMs created by a different user, unless the caller has the PRIV_VMM_DESTROY privilege. Reviewed by: bnovkov MFC after: 2 months Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D54740 --- sys/dev/vmm/vmm_dev.c | 21 +++++++++++++++++++++ sys/sys/priv.h | 4 +++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 0df21402683d..5d7802f929ae 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -898,6 +898,7 @@ vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) { struct cdev *cdev; struct vmmdev_softc *sc; + int error; sx_xlock(&vmmdev_mtx); sc = vmmdev_lookup(name, cred); @@ -906,6 +907,16 @@ vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) return (EINVAL); } + /* + * Only the creator of a VM or a privileged user can destroy it. + */ + if ((cred->cr_uid != sc->ucred->cr_uid || + cred->cr_prison != sc->ucred->cr_prison) && + (error = priv_check_cred(cred, PRIV_VMM_DESTROY)) != 0) { + sx_xunlock(&vmmdev_mtx); + return (error); + } + /* * Setting 'sc->cdev' to NULL is used to indicate that the VM * is scheduled for destruction. @@ -992,6 +1003,16 @@ vmmdev_create(const char *name, uint32_t flags, struct ucred *cred) return (EEXIST); } + /* + * Unprivileged users can only create VMs that will be automatically + * destroyed when the creating descriptor is closed. + */ + if ((flags & VMMCTL_CREATE_DESTROY_ON_CLOSE) == 0 && + (error = priv_check_cred(cred, PRIV_VMM_CREATE)) != 0) { + sx_xunlock(&vmmdev_mtx); + return (error); + } + if (!chgvmmcnt(cred->cr_ruidinfo, 1, vm_maxvmms)) { sx_xunlock(&vmmdev_mtx); return (ENOMEM); diff --git a/sys/sys/priv.h b/sys/sys/priv.h index 1ad6a4882ffc..e302d9487e64 100644 --- a/sys/sys/priv.h +++ b/sys/sys/priv.h @@ -539,11 +539,13 @@ * vmm privileges. */ #define PRIV_VMM_PPTDEV 710 /* Can manipulate ppt devices. */ +#define PRIV_VMM_CREATE 711 /* Can create non-temporal VMs. */ +#define PRIV_VMM_DESTROY 712 /* Can destroy other users' VMs. */ /* * Track end of privilege list. */ -#define _PRIV_HIGHEST 711 +#define _PRIV_HIGHEST 713 /* * Validate that a named privilege is known by the privilege system. Invalid