From nobody Sat Feb 14 05:25:55 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fCcvj3Nxwz6SfFj; Sat, 14 Feb 2026 05:26:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fCcvh2KdBz4Hng; Sat, 14 Feb 2026 05:26:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 61E5PtLn006663; Sat, 14 Feb 2026 07:25:58 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 61E5PtLn006663 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 61E5PtmE006662; Sat, 14 Feb 2026 07:25:55 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 14 Feb 2026 07:25:55 +0200 From: Konstantin Belousov To: Olivier Certner Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 07c4eb506be4 - main - sys/compat/freebsd32: Fix i386 compilation Message-ID: References: <698fa41b.23016.79a6cf2d@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Spamd-Result: default: False [-0.64 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_SHORT(0.43)[0.429]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_MEDIUM(-0.07)[-0.074]; ARC_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; HAS_XAW(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4fCcvh2KdBz4Hng X-Spamd-Bar: / On Sat, Feb 14, 2026 at 07:20:01AM +0200, Konstantin Belousov wrote: > On Fri, Feb 13, 2026 at 10:22:19PM +0000, Olivier Certner wrote: > > The branch main has been updated by olce: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=07c4eb506be45a4b836665e14ad63034ef3d573a > > > > commit 07c4eb506be45a4b836665e14ad63034ef3d573a > > Author: Olivier Certner > > AuthorDate: 2026-02-13 16:37:21 +0000 > > Commit: Olivier Certner > > CommitDate: 2026-02-13 22:21:51 +0000 > > > > sys/compat/freebsd32: Fix i386 compilation > > > > The compile assertion now failing is due to the change '__int64_t' => > > '__int32_t' as the type of 'time32_t' on i386, which is the correct > > value. The use of 'freebsd32.h' on i386 may seem strange, but it comes > > from 'kern_umtx.c' including it unconditionally as it needs 'struct > > umutex32'. > So this is probably the wrong direction, it is not going to scale. > If the issue is with userspace (kdump and some test), then perhaps we should > only turn on _WANT_KEVENT32 for LP64, in these sources? But I also run tinderbox on this series of patches, and i386 buildworld passed for me. So I am even less sure what is the problem. If it is for i386 kernel, then even more we should just guard its usage with LP64 (__SIZEOF_LONG__ == 8 in modern parlance). Trying to make COMPAT32 valid for 32bit host is not sustainable. > > > > > Fixes: 87632ddf67b0 ("openzfs sys/types32.h: use abi_compat.h for time32_t") > > Sponsored by: The FreeBSD Foundation > > --- > > sys/compat/freebsd32/freebsd32.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/compat/freebsd32/freebsd32.h b/sys/compat/freebsd32/freebsd32.h > > index e746a6e027ec..5210ce55b228 100644 > > --- a/sys/compat/freebsd32/freebsd32.h > > +++ b/sys/compat/freebsd32/freebsd32.h > > @@ -74,7 +74,7 @@ struct ffclock_estimate32 { > > __attribute__((packed)) > > #endif > > ; > > -#if defined(__amd64__) > > +#if defined(__amd64__) || defined(__i386__) > > _Static_assert(sizeof(struct ffclock_estimate32) == 52, "ffclock_estimate32 size"); > > #else > > _Static_assert(sizeof(struct ffclock_estimate32) == 56, "ffclock_estimate32 size");