From nobody Fri Feb 13 19:39:56 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fCMvQ0NBvz6Rh4s for ; Fri, 13 Feb 2026 19:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fCMvP6qQqz3Hxn for ; Fri, 13 Feb 2026 19:40:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771011602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RF/tqMiS+n9LEoEaql/sV0Sl9eBfjEfeA9ZkIvodpd8=; b=wRCvt+qoF8wfF2U1D6d5dD2wXaPeRuGmoLE5RbGVKwcJDVBJO+PVpLLZ21geAMhyP/gO8n uHDgeoZYgjWMfo7DKdORGyLpkUeShuLMKJE58g2K2uT2ztzxf6f9wPnRTk1kEIlEjB8bQa ZzHupH1U9Ln/ZUkD83Cc7hAon539XDhIiHdqNcTeKb29vx6el03NIMpRS3XrQSaw5Sr7OV RCkjCOe6KToGYun48YZnK3U16PF7Arqf4zXkDhvcniAwFHSOLLzixPKtRKPfNcCSnn1i+f Zt1OEueus1Yiy7isoNhaCI/VxmV2vdp8o3ESOWc+hP/HIXjH6h1mzNhQouYOAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771011602; a=rsa-sha256; cv=none; b=LS3u2U66gfGkdPgpgwSDa0hK4u2KoBMoCX2FO7De3FZ81IIQk36uyM8z85ajD07IjTktCV 1q/nJ3gVdS7+B7QpzYl10rR31WA7tztLejvpktTsFzpxnNMgdgcfgwnV5I0mhjg3kz3/BZ zDaWFz6l9mi/L6uGx/P3EDBSAo1kSQxtIaa3iR6/ojgPBrHHIDNiIsc19UHubD5YEp7Fir +7Sg5rFxxBz3xnfdxURd76zjpE7J/tlQcLpnDIFyVp0yXTrtPXiyRz0CDv84LS8XbER5b5 /y0eGSFwj6P3MM2MFThUgE4b8c+vfI6+X9j6sDcN0041fdr3drNBU1hz34/kBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771011602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RF/tqMiS+n9LEoEaql/sV0Sl9eBfjEfeA9ZkIvodpd8=; b=pBlJTJ0C6dnaZAOYpJACmP1eLI5Z0M05+bdgET5HAcr8HTOFztA3peXzhLHGCeF/M5gxPf UfMRR+7HFYFdoT9zwCCbZt0cXi5LKN2rZOvFxh6t1pHuKmPqFlTDp11JKpZ3nkV6NCjp8O bJ2eyROV2SXQdAzEH+ZVA4wztt+rxYECqYng4OSOY+EXN+hDgbdP7OU1mhWgfTLLQ/zbL0 27xa+twc/2bfGXUpClU76ov/78wGL65Q9sO13C/w3jqgSLrgP5PFj2vK7UfXk7rfUEyebB UupXyoBe4v6Q5x0A/L8HtBTJqajTQ94VYKcZwigCwdWrOgzy4GRVUZxOjpqWWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fCMvP6QlQzbKZ for ; Fri, 13 Feb 2026 19:40:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41b00 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Feb 2026 19:39:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 596bf3485fe5 - main - bpf: don't call bpf_detachd() in bpf_setdlt() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 596bf3485fe5dd62991e0f49ee783bc91d83678c Auto-Submitted: auto-generated Date: Fri, 13 Feb 2026 19:39:56 +0000 Message-Id: <698f7e0c.41b00.34065fc8@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=596bf3485fe5dd62991e0f49ee783bc91d83678c commit 596bf3485fe5dd62991e0f49ee783bc91d83678c Author: Gleb Smirnoff AuthorDate: 2026-02-12 20:11:09 +0000 Commit: Gleb Smirnoff CommitDate: 2026-02-13 19:39:37 +0000 bpf: don't call bpf_detachd() in bpf_setdlt() The bpf_attachd() will perform bpf_detachd() itself. Performing it twice will lead to doing CK_LIST_REMOVE twice. Reported & tested by: bz --- sys/net/bpf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/net/bpf.c b/sys/net/bpf.c index 228ac9867bd7..05877f6410a4 100644 --- a/sys/net/bpf.c +++ b/sys/net/bpf.c @@ -2821,7 +2821,6 @@ bpf_setdlt(struct bpf_d *d, u_int dlt) return (EINVAL); opromisc = d->bd_promisc; - bpf_detachd(d, false); bpf_attachd(d, bp); if (opromisc) { error = bp->bif_methods->bif_promisc(bp->bif_softc, true);