Re: git: 3e6e4e4a0d42 - main - hwpstate: add CPPC support for pstate driver on AMD

ShengYi Hung <aokblast@FreeBSD.org> writes:
> +static bool hwpstate_pkg_ctrl_enable = true;
> +SYSCTL_BOOL(_machdep, OID_AUTO, hwpstate_pkg_ctrl, CTLFLAG_RDTUN,
> +    &hwpstate_pkg_ctrl_enable, 0,
> +    "Set 1 (default) to enable package-level control, 0 to disable");

This doesn't work.  You are reusing the same OID already used by the
Intel subdriver.  The result is that whichever one happens to be first
on the linker command line works and the other one doesn't.  You have to
either use a different OID for each subdriver or have both subdrivers
share a single boolean.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org