From nobody Mon Aug 31 18:17:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hYcfC2Nycz6rB3w for ; Mon, 31 Aug 2026 18:17:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hYcfB6RY0z3YR4 for ; Mon, 31 Aug 2026 18:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788200242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KU2OQ/vrgA0hpr7yBCiE0fB5hOUvsarPqWt8L2WgQpk=; b=KSZm8VhSO/9QLLa5LS3Vto1xj5FP8e7hrdgreZaIopATwhYlZ2kgTFWoLt18h7R9x9LdyD Stw1G9jSY1IBm7aEqmj5c1PRWuP8HwYTNbUZoVAk2nMI0ezSXvR7G898av51xIHFAU28yx dRlY1Y6Pm0MCj0I3OlBN4GHcyYW29qa2bC73XC+oYQSGFLFfvzQ7JbLmtiAvKg/SCEas2L ZS516xPpqaPdR+65DegMXyFMH2raPhB2x5VdNDX9SNXW7pJy94mxER1xzrk4D4J4/H15t8 wf7CaUw7pVLv2BZPGiSSOzpyll33LkFOH1r/8uo1ZIyrQWVPiw1edaYIP4JNoQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788200242; a=rsa-sha256; cv=none; b=tSxxrsWmr74nrsRYB9S+7o1xoEIEzYSwG/vufYKaB6Fd1OP+K1kYbZHnBJrcoAELmVdhNY BU3YfFgL9uLKIC40jYQOrNOyVxAfgO59eQ6PIN57pX07e/F1ARLBItva4cWPD4N/SID/6y /AIEGfcN0hNgdQWmYJFdJ7g6QKJccCAO1MHflaM2Lo5cuY0RVklGN1Bkgb8moXjmJPxwL9 tNnF11goz8Gxk+YylUGq4BU6j9iIgmeu4xU84MAbrQ61zL5IPs4bLyMKoWlNI5OrBDCFxu XZM1hgNY5JCeQbGKWattCi1+e3soABx0O5G2IOLDr9be6esVWiyoqPxDTQ7UbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788200242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KU2OQ/vrgA0hpr7yBCiE0fB5hOUvsarPqWt8L2WgQpk=; b=Y+rPIc1b/tVu+1hxqmji6f7Jb+qWHI+i8z2FS6bWz5jjiKgO0/0UOFzCcVR0V18J7/wJmb Cq27mzUSiaWRL7x002uyM/xVjbPWW+YMChg+UD8gMVpGYxm7cLuZA4XDH09O81vdncMK0w hYkzdW4oCYFItx7c/Br4qOrnwO89S8m+nejRs9wWoWmckgsrUaJq9+r4z2GGAzz+4wChLP s42bCbzzxEssOwXgAFhj0PApjmLVm/FyKko+Ug2st4++YbF2Pt0ECiN9LGIGFb5WkhPcWL hiDQkXv1vtHlDFq6KJMM5sOEW0xy4chZ/xqyRvqwXxUQChH6vfNLFuGsyelklg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hYcfB4kz7z7B2 for ; Mon, 31 Aug 2026 18:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d71a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 31 Aug 2026 18:17:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: 4dcb33ebc80d - main - inetd: only declare and use the mapped-address netconfig under INET6 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4dcb33ebc80d83dfe231ea840d5c861a5ea41c98 Auto-Submitted: auto-generated Date: Mon, 31 Aug 2026 18:17:22 +0000 Message-Id: <6a95c532.3d71a.710b181@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=4dcb33ebc80d83dfe231ea840d5c861a5ea41c98 commit 4dcb33ebc80d83dfe231ea840d5c861a5ea41c98 Author: Abdelkader Boudih AuthorDate: 2026-08-31 18:15:45 +0000 Commit: Abdelkader Boudih CommitDate: 2026-08-31 18:15:45 +0000 inetd: only declare and use the mapped-address netconfig under INET6 In a WITHOUT_INET6 build the only assignment to netid2 is compiled out and the non-INET6 arm returns early, so netid2 is unconditionally NULL and the rpcb_set() call guarded by it is dead code. clang does not prove it dead and reports nbuf2 as uninitialized where it is passed as a const pointer, No functional change. MFC after: 1 week Reported by: clang (-Wuninitialized-const-pointer) Suggested by: dim Approved by: ngie (co-mentor) Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D59277 --- usr.sbin/inetd/inetd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/usr.sbin/inetd/inetd.c b/usr.sbin/inetd/inetd.c index 33316ce170a1..13302cf67b26 100644 --- a/usr.sbin/inetd/inetd.c +++ b/usr.sbin/inetd/inetd.c @@ -1315,11 +1315,13 @@ setsockopt(fd, SOL_SOCKET, opt, (char *)&on, sizeof (on)) if (sep->se_rpc) { u_int i; socklen_t len = sep->se_ctrladdr_size; - struct netconfig *netid, *netid2 = NULL; + struct netconfig *netid; + struct netbuf nbuf; #ifdef INET6 + struct netconfig *netid2 = NULL; struct sockaddr_in sock; + struct netbuf nbuf2; #endif - struct netbuf nbuf, nbuf2; if (getsockname(sep->se_fd, (struct sockaddr*)&sep->se_ctrladdr, &len) < 0){ @@ -1360,10 +1362,12 @@ setsockopt(fd, SOL_SOCKET, opt, (char *)&on, sizeof (on)) for (i = sep->se_rpc_lowvers; i <= sep->se_rpc_highvers; i++) { rpcb_unset(sep->se_rpc_prog, i, netid); rpcb_set(sep->se_rpc_prog, i, netid, &nbuf); +#ifdef INET6 if (netid2) { rpcb_unset(sep->se_rpc_prog, i, netid2); rpcb_set(sep->se_rpc_prog, i, netid2, &nbuf2); } +#endif } } if (sep->se_socktype == SOCK_STREAM)