From nobody Mon Aug 31 16:54:17 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hYZpL06y0z6r3kP for ; Mon, 31 Aug 2026 16:54:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hYZpK6S6wz3CLb for ; Mon, 31 Aug 2026 16:54:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788195257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zk3zws9+eTE1M0HvjMQmc78yycurJ+MtUGtAivKMPpw=; b=aVwR54dF0eoXgnOrMmlCbgapKv9PeJy3JdhLO/tPK9+h9CV8FHhc9WfAKxO7GdlV+YHYp+ fKepG9NW5CUv5rb33oig5AwEYFHL12w9nKmltTJ8pgIN1kiC2FN4xnlFYojdvZkyKbkb6V x+vTuYUlEAnUSRY2z/7x26bpf+LLOmWUQBHYJ8Sdp9M1ooi8iyu2SFY1m+HUqKIk33/jID +nOhhhhCEDnKbM5fMBYvgFSeq+9GqZ0HQnjh6rvpc0ecYpHNHE9zkboq+uJmt+wDQSZ8HC 6CzMc378byqEJ37gmupU6L5y6fA1PfgDHlp1MFzHvmLpV4UDHenJ9lfZf7dNxA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788195257; a=rsa-sha256; cv=none; b=mXRslrQ046WBTH5xofsA0NjBSGt660fC02cIm1Z4FnRf1rNKYyhtjhHJPAtP2XYGzWAK8u N2pWy9PvqLRRS7+NIlHt9aZ5HOH4JZXGca+1iAIu8zLs99rdFqEIbULvZqQZ/pFHFks37J rK3Q32ID40wQ9VnvNJw2088CGj7pEyRnQ6XDbvjaUAhuAq/ShP1EV/coryVpiSl8EOylUS 3UjpP22IWlIMwGhQmtX/SZKMR9MPb/lWaQZo1wjbvle44JRSM3HiHY1Mx7uhONvW+c5Y/H 5oYRebBUlpv+SixGam1rH/LMhBroMXlyEBGR5mBLVar3ZMaa7C4y+KmRSt0hWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788195257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zk3zws9+eTE1M0HvjMQmc78yycurJ+MtUGtAivKMPpw=; b=R0U8SwVc+wFHvdGdHsYxW8m3Efayv66mRxv1M724Kce0pFZNjHoulMbmYYilhAGQUa/Y0D LCQ1KlI73LTx9pp9h/VL5VlcNm3RU8s2miOjO4RQEqe0O3jfeHw049C/cTNg9268QvcGPK OSRBF/bptPrF9WDx2nzFa2NQoD1p9BPciB8BNKnifmvunOXR9XFmDrpMJCykybgKLvX1vD 1s2epvrkE45TFsYqlFyOyDCfDF6yiBAWAPwRPun49kfrjosHqmCz6vazDvj5NbpWOWrmTU 5LAZ/63/WLqYvvA2IfRqjrHRItOwzTQkyWlmC1BU9lMeqk3ls51EEWJjsk9RLg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hYZpK53p5z52B for ; Mon, 31 Aug 2026 16:54:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3666c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 31 Aug 2026 16:54:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Kim Shrier From: Bjoern A. Zeeb Subject: git: 0211e64ce1e5 - main - LinuxKPI: 802.11: add != NULL check in ieee80211_tx_status_ext() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0211e64ce1e5ba208f4b96453ce6740a49689b91 Auto-Submitted: auto-generated Date: Mon, 31 Aug 2026 16:54:17 +0000 Message-Id: <6a95b1b9.3666c.41f0b7e6@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=0211e64ce1e5ba208f4b96453ce6740a49689b91 commit 0211e64ce1e5ba208f4b96453ce6740a49689b91 Author: Kim Shrier AuthorDate: 2026-08-31 16:28:51 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-08-31 16:46:55 +0000 LinuxKPI: 802.11: add != NULL check in ieee80211_tx_status_ext() There seems to be another possible race with net80211 state machine changing the bss from under us (another lvif_bss_synched case). Just do the != NULL check to avoid a NULL pointer deref in ieee80211_ratectl_rate(). (bz extended the original comment and wrote the commit message). Sponosred by: The FreeBSD Foundation (commit) PR: 297184 MFC after: 3 days --- sys/compat/linuxkpi/common/src/linux_80211.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index fd92f1dcf75b..f1eef91af0da 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -9128,7 +9128,15 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, IMPROVE("only update rate if needed but that requires us to get a proper rate from mo_sta_statistics"); ieee80211_ratectl_tx_complete(ni, &txs); - ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); + /* + * A tx completion can land here after the vap has been torn + * down (iv_bss cleared on the way to INIT) while frames were + * still in flight; there is no bss node left to rate-adjust. + * This is another case of !lvif->lvif_bss_synched but checking + * that seems too cumbersome. + */ + if (ni->ni_vap->iv_bss != NULL) + ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); #ifdef LINUXKPI_DEBUG_80211 if (linuxkpi_debug_80211 & D80211_TRACE_TX) {