Re: git: 4617a6cb82a6 - main - nlist: Handle multiple symbol tables

John Baldwin <jhb@FreeBSD.org> writes:
> The _Foo vs Foo change broke many uses of kvm_nlist in the tree.  In
> particular, ktrdump no longer works on crashdumps now, and I finally
> single-stepped through it today to figure out why.
>
> A quick grep shows me all these places that are now broken:
> [...]
> Would you rather revert the underscore change or fix all these?

Looks to me like they were all incorrect to begin with and only worked
because of the hack in nlist(), so I would vote for fixing the calls.
But perhaps kib@ should weigh in since he was the one who suggested
dropping the hack.

Cc: to re@ as this is a regression in 14.5.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org