From nobody Tue Aug 25 19:18:03 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTyH35NShz6pqTZ; Tue, 25 Aug 2026 19:18:07 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTyH31lDSz42Jc; Tue, 25 Aug 2026 19:18:07 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787685487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rm/UgUIcNZCzWY/lfTubLFGHWjZiU8VtCMF0n2911eQ=; b=d7wzKTesBOCQT0cI1Lr6baYkAE0/Jj8dAgucnHRGO6hUkYIBjTYEZc3znOJ9DWvJZTf34b yBGAe8LJqBCQA6qnEwMqSKYgZv9JXcys40n9u0YkjSpNduTqQPDbrd5RvfxrSZ9CSqFAtn eW5rknVycuYFCrptQik0QKxq1rRyExtsju4v8HocS30g789/y/mDzAaoCeCw2wE62E2sA3 kOXXBX10vYnQA8gI3cbNOBnUf6sjws4K5F/YQkBjMwI2QA+8u8C7NejHaskrq4VZ7lgQaL C8hMnpXYvPyOWZ3v9/yxyof7cR/sjvFHs7HdRcP6BafexcbQgAry3kCH2OdfhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787685487; a=rsa-sha256; cv=none; b=YDz/FABha5An4UL52/j+RM+kX4Bdy+xFED3d8Oiljiy4OZfPZNwCWJfqegtgnjw7/0LP3V 3TqbdsUJjx7hhJs0r38910awWeT8g+PE4IO3wlm16mWWGnMn8IPsVPl77K9ViM0Nuguct6 K00ny0zDKyZlKzOK8LyI0+EYI7AFLpq6UB8mXHwPV0+4toziHJ4XeuHUKpBWIcNnXDq30O fT6NwtDCy6dIwOvomM/fo6aSEt4SnMHKyu4+c6yeL7f2AKELNT5gtLi0A/kal3eJy4hm+j 3MyaJ096KlSiB4k9OIP/SyAFFLz296ybRY1yszNBxb7nL+jJGdlSbDo7PXFH1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787685487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rm/UgUIcNZCzWY/lfTubLFGHWjZiU8VtCMF0n2911eQ=; b=pxNeyS3jT82DTRjyqhIfPQ2lDxejED1dF2ZaezDpJzW1zfevcOyTQTrWsMoHTFuxw+XHCR 5rvvX2ffbto3Uk9CAim4XJrhecs6U7Mq/54aF/zkojJlU2iRrzsd+qPnC53AXNEya7fsEu ZCtFmGp0DzJHXWQl59pSGSV1/E9CnXtpJbr1yJi+uGRmx6cTacxtesZ77wu6s7a6xUuOz7 2n0ZKpEpxfRCj/6w865F5a1aEzcJBki6y5OZKQkU3AT29CPeFDO8BkYIfwr5dBXJ/l2aZQ 1/n15O4vkup+sToa1f98vYvN4hBuPfcDsxb0B55LjW5g3uRtuBnXaKKqbNIfDg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hTyH21wrDz17wP; Tue, 25 Aug 2026 19:18:06 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 25 Aug 2026 12:18:03 -0700 From: Gleb Smirnoff To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 662497d5a741 - main - SYSINIT: add explicit SI_ORDER_LAST Message-ID: References: <6a7b347b.2762e.4e3404b4@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 24, 2026 at 09:50:18AM +0000, Brooks Davis wrote: B> Given that SI_ORDER_LAST isn't UINT_MAX, should we have an assert like B> the one below so LAST continues to be last? B> B> -- Brooks B> B> diff --git a/sys/kern/init_main.c b/sys/kern/init_main.c B> index 8cbdd645a230..9825b71a746e 100644 B> --- a/sys/kern/init_main.c B> +++ b/sys/kern/init_main.c B> @@ -200,8 +200,10 @@ sysinit_mklist(struct sysinitlist *list, struct B> sysinit **set, B> TSENTER(); B> TSENTER2("listify"); B> STAILQ_INIT(list); B> - for (sipp = set; sipp < set_end; sipp++) B> + for (sipp = set; sipp < set_end; sipp++) { B> + MPASS((*sipp)->order <= SI_ORDER_LAST); B> STAILQ_INSERT_TAIL(list, *sipp, next); B> + } B> TSEXIT2("listify"); B> TSENTER2("mergesort"); B> STAILQ_MERGESORT(list, NULL, sysinit_compar, sysinit, next); I'm not against this change, but if we enable -Werror=assign-enum for the kernel compilation, any incorrect use of SYSINIT orders and subsystems is going to be catched at compile time. See https://github.com/freebsd/freebsd-src/compare/main...glebius:FreeBSD:Werror%3Dassign-enum -- Gleb Smirnoff