From nobody Mon Aug 24 11:38:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hT8750Mkkz6pGcy for ; Mon, 24 Aug 2026 11:38:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hT8746G0Yz3JFs for ; Mon, 24 Aug 2026 11:38:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787571504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ukqG8ZxigRwMVKPjqb4hXiJXElbLWTzIPF+uCQu0eK8=; b=JQ7yuQYcyzJ3mzGeid00Ngs2nAb4hMVmH7+sHc+tFtUIg3DCAVtbgrlJXQGbvuo7SXqc13 vLxC9F6nkUhM7azRiLcNz9Mgj8bwujKnQN+vfap+B0sUuFlYTb8UOoNDl3lqH+zclQ0wmv aQ2z1iJ2N5287aFVXf4DhCwyFKOiaO2LH22byuSEBFpX/FSZP/SLTTiCVjr90WkdsBt527 quIdtexoHe+p7QlDbjbDZb5kW47JIlktkmREjEvOHuKZFmNhSE3xSGCI8ueoa3iop6ieWV buT8jRSmfrApjU/3YOqaeBaoEmf4Y58aScChQe+CayUuvDLo6YEBYn0IcCvMyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787571504; a=rsa-sha256; cv=none; b=b9yudnHWwkKMMucmAfEFvCOGqISzUbBYe9hnup57V5PjYqlv8i2bKkpb0262EcF9NaEsIE i33BZDDb5jrD/7/4Qfhmkm6cHUagXXGR979YQC9moZk4DzELvZ589d5l6GLCapSpFWAmHt L8i+4iXznL0pBsd8PdAOm1Mu6/rqxvLxWYI8RPHYLhKBeGcnzOJ+JC+0Drzf1BLuK55ISh sLtXBjLWSuNjw9BWdVBH78PBf/QAUH11sKJq38i/7xJBuHEqAg772dNnlf+8qoTaCXcTPC /YE+OdNh7jEYeChC3etZM0z2D189VIsQ1JLE1+z4spDjMYDlYIWwz5e2Af0jqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787571504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ukqG8ZxigRwMVKPjqb4hXiJXElbLWTzIPF+uCQu0eK8=; b=SrjTqPvViuNzxrbTGWPUeg44okULYqhYh1j2SpuDUqIw+z//6O/Td91+W47Be2CYajkBiw wW8nnRSNLO2S5C+4le9weMgPKs2P3lHtPwpP1BTNbh47NOhTupgP8QZEv1B0TRkliPgZsU Wn4ZwtNxdrG0AboXJj0GLNhda9dvd0xdn/XbmzhgrSGQdCFvozghcVwsHT+NASQN6jD6Xa V2sQJpuaHfhwesYnuPqopEZGbH9SGfubvo8uKmIL/tWmKjbraQtyedkx/SPWScT9QVWoWq HP4ghI4OUpEbdrQ+s05TN3u8iaYQYjkXVSNmDse5XF7q8oiXPJBT1z7Ky9nnSg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hT8744YcRz12yl for ; Mon, 24 Aug 2026 11:38:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31ac3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Aug 2026 11:38:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: cfacf6465577 - main - pf: fix crash on low memory List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cfacf6465577e224acb86d99434d834f4facbfb2 Auto-Submitted: auto-generated Date: Mon, 24 Aug 2026 11:38:24 +0000 Message-Id: <6a8c2d30.31ac3.4f905f06@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=cfacf6465577e224acb86d99434d834f4facbfb2 commit cfacf6465577e224acb86d99434d834f4facbfb2 Author: Kristof Provost AuthorDate: 2026-08-24 09:31:27 +0000 Commit: Kristof Provost CommitDate: 2026-08-24 11:38:03 +0000 pf: fix crash on low memory pfr_create_kentry() can return NULL. Don't dereference the pointer it returns until after we've checked it. Fixes: 08ed87a4a276 ("pf: convert DIOCRSETADDRS to netlink") See also: https://redmine.netgate.com/issues/23622 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf_table.c b/sys/netpfil/pf/pf_table.c index e6290e622fea..dd670d58359b 100644 --- a/sys/netpfil/pf/pf_table.c +++ b/sys/netpfil/pf/pf_table.c @@ -446,9 +446,9 @@ pfr_set_addrs(struct pfr_table *tbl, struct pfr_addr *addr, int size, } p = pfr_create_kentry(&ad, (kt->pfrkt_flags & PFR_TFLAG_COUNTERS) != 0); - p->pfrke_mark = PFR_FB_ADDED; if (p == NULL) senderr(ENOMEM); + p->pfrke_mark = PFR_FB_ADDED; if (pfr_route_kentry(tmpkt, p)) { pfr_destroy_kentry(p); ad.pfra_fback = PFR_FB_NONE;