From nobody Fri Aug 21 19:15:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hRVPp1dfjz6pPxd for ; Fri, 21 Aug 2026 19:15:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hRVPp0mgJz3TWj for ; Fri, 21 Aug 2026 19:15:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787339726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fu4PJOxoNgqsXWzsxRcZ1nNx10QhXa4JuclVFNdq1IY=; b=WrVFO9w83UHkZ1ZMB2KxMt4t/OmnE330D5PzwCfMGKpxYsX6kkV4fbjn81QxbCgh7kNyAK bYekI9ATUXuSRV8QAFReLp5cB+A4thjm9xgKNzvGUVr7LgmHo5r1H7mMAxGn70yPTxshox QtwNfwppAyZ1XKqifW2DiacUAkb2S0wLqE9YvKu02uT4npDqMzVswSJJQAU0t7HU8FlXTQ jqfDsNi4apw7jpnoC8+Tzakyk79T7jV4MvvUjxltcsdtr1hVcFsyjCmNkGOXL4/J6P+FPw ckBU34jSNrCQsMNWnlFHdq8p0nKxT+Yxf0OYJwbYiCW4TS8u6y2D7DDyNmCweQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787339726; a=rsa-sha256; cv=none; b=G0aACSUdRrbsAX2cvodEjTgr7JPJTUbMtZlRf216l+O+txJY/jR5hea1as2/oAiqsU22Vw U4kE/Kh/wdvGLqx8wtx28MKxSL3WJTejTsXJTHYgyKJwtsNkh+aaOl46OootDbBkKrOsJu vyngLSt8ObOwVnV11B/NgSvVUu9ksjldDx8CYgJv00Wr7eS0dVcbheUys6m3iptyleJwfN lzaBXKbWu1mndQDbbktNNQzO3FUQGuV+ulOTjmB5KvpOeeHD9qpiH65xUWTqFVl85OMcbY MQEnB16Hub41B23eTgdeotDgQ7ilG1YZ6/BNHocUcbqZaTTWkgYpKlOsgebyyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787339726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fu4PJOxoNgqsXWzsxRcZ1nNx10QhXa4JuclVFNdq1IY=; b=CZT+RoiGg3iR7FnT1o+2lzdORD/J0FgmcwiHzLmq9JgOUQQRCdZwQ+/24n3z8v2kpxPvgM WRZ/CtDbLWkxiELK7tsD7iqEFW2MZx/NJtbNMr0MJbqnBM55qbJd2Skfm9TSoYxBGidLl8 kXh/oUi3aIUSE9cPc+7dhNtIuJge52z+l1124YOjLaqZFVzuKZ8xb39P6ySXQpE9K3yVYT Fg6w/JTYpPMezLWr6qtr4e1va2HW9ik98eX2mBv/37PVSuBhtkG3XDNJF9+AABm8uGDzgm 26Y7UAx2KTw7l+IwAjeEdpKzJsGgglgDmNsEYuGVqN36ql+OtBKwmZxOV1c8/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hRVPn6RhTz1d9 for ; Fri, 21 Aug 2026 19:15:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32eb0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Aug 2026 19:15:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jose Luis Duran Subject: git: 2916ae647303 - main - makefs: Fix atime tests on MS-DOS (FAT) file systems List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2916ae647303e3bd92e533002a8e6c476417fe7f Auto-Submitted: auto-generated Date: Fri, 21 Aug 2026 19:15:25 +0000 Message-Id: <6a88a3cd.32eb0.38a5be96@gitrepo.freebsd.org> The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=2916ae647303e3bd92e533002a8e6c476417fe7f commit 2916ae647303e3bd92e533002a8e6c476417fe7f Author: Jose Luis Duran AuthorDate: 2026-08-21 19:14:03 +0000 Commit: Jose Luis Duran CommitDate: 2026-08-21 19:14:03 +0000 makefs: Fix atime tests on MS-DOS (FAT) file systems On FAT file systems, access time has a resolution of 1 day, so it is really the access date. Strip the time component from the epoch timestamp in order to check the access time. Reference: https://learn.microsoft.com/en-us/windows/win32/sysinfo/file-times Reviewed by: ngie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54584 --- usr.sbin/makefs/tests/makefs_msdos_tests.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/usr.sbin/makefs/tests/makefs_msdos_tests.sh b/usr.sbin/makefs/tests/makefs_msdos_tests.sh index f800bbcd6925..3abf17528559 100644 --- a/usr.sbin/makefs/tests/makefs_msdos_tests.sh +++ b/usr.sbin/makefs/tests/makefs_msdos_tests.sh @@ -48,6 +48,8 @@ atf_test_case T_flag_dir cleanup T_flag_dir_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -56,8 +58,7 @@ T_flag_dir_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp } @@ -72,6 +73,9 @@ T_flag_F_flag_body() { timestamp_F=1742574908 # Even value, timestamp precision is 2s. timestamp_T=1742574910 + # FAT directory entries don't have an access time, just a date. + timestamp_F_atime=$((timestamp_F - timestamp_F % 86400)) + create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -82,8 +86,7 @@ T_flag_F_flag_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_F_atime atf_check_equal $st_mtime $timestamp_F atf_check_equal $st_ctime $timestamp_F } @@ -97,6 +100,8 @@ atf_test_case T_flag_mtree cleanup T_flag_mtree_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -106,8 +111,7 @@ T_flag_mtree_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp }