From nobody Fri Aug 21 13:31:34 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hRLnB0ksjz6qPJr; Fri, 21 Aug 2026 13:31:42 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hRLn94D6mz3RJZ; Fri, 21 Aug 2026 13:31:41 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787319101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QLhdkbbjcN40HuN+DcPdG/OKsXUR+xSyvALfKMJC8og=; b=KYuoXTStFDkWCRRFG3a2ndFdX2bsVHkziMOTl96z/PoHqtjID3BJzhVxXBNP2IpAtSPyKB DCqNOB0BD3JQ1ZS/g5pPMzRmXxmmIzc4iSUaZW5hk+Vi5BOfeXU94Wqf3qYF6oN+Yb4JH6 JiNBGV+XHkPEatvZ4ly7dEczGh7XGdreoDc1qhmavO1QfsXnF8DENi29hXbw4w9VtwOc2C pfvv8dOqvQ3+BWIPRFQLrJoIH9JDZGyi88cD1Pd210rJRifEVttrlqW/3Kyvs5QgOGDpI+ 3Kjocu9Kq4YplyaZDC03UFZ4D0JGvUKE5epO5RSxjC/aBGc12bO/mEnE9fJlxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787319101; a=rsa-sha256; cv=none; b=YuXm4yDHXLkf3hPtRYRXIPyyvaduCTQl+9FrgPSbmGtzSyJ/6AL/aYguFw4akZ1PEZAKym DROKaMTm8mKjUg2mgD/bIPDt8eLkHWAeFsP9asSIracKwI+ILEKl0MODiFKcqN1lAuZi6T y/hi2FerWNFVuMCoUj8oMXpMBZt5qb2rLDjEqVUwjYW1VKgpvBWq7+Vg3F3QvmS3Dswlo4 Pj2nxjunh1278qX09y/TGZl547d/In9uFflZrrZEgB7M1ZeIQ3KZPhmwRayP2dYiVYcokf I/TSZPG7vwemyhGpsZWeO+Ec5gRMsPWCFNYMfWsvRxY5F/i9Lg1TWq3IpoQHNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787319101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QLhdkbbjcN40HuN+DcPdG/OKsXUR+xSyvALfKMJC8og=; b=akfG8R/5Wqi35WzejufYM0pmkK68kLmTtCaaH8CZ3h3fUOY2TtakwW2Xr5lr3tnkJuLnay duBLGRhbDQxs9VMelJEq10sg02Q39r9sJmXteNsgW2f8ZRFCtARrqgCZ1oYXD5EdnG2x3m WaJ7ARbhRxpGOcd5a1USGdLS3HwbmLFdJcOTuIvJ7ByhBca3USY/ioJo+Rtrf17YrtNXgk TFkRnDpn1Y2dRiIYF6YqpKcEywmMpEfzIbQ8+CoP3iYvyv1XlU0SNl1q+oYC5s3qmVqHpg i+qBVAbnhF8GjTNLKvwKz1/F9cCqQ9PI8pXWrduKDI0zcsHTUSB+5Rlj1GgswA== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "YE1" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hRLn86sCXzrK0; Fri, 21 Aug 2026 13:31:40 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 101AA6195708; Fri, 21 Aug 2026 13:31:37 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E2EAA2D029EC; Fri, 21 Aug 2026 13:31:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 7ndHXyYnDqiH; Fri, 21 Aug 2026 13:31:35 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 00AD32D029D8; Fri, 21 Aug 2026 13:31:34 +0000 (UTC) Date: Fri, 21 Aug 2026 13:31:34 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 4f2465260f03 - main - SYSINIT: add SI_SUB_FIRST In-Reply-To: <6a7b347c.26454.5c5c1229@gitrepo.freebsd.org> Message-ID: References: <6a7b347c.26454.5c5c1229@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 11 Aug 2026, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f2465260f035fa0095e73b34a74851ef2efaa83 > > commit 4f2465260f035fa0095e73b34a74851ef2efaa83 > Author: Gleb Smirnoff > AuthorDate: 2026-08-11 14:40:06 +0000 > Commit: Gleb Smirnoff > CommitDate: 2026-08-11 14:40:06 +0000 > > SYSINIT: add SI_SUB_FIRST > > This allows to initialize mp_maxid, mp_ncpus and register APICs at the > most early stage, guaranteeing that those values will already be available > at SI_SUB_TUNABLES. > > Reviewed by: markj > Differential Revision: https://reviews.freebsd.org/D58712 > --- > sys/kern/subr_smp.c | 2 +- > sys/sys/kernel.h | 1 + > sys/x86/acpica/madt.c | 2 +- > sys/x86/x86/local_apic.c | 2 +- > sys/x86/x86/mptable.c | 3 +-- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sys/kern/subr_smp.c b/sys/kern/subr_smp.c > index dd2e829aefbf..a58a179336f3 100644 > --- a/sys/kern/subr_smp.c > +++ b/sys/kern/subr_smp.c > @@ -179,7 +179,7 @@ mp_setmaxid(void *dummy) > > cpusetsizemin = howmany(mp_maxid + 1, NBBY); > } > -SYSINIT(cpu_mp_setmaxid, SI_SUB_TUNABLES, SI_ORDER_FIRST, mp_setmaxid, NULL); > +SYSINIT(cpu_mp_setmaxid, SI_SUB_FIRST, SI_ORDER_ANY, mp_setmaxid, NULL); > > /* > * Call the MD SMP initialization code. > diff --git a/sys/sys/kernel.h b/sys/sys/kernel.h > index 139a570c7ac6..2e1b1bd537cd 100644 > --- a/sys/sys/kernel.h > +++ b/sys/sys/kernel.h > @@ -94,6 +94,7 @@ extern volatile long ticksl; > */ > enum sysinit_sub_id { > SI_SUB_DUMMY = 0x0000000, /* not executed; for linker */ > + SI_SUB_FIRST = 0x0600000, /* mp_maxid, etc... */ Are we expecting a SI_SUB_PRE_FIRST one day or why did we not put it on 1 but 6? It seems more likely there'll be something between FIRST and TUNABLE/COPYRIGHT one day than before FIRST? > SI_SUB_TUNABLES = 0x0700000, /* establish tunable values */ > SI_SUB_COPYRIGHT = 0x0800001, /* first use of console */ > SI_SUB_VM = 0x1000000, /* virtual memory system init */ -- Bjoern A. Zeeb r15:7