From nobody Sun Aug 16 23:31:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hNXKs1G5Zz6plpp for ; Sun, 16 Aug 2026 23:31:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hNXKr6Cc6z3Ywd for ; Sun, 16 Aug 2026 23:31:44 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-6a0a4a28cbdso4751371a12.3 for ; Sun, 16 Aug 2026 16:31:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786923103; cv=none; d=google.com; s=arc-20260327; b=gnRiHXUBLUSp4vUBN6o+7NrZcQSoTsl1lKwem9Irrk2mohRpQqHoZUvA22w8AGpSAl hNtmq4ttuIyT8L44YUH8kWL5UzWz5skd5IGf3BsFcc5cYsQgnFHoehNlReAIuhawpgqX 63D2uKyeFYsLf2Gbbc85FRvPvZ6Npw7Qcyb6m5I9/E6n8bA4tD7iUvyPGMScOpiTMFiM xTNs7appr5/gK5enM3Sby3pWxQUb5uII/2h0P7DR4h9kkiZVXyr5ci8I7HEUXuM35M61 AZLHudQzDO+Ut+R1TsLCFqjdo93xP5SRbQUYtm9N8HDeaK0Rfm/ztHWq3zPDY701xkMb DZdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=LQ82gZrrSZYhbnlgsnYkzSi3jQygKMnN8mYbvLtvlT8=; fh=hQFUlB26ADqGpLLhaZwr/8aPcEJsAYXvpRg2019uDNU=; b=ncvB50pxStJ9o43cmazPiLVWwKEiHwzmB1ANW2R8tnpf+De3zP+feJ9Xnq1aW5jU8P Tx/3LlQj3QW5WL1KqtSqK9rXhs5p+yhhaByN3YlCcecC4y66F/Iwvef/KWcfHHo2f1aF PQbn2hEXwZDZzv/aJurayNkz78Y1IxJImxESriMFf/tLhXuShdn44T9jQULVjcCeA2RY Ypg+IfXNQu60Not2l6rr795d2QCXSxxhV1rpBUeoJs+I8uw75jXpdPp7XlVgp9SAVqRn Lp3fpmQHXU1LSgXwVHKtvEEB1/KE0OjZe0YrACam2aI3LcEqvB/eNWEImVZhZTbzP6D6 Jy4Q==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786923103; x=1787527903; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LQ82gZrrSZYhbnlgsnYkzSi3jQygKMnN8mYbvLtvlT8=; b=aHzja8SGsUlIqsBX0kn8pCmYW8ARhtfAp8juhvivfmY/5O2R8PW3ETjjr4jW7L86kV 4Z5e5dUb1aIXOtQ6Aq4nRsoJbv7reT++mWCEueNvGDre2s90vQyN3dUo/SywbNHQg9ZQ lif15CoQYU9ITuoG0yyv+uC3e+7XKG4td7ozBTyrZ/0vuWD9e4XsGs8OHCA79sekXmIr RZHSJ8GEsFmyhHlUdEYcqM3qWylcCHHVtJQOM4S+otMykfhb0ybvWc3Xzx3PWl0tJyKk +70c9BARh9Y4BN7BHszwEmpxgXLbF6u4omsKdN4Q/ZeME2bK80gCyzu9sMwnqnPWgpAr GtLA== X-Forwarded-Encrypted: i=1; AHgh+RoKwXN3D+Zp1eMqrNhp25CeyTDN4p/hDbrI+88hT935XUQxHJkwG86aTRoY4NGxLkS/y4bo4BJ4ml1Ipu52/wMzWCJbYw==@freebsd.org X-Gm-Message-State: AOJu0Yx04o1aHsIltlU17KriUvxeRJzzgyUUJ2ALV1iJfHMN2g7pY8Cj HV0GACB/8CowgJZfba8sKBJVGLPH2GkXZjFC2lZbkD0sv4cJlRq8n4fTwcW7+tpKqAAcgsi0Btt m7WPZEVLa/gGlrVuB8NW33gech/mK5WE= X-Gm-Gg: AR+sD10ehMGAh245jJ9Qc/bM2td+C8Ljggh6oxe/jsX7tbsU5rYVrOJrGvOEbo2mi40 HvYaTjBW6MC50C33tZg+5k2bqEcMUQFb7Qdjox95c0WRHBpaLUnvBZGKGAcs727fkJJHwoJzESn j38/oJVimXidFLLSHU/DGiIyT9GVL8OgG0EVzKPRcho9bl1H2fUFz1hm7Q5BG/zM808QSeMByCF UXeM3J7wpfvDsdWRbIa3PC7T/lzOG+EX6ZnAteE5Apj4F0Nlm66B8UT8R0vlFbo1cxNPc4EK6zB C2YkerLyTYTDup+PvOHZyCV7sbEwM/aHwgsvc1Q/TKq2b44pnHgK7bs+LSoygKmD6sYIExjEyfJ pEvolwzzIAgCADd4ctyRKn+6eG5cOiXwzXwrH86FX X-Received: by 2002:a05:6402:5357:b0:6a1:778a:d223 with SMTP id 4fb4d7f45d1cf-6a38a992953mr7587394a12.18.1786923102976; Sun, 16 Aug 2026 16:31:42 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a820c72.3d6f3.358d7bf2@gitrepo.freebsd.org> <1394173135.167669.1786915495022@localhost> In-Reply-To: <1394173135.167669.1786915495022@localhost> From: Alan Somers Date: Sun, 16 Aug 2026 17:31:29 -0600 X-Gm-Features: AcwNN1WN3vAteHlwGBNvTAnt4c3zER07dxLXwDbGYfTisfd0q-i7P-ubhtJtfWc Message-ID: Subject: Re: git: 95a4412e3a4d - main - zonectl: Consistently report ZAC conv. zones WP LBA To: Ronald Klop Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, voidanix Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4hNXKr6Cc6z3Ywd X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- Yes, it probably would. On Sun, Aug 16, 2026 at 3:25=E2=80=AFPM Ronald Klop = wrote: > > Would it be helpful for future readers of the code to have a constant def= ined for these? Instead of 2 =E2=80=9Cmagic=E2=80=9D values. > > Regards, > Ronald > > Van: Alan Somers > Datum: 16 augustus 2026 21:16 > Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-com= mits-src-main@FreeBSD.org > CC: voidanix > Onderwerp: git: 95a4412e3a4d - main - zonectl: Consistently report ZAC co= nv. zones WP LBA > > The branch main has been updated by asomers: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D95a4412e3a4d41b430f298ea2c= 2a51f8aa119c2c > > commit 95a4412e3a4d41b430f298ea2c2a51f8aa119c2c > Author: voidanix > AuthorDate: 2026-07-30 23:50:32 +0000 > Commit: Alan Somers > CommitDate: 2026-08-16 19:15:33 +0000 > > zonectl: Consistently report ZAC conv. zones WP LBA > > On ZAC drives, conventional zones conventionally report a write point= er > LBA of 0xffffffffffff. This field is 48 bits wide, unlike ZBC's 64 bi= ts. > > Recognize both ZAC and ZBC all-ones behaviour in the WRITE POINTER LB= A > field to indicate non-valid information. > > Tested by: fuz > Discussed with: fuz, asomers, ken > Fixes: 4735ef6196bc ("zonectl: display conventional zones be= tter") > MFC after: 2 weeks > Sponsored by: Google Summer Of Code 2026 > Reviewed by: asomers > Pull Request: https://github.com/freebsd/freebsd-src/pull/2345 > --- > usr.sbin/zonectl/zonectl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/usr.sbin/zonectl/zonectl.c b/usr.sbin/zonectl/zonectl.c > index 9dc6ddfd1aae..462353cd58ef 100644 > --- a/usr.sbin/zonectl/zonectl.c > +++ b/usr.sbin/zonectl/zonectl.c > @@ -292,7 +292,8 @@ zonectl_print_rz(struct disk_zone_report *report, zon= e_output_flags out_flags, > (uintmax_t)entry->zone_start_lba, > field_widths[ZONE_FW_LEN], > (uintmax_t)entry->zone_length); > - if (entry->write_pointer_lba =3D=3D 0xffffffffffffffff) { > + if (entry->write_pointer_lba =3D=3D 0xffffffffffff || > + entry->write_pointer_lba =3D=3D 0xffffffffffffffff) { > /* > * This value is reported by HDDs for conventional > * zones. It really means "N/A". Reported it as -1, > > ________________________________ > > > >