From nobody Sun Aug 16 09:00:18 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hN90L6Hxwz6nkwP for ; Sun, 16 Aug 2026 09:00:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hN90L3wYyz3L8Z for ; Sun, 16 Aug 2026 09:00:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786870818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FpKn0Pd94b8y9cH8Yhg3GF9rCcazQ3KnbVxmCGIxzAo=; b=mkpDJuxFbPqu7lZFm3l4Cz95pdJejKwsnuN22pJmSQQ+kgL+r6Xx1dff7PhO/Eg5/6zAiL Tku3jL7n0t/R0eSlzH8C/rdRCH4aVfUS4tSMTHZC3F5ec/VE76woS3Ek1NC6IVF3k6KYf0 0iXoQmSPWcX/OeMep5R9/H/MrqRq8c9Z44NiNoO5Z7IlwFGTZbEOp3GL0/y85qTMRQsznR +4nqcInFRuN7tnjJC9pdlk5AwTQRrCxpcy1Aw9THWkqgE4X0UPEjJH5nZAmwsYnsK6JSiF lhlmN2wtwlNA6E5RwflaIroVDtlUZIlrHAKYFvEyqvdOktobjywGf1zBdjgXMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786870818; a=rsa-sha256; cv=none; b=b/EAzE98YPKgsL7xI45FCSmTCFkMjBmF3mPztyJMPgllz8CmINMQrmcGaC0gzmY8VBvGNX C+1sjlXrzjdvWkLBkgY16v+kxhUCsd8vI5zcwCRAW5UtgGMVUOoy7sl6/4x4ILlZKvkwa4 FbkctWRBFDN+9eijIHPkLGUjdCcmR37sf4oluMAG9uypfS5QwAdvRgHq8rh6lCwjNgRIhc EnkQmTnWbiFOlf4fq6rQj6m9ajfWi/201U/7F+w+uv8DSIzMImphUvYuFCdIn178ogXjLZ qP3DUFjIquw4tb7RFjm40YMXk0qFRZ2jUYRlDpx/BpY17rJVvpzmL502rubzDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786870818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FpKn0Pd94b8y9cH8Yhg3GF9rCcazQ3KnbVxmCGIxzAo=; b=aRuhZHvfOZmy8U6a81vRuvrXCSZmeDSQQSjbM+AHRrmEjp21OVwo2cmA+Kx2M60Xuyd2Vl kJJ9wqVoMa+8DYdxSu/+HquSRrnoEwANwyTzMu0qtgOJT82rLw5ET9a+dv7RsHOOu7NvdD e4G3BrhWT0rsThG9zYRNm90/Dp0aYANqcwXuVg/QRkQ2BStXHPHyoTeiTMhmtHaLUJPnbD izmAM0WlQ4myY0jI6M8jzkJOodWYAKrXMuolTkRJh5XVt8C2B1W7Q8kq1Wa6bR7eOpCD5H nSof/pSb9g0W/1Yep1o1y6TfgiQFvP2hH9ohX7yKYq8tQRuBE596G0Bhdc1yyA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hN90L1cD4z5SG for ; Sun, 16 Aug 2026 09:00:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e1b2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 16 Aug 2026 09:00:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d7be8a3e2291 - main - e1000: Report PCH packet buffer ECC statistics List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d7be8a3e229174bea06228b461da3b1825c6cc54 Auto-Submitted: auto-generated Date: Sun, 16 Aug 2026 09:00:18 +0000 Message-Id: <6a817c22.1e1b2.454fea62@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d7be8a3e229174bea06228b461da3b1825c6cc54 commit d7be8a3e229174bea06228b461da3b1825c6cc54 Author: Kevin Bowling AuthorDate: 2026-08-12 18:30:08 +0000 Commit: Kevin Bowling CommitDate: 2026-08-16 09:00:11 +0000 e1000: Report PCH packet buffer ECC statistics PCH packet buffer ECC status contains read-clear byte counters for corrected and uncorrected errors. Sample them with the regular hardware statistics update and account for the snapshot captured by the fatal error interrupt path. Expose the counters and the number of reset worthy interrupt indications under dev.em.N.memory_errors. Keeping the reset counter separate also preserves evidence when another status reader wins the read-clear race. Hardware validation used an I219-LM. Three documented ICS.ECCER injections advanced fatal_resets from zero to three, exactly once per reset. corrected_packet_buffer and uncorrected_packet_buffer remained zero, as expected because ICS does not inject a memory error or alter PBECCSTS. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/e1000/if_em.c | 36 ++++++++++++++++++++++++++++++++++++ sys/dev/e1000/if_em.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index ce59a12df0de..eb4c17f78769 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -2187,6 +2187,17 @@ em_fatal_error_intr_mask(struct e1000_softc *sc) return (0); } +static void +em_update_pch_ecc_stats(struct e1000_softc *sc, u32 pbeccsts) +{ + + sc->corrected_error_packet_buffer_count += + pbeccsts & E1000_PBECCSTS_CORR_ERR_CNT_MASK; + sc->uncorrected_error_packet_buffer_count += + (pbeccsts & E1000_PBECCSTS_UNCORR_ERR_CNT_MASK) >> + E1000_PBECCSTS_UNCORR_ERR_CNT_SHIFT; +} + /* * Descriptor-memory ECC errors stop the PCH MAC. Capture the read-clear * status before handing recovery to the iflib admin task. @@ -2220,6 +2231,7 @@ em_handle_fatal_error_admin(struct e1000_softc *sc) return (atomic_load_acq_32(&sc->fatal_error_state) != EM_FATAL_ERROR_NONE); + em_update_pch_ecc_stats(sc, sc->fatal_error_pbeccsts); device_printf(sc->dev, "uncorrectable packet-buffer ECC error: PBECCSTS %#x; " "requesting reset\n", sc->fatal_error_pbeccsts); @@ -5772,6 +5784,10 @@ em_update_stats_counters(struct e1000_softc *sc) stats->tsctfc += E1000_READ_REG(&sc->hw, E1000_TSCTFC); } + + if (em_has_pch_ecc(&sc->hw)) + em_update_pch_ecc_stats(sc, + E1000_READ_REG(&sc->hw, E1000_PBECCSTS)); } static bool @@ -6184,6 +6200,26 @@ em_add_hw_stats(struct e1000_softc *sc) SYSCTL_ADD_UQUAD(ctx, eee_list, OID_AUTO, "rx_lpi_count", CTLFLAG_RD, &stats->rlpic, "RX LPI event count"); } + if (em_has_pch_ecc(&sc->hw)) { + struct sysctl_oid *memerr_node; + struct sysctl_oid_list *memerr_list; + + memerr_node = SYSCTL_ADD_NODE(ctx, child, OID_AUTO, + "memory_errors", CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, + "Internal memory error indications"); + memerr_list = SYSCTL_CHILDREN(memerr_node); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, "fatal_resets", + CTLFLAG_RD, &sc->fatal_error_reset_count, + "Resets requested for fatal packet-buffer ECC errors"); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, + "corrected_packet_buffer", CTLFLAG_RD, + &sc->corrected_error_packet_buffer_count, + "Corrected packet-buffer ECC errors"); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, + "uncorrected_packet_buffer", CTLFLAG_RD, + &sc->uncorrected_error_packet_buffer_count, + "Uncorrected packet-buffer ECC errors"); + } SYSCTL_ADD_UQUAD(ctx, stat_list, OID_AUTO, "excess_coll", CTLFLAG_RD, &stats->ecol, diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 0c6f59f3f576..b88cb8abefb5 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -627,6 +627,8 @@ struct e1000_softc { u32 fatal_error_state; u32 fatal_error_pbeccsts; u64 fatal_error_reset_count; + u64 corrected_error_packet_buffer_count; + u64 uncorrected_error_packet_buffer_count; #ifdef PCI_IOV struct igb_vf *vfs;