From nobody Sat Aug 15 17:23:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hMmD0082Kz6p5jW; Sat, 15 Aug 2026 17:24:00 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hMmCz5qT5z3MTj; Sat, 15 Aug 2026 17:23:59 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786814639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0MFTtMl+irm+taYLfRxELvP7iiHXmP1IA8/f1fiLuQ=; b=db0UBqNRfdH/u37z6/c/RuiqfS+knaR15DHwbQojye/2IKHK/3DnkuAfK2TKgxsF6Uaiec Wm1d6B7wXQebwvhnox5IAs3zqj7GLqmsjsUeQurvga4jkfNxCu7Xl/VPtCbcx+3+Y/GikG Urkb1ukosrJ0xrMeJcEwT6cIE8yMP8QsargXoemrc72zrpZ+OyUYXHATTNuvQHufKWze4Q bHt1i4g0zdMDYokFirPr1sike393lg+KzlAtp659/OLri0PTBShPO08fbZdumha2wpbfR7 bsAQiB6Z6lKdna2hCGWiWvcflsTSbELJR30ovomtfI/pZYI3wcVPl1C6mdG0Ug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786814639; a=rsa-sha256; cv=none; b=lcKvnkSPD9iIhRHzbQznSPQ1K0aTyreGV1tzES7rOY2n3NT2etJNg2iyw/XKxenmoWfRy0 MA8lEibPbosWiTaWS1Es1bxAD4LqReF+t932cV352/G5tVBwplSuOGezIUvZrJ55VS08py TfhJgDJ1DUH0JgNfN1+sS8YdM0p/fWL0SaRsFAavYg30nHUapHinlX/W6pRWtdw37aVh2f fxF2W9GD9Ev/QNC1uwZ1UDTzXn5YY1Rt/vhqwQnjFq0u2shSIQDsaB278/is4g9PZHaKrH fP5+jKXaPqK2M+XMvXFM7KhLkf1JjaagjlzEo+odaewXwnHut5fVKe0y41q3aA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786814639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0MFTtMl+irm+taYLfRxELvP7iiHXmP1IA8/f1fiLuQ=; b=AIJBbRmayEcmkab3C40EUT2ZjgCljNuLYGglxNir4m3IMbzSUzspYuqKrc4NCC89tjgU2e APptmDPSUO/KJTK8wt9HMBNehcQepairiWuT7PZjjglYMVoVe0hRh8OKM232Q+qqwLIg4z d2CosXgw5YGZLDrcX6eaiJFQGshzEBtQsIvtLribd4zM6ZZNxzkK7T+HKUh2h2+zcxCEYo waII9hjmZC6BGfziS/L44XQQkgtG5JMwLN6YSbWirnzBa2rmlg+CDg+G1N+wUPBn+qy1yO Ox+sPcFR5tw1KTB4jq21uvUH16XYpR35MSR/ectIFRww5tV1Jcw/ZsJcjmYafA== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "YE2" (not verified)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hMmCz3T1rzrdj; Sat, 15 Aug 2026 17:23:59 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (bladnoch.home.andric.com [192.168.0.20]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 92051306D3; Sat, 15 Aug 2026 19:23:57 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.8\)) Subject: Re: git: cd0727ec709b - main - libc: Add C23 feature test macro From: Dimitry Andric In-Reply-To: <6a7f6d6a.372ae.3079abac@gitrepo.freebsd.org> Date: Sat, 15 Aug 2026 19:23:57 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <6a7f6d6a.372ae.3079abac@gitrepo.freebsd.org> To: Faraz Vahedi X-Mailer: Apple Mail (2.3826.700.81.1.8) On 14 Aug 2026, at 21:32, Faraz Vahedi wrote: >=20 > The branch main has been updated by kfv: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dcd0727ec709bb54f8f82104f6113284a= 15dd3464 >=20 > commit cd0727ec709bb54f8f82104f6113284a15dd3464 > Author: Faraz Vahedi > AuthorDate: 2026-08-14 12:22:00 +0000 > Commit: Faraz Vahedi > CommitDate: 2026-08-14 19:31:54 +0000 >=20 > libc: Add C23 feature test macro >=20 > Define the __STDC_VERSION_STDIO_H__ feature test macro now that > the header fully conforms to C23. >=20 > Reviewed by: fuz > Approved by: fuz (mentor) > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D58842 ... > diff --git a/include/stdio.h b/include/stdio.h > index ea016d65095d..50e3ff2d1c34 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -32,8 +32,8 @@ > * SUCH DAMAGE. > */ >=20 > -#ifndef _STDIO_H_ > -#define _STDIO_H_ > +#ifndef __STDC_VERSION_STDIO_H__ > +#define __STDC_VERSION_STDIO_H__ 202311L >=20 > #include > #include This particular change appears to have broken the math/gmp port, which hasn't functionally changed since 2023. It has this construct to detect the existence of FILE: /* For reference, "defined(EOF)" cannot be used here. In g++ 2.95.4, defines EOF but not FILE. */ #if defined (FILE) \ || defined (H_STDIO) \ || defined (_H_STDIO) /* AIX */ \ || defined (_STDIO_H) /* glibc, Sun, SCO */ \ || defined (_STDIO_H_) /* BSD, OSF */ \ || defined (__STDIO_H) /* Borland */ \ || defined (__STDIO_H__) /* IRIX */ \ || defined (_STDIO_INCLUDED) /* HPUX */ \ || defined (__dj_include_stdio_h_) /* DJGPP */ \ || defined (_FILE_DEFINED) /* Microsoft */ \ || defined (__STDIO__) /* Apple MPW MrC */ \ || defined (_MSL_STDIO_H) /* Metrowerks */ \ || defined (_STDIO_H_INCLUDED) /* QNX4 */ \ || defined (_ISO_STDIO_ISO_H) /* Sun C++ */ \ || defined (__STDIO_LOADED) /* VMS */ \ || defined (_STDIO) /* HPE NonStop */ \ || defined (__DEFINED_FILE) /* musl */ #define _GMP_H_HAVE_FILE 1 #endif Now that _STDIO_H_ has been removed, the detection fails and another part of the port falls over due to an incorrect prototype. I guess we could patch the math/gmp port with another __STDC_VERSION_STDIO_H__ macro, but it might be good to do an exp-run to see if there are more GNU projects which rely on the existence of the _STDIO_H_ macro? -Dimitry