From nobody Fri Aug 14 22:57:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hMHfr3wjQz6nvRH for ; Fri, 14 Aug 2026 22:57:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hMHfr3Rtrz3pbx for ; Fri, 14 Aug 2026 22:57:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786748228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CUt45XZpqrriKbP+UhW3i2gob3zBy6ncPYFqQ0qjCsM=; b=Engy24fZ9OYhdtEMRjpGNAaisCgt7YFvSdMM3V8zQiYRSnlxoqGbGfvdvASZ3n1mVUX8ZO +kFwy4z0HWSe6ZC3ZUL5f1CRFvLZGj/HKA9FUb1Y0WeX++a/8rYCnZj1EOof6I0pgHjVta eby1HP2zsv7Ff4W9s940V2NkzsivKbNwK8lCJzCnR3PVqDWlVM3O2f9hWBD6h+uI0Hk7uq 1tahLMCmcJ8BAFy/Mg+9xJPElyM8zqeMwaIVz7mmUZPdJvtxt+wWYNM4f5nN5Y1Xy2giYL ZCdLuQqs4qgY7aaf6C71YGfbuO1slgbQBZop7m6hvkejdB4uTm/4F/V6diZy2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786748228; a=rsa-sha256; cv=none; b=wkPkH3bbQbUjxt0IHmhmgtsTXS5tU7b8tDDjxSfl+aADLxOoizOv3A3OqBNSQwjTEBPlKz UH6fEbON5lY1BMLXa16Y+sa1N7NUnpF6NrhOPOb1BRiW5PrJENolqoPJ6UkqVw/PIIuWiF /ARVfu4SS5jV7ZnNLr3y+fPipLB0H8PRlWc/2KaOh/2H3e3NFzRIivzkaq+pLiNvxzFRa6 jXo4Jikc4W+JmKffGfA2bO0Fgqra6pkAjMWAVRQfIaJywgLdcGLKU/fSh8lsbVpbMdINk2 3viDvbLcFPK+SxBKtjL8kIJsyHa0m9nNPmkXW5aJ0xkUSLXXtB0tF7iTb6jgJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786748228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CUt45XZpqrriKbP+UhW3i2gob3zBy6ncPYFqQ0qjCsM=; b=q5OczxlkRNKV8AUeAGtQK/Zp/z9NjLV4Hk4V7BOrrM8vW8Vkxr+/AziIePxdeNHs3k3zCO SAo1u57WkwpwWY7HaXzF2tyJRLsvDBVE8sH/KGrS0KMZq1UYSbHApFAVOLnGncqJ/GuGe2 lYpalEaxUgWZnLRqqNtL5yPnJWLp5AX1vTOtTAO9T6+S2DYtkq1dLDIkqFhp8E4x5YCvb8 6Ypwf1XN2SsrQ62UTduphp/NFUbICTh/yIMXFe36+KN1ChRy8mcaEoPBGcAJjMlvZuw9ti IEG06FaEjGTShSCr6Gj1PamyutEUFTS6HyeS9XnrPxLJCoFitck24PoBWSaukA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hMHfr2JrJz360 for ; Fri, 14 Aug 2026 22:57:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24096 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 14 Aug 2026 22:57:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 06aaca43fe05 - main - iflib: actually disable simple_tx when ALTQ is in use List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 06aaca43fe05d22cd289af9b6fa751b9bd08b560 Auto-Submitted: auto-generated Date: Fri, 14 Aug 2026 22:57:08 +0000 Message-Id: <6a7f9d44.24096.3adb10c0@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=06aaca43fe05d22cd289af9b6fa751b9bd08b560 commit 06aaca43fe05d22cd289af9b6fa751b9bd08b560 Author: Andrew Gallatin AuthorDate: 2026-08-14 22:54:21 +0000 Commit: Andrew Gallatin CommitDate: 2026-08-14 22:56:35 +0000 iflib: actually disable simple_tx when ALTQ is in use When getting some baseline ALTQ numbers, I noticed that if simlple_tx is enabled in kenv, we wind up re-setting the transmit routine, but I neglected to actually clear ctx->ifc_sysctl_simple_tx. That leads to many different panics as we run a mixture of mp_ring and simple_tx. Pointy-hat to: gallatin Sponsored by: Netflix --- sys/net/iflib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index d4e23a70d569..c8662b6b7e69 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5285,6 +5285,7 @@ iflib_device_register(device_t dev, void *sc, if_shared_ctx_t sctx, if_ctx_t *ct device_printf(dev, "using simple if_transmit\n"); #else device_printf(dev, "ALTQ prevents using simple if_transmit\n"); + ctx->ifc_sysctl_simple_tx = 0; #endif } iflib_reset_qvalues(ctx);