From nobody Fri Aug 14 22:28:44 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hMH250vfPz6nsvl for ; Fri, 14 Aug 2026 22:28:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hMH250KNVz3mnW for ; Fri, 14 Aug 2026 22:28:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786746525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yGK4GJoFHX5fybUGnPsjF63iOh9LuVMRv5zfKR3dkuw=; b=bbSIzxAJ5RdC7pqQhLpCI3C71Je5XsR6PPqvRlCcICot4r1NzJfjZeGYpfHnY+g/tLFsea SHi0PL8+rXgWmL2xfsFuXM8RZwSYj60eASS5wilGWSuGbfE3Q7mV/Kdlur+M3US6epQepn oxWHlf2DqkWG1t6cW8mlqtyBqiYt6pPfaj/uonoL49yovU2+ohovrqZXkPQeBR9EI3wmJ/ oydZiTBhmFIIyHR2iQMtPsrHYH9tI8KEo47Q2LtOFvSIQF+Zmx+uOSrq9dKZU6w5sJXGSd eTs9ocgorKlNtzGR6tzjofd6OR8+iFjMcYAxCF0Z9O+YxOcfAWn/jORQDiT43w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786746525; a=rsa-sha256; cv=none; b=t6zhr6U4473JIV+sQiF4uqYQyT3QPiQTa/O6124mwYzsaOQfKX63Rp78xbwABiK7Cn3kvW xOwRfSJ5JBYg2clUwCfKEbQJGOPI5Dp5vWhOQ0yJWu78d/3tjSCz79tlcEI5y+48WsxUKO mFwe+Woq0IUlOqGw2qfoViWJp3RiwzBncdGQLW6lqV6QkfZwiIStSh/B3yYDV+9hZY1etz MFu9yFlm099VoOMbsAlxoBxosdYdywUNfT7yqSP0Gl6PyvWxFeC38H7mACEFNETj/Gd0OW C+9Ft9rx7j8VHXq8oW3XO7vOkEf3RcXPqOkoUBF0kDJLX7iWERZ/qbHpdDdonw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786746525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yGK4GJoFHX5fybUGnPsjF63iOh9LuVMRv5zfKR3dkuw=; b=sZE6eLZ6J5LCCbQeNAV4w/cZ/cI2RAegB5qE4e7Pm03BPsqp+wQoTjLim9Dt4aW/puzvff c+D6ok+ChNVWefpu9ovk9/IKc8O9PAc1wiFejVYeiUQgqNcWknu2fhv2aTipfCs9pYr1e1 Nc+iOQGDjXgMZvs8mkpDrB8CN5pkGwQNPEWSU01ykrVOK4RjYL3omOnL6+7nUKU/6slczP kWw0dW5K4h8U+gIVLnnwt4StQMqPyxWyerk0EZPd1dl0Df96HOTbbPYqk/xO1w3yWOBxWc Qxvt2si4cfZUje1RHc9T3vVZLmXiTnV//x7gpTZwyzbSRB1g1A3UvYDrdRenvA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hMH246Qpdz1wL for ; Fri, 14 Aug 2026 22:28:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20c8a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 14 Aug 2026 22:28:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: b4208a67edc2 - main - iflib: Initialize the VFLR task unconditionally List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b4208a67edc2eb7898a9ff2a6f3990c6852910e4 Auto-Submitted: auto-generated Date: Fri, 14 Aug 2026 22:28:44 +0000 Message-Id: <6a7f969c.20c8a.14f11314@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=b4208a67edc2eb7898a9ff2a6f3990c6852910e4 commit b4208a67edc2eb7898a9ff2a6f3990c6852910e4 Author: Kevin Bowling AuthorDate: 2026-08-12 01:51:18 +0000 Commit: Kevin Bowling CommitDate: 2026-08-14 22:28:07 +0000 iflib: Initialize the VFLR task unconditionally The VFLR task was initialized only from drivers MSI-X interrupt assignment paths. ixl's legacy interrupt handler can nevertheless defer VFLR work, leaving an uninitialized task. Even with MSI-X, the admin interrupt was established before the task was initialized. Initialize it alongside the other private tasks. The existing detach check and private-taskqueue drains then cover its lifecycle for every interrupt mode and registration failure. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/net/iflib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 9efd4b56c5d1..d4e23a70d569 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5382,6 +5382,7 @@ iflib_device_register(device_t dev, void *sc, if_shared_ctx_t sctx, if_ctx_t *ct TASK_INIT(&ctx->ifc_admin_task, 0, _task_fn_admin, ctx); TASK_INIT(&ctx->ifc_led_task, 0, _task_fn_led, ctx); + TASK_INIT(&ctx->ifc_vflr_task, 0, _task_fn_iov, ctx); IFLIB_REGISTER_FAIL_POINT(dev, register_after_taskqueue, err, fail_cleanup); @@ -6627,7 +6628,6 @@ iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, NET_GROUPTASK_INIT(gtask, 0, fn, q); break; case IFLIB_INTR_IOV: - TASK_INIT(&ctx->ifc_vflr_task, 0, _task_fn_iov, ctx); return; default: panic("unknown net intr type");