From nobody Wed Aug 12 19:40:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKzNT1KWWz6nr1G for ; Wed, 12 Aug 2026 19:40:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKzNS5kLSz42FK for ; Wed, 12 Aug 2026 19:40:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786563608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2GLkaSc93lPvJagkLwkvvELRDe4wlvOmmClwCyOhXag=; b=pN2xKYZsidXdNQavlCa53Njy7PkOOhum8SnOgum87lGmcUe6Kt3QYQsl2R+oiu1zNoPfIa dGqUr/TBsu3du6m9kaMsROD5Wf8t+CY+JxEXbrRS4990cPE32BwKen5ALaOvMhDF8bLXrD G/shEL8WrzoEs4O7lekDR1PQj6x3FWnG2EIZ8PO7yEMb3maJo1lVEdciaUvtApvU+lfeKd Ak6s8XbIoxyBwabTjQBkyWwDhZ46SuQLoFv2/RrDpZ9u+MZdCgkk8AVUVBvNQCPhd6jaBA SfKp2gslMDO66RWqbm3ZUoyKnCgwgCTD7IBYVFgz/HSa41gvB7uLJyjYXi/OSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786563608; a=rsa-sha256; cv=none; b=ikC33bkkQhE+dYMAEyIDyHNSPgoIS9X/SqeJ5I/137VJmRJqumy4C7m1H/58LTiFVrlKLi m8NJO6i98fxAulCQWEa4b1fuwN/8nc/hoBENQmlsMmmk1B0lfP8O3GZTu823xAOnzVOyMx myq1af4G4PNwspJsv7vP1EDqvcgRUqOWVs5ogjKF2XBOyG4GnOCx82FawmkHBKDxGtW2z/ OLQwLIs2ELvnp3ETVxTXKlrx6mjlkfDyyPH2aa/cYXWDX6j7rjwbHXsjvfv7lGKPOdGZ5s 9zfLfDD6VIbi29EgcqoA7ynSu4DbKmU8GEU0K4FWgYb9yK3H72BCpxr8BmJyfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786563608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2GLkaSc93lPvJagkLwkvvELRDe4wlvOmmClwCyOhXag=; b=i1p3vOYmtXM5IHu2FldD3e22sqSpSJAYQG9z7cR1BaZMXbNPoK+i99D7y26N0X6r6RR7xE hA61efXYvvOTz+1xd9Z/kveJs+vAzeu7gkGQ6vwOega+bD7AMm05RpRM+iM5JYuDUh8Tma FY7Pe8pMh0RYHElTDvXEHyspVHJK97RbGScgskJKWdv0rBsO181r5/FBMbbdGs7rJ9q0Zq 96J8LKMh8kLJ3PMvClM57B8i5AAkoFxnc2NAyzJ27YNxIfuHhWgtC9BmgDCJzHhs6ckvt9 PBKDMLUzDIg/SKySKsfo9x4E95PnstPdXF6nHwUhp+P4QWMlrkTcvALkVZVs9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKzNS4Dqrzg4Z for ; Wed, 12 Aug 2026 19:40:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30a4b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 12 Aug 2026 19:40:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 9f7633b93295 - main - igc: Report corrected internal ECC errors List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9f7633b932954162792e2caef4f6f0cd87e82f43 Auto-Submitted: auto-generated Date: Wed, 12 Aug 2026 19:40:08 +0000 Message-Id: <6a7ccc18.30a4b.642f83a7@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9f7633b932954162792e2caef4f6f0cd87e82f43 commit 9f7633b932954162792e2caef4f6f0cd87e82f43 Author: Kevin Bowling AuthorDate: 2026-08-12 04:13:43 +0000 Commit: Kevin Bowling CommitDate: 2026-08-12 19:39:54 +0000 igc: Report corrected internal ECC errors I225 and I226 do not interrupt for corrected internal ECC errors. Instead, the DMA packet buffer and PCIe memories expose sticky status bits in PBECCSTS and PCIEECCSTS. Sample these bits with the regular hardware statistics update, preserve the PBECCSTS ECC enable state while clearing its RW1C indication, and expose separate counters for the DMA packet buffer, PCIe transmit-data memory, and PCIe retry buffer. These counters represent observed indications rather than an exact error count because multiple corrections between samples collapse into one sticky status bit. Hardware validation used an I225-IT (rev 3) and a debug kernel that wrote only the documented self-clearing injection bits. Each test armed the injector, exercised the owning RAM with traffic, and compared the corresponding counter before and after. Coverage: Memory Observed result DMA packet buffer corrected_dma advanced once PCIe transmit data corrected_pcie_tx_data advanced once PCIe retry buffer No PCIe replay source; not exercised The retry-buffer injector requires a real PCIe replay to read the corrupted entry. The test root port exposed AER and DPC reporting but no protocol error injector, so ordinary traffic could not cover that case. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/igc/if_igc.c | 40 ++++++++++++++++++++++++++++++++++++++++ sys/dev/igc/if_igc.h | 3 +++ 2 files changed, 43 insertions(+) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index add391f9195f..11fe32f62df3 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -135,6 +135,7 @@ static void igc_if_multi_set(if_ctx_t); static void igc_if_update_admin_status(if_ctx_t); static void igc_apply_i225_ipg_workaround(struct igc_softc *); static void igc_if_debug(if_ctx_t); +static void igc_update_ecc_stats(struct igc_softc *); static void igc_update_stats_counters(struct igc_softc *); static void igc_add_hw_stats(struct igc_softc *); static int igc_if_set_promisc(if_ctx_t, int); @@ -2908,6 +2909,32 @@ pme: * Update the board statistics counters. * **********************************************************************/ +static void +igc_update_ecc_stats(struct igc_softc *sc) +{ + struct igc_hw *hw; + u32 pbeccsts, pcieeccsts; + + hw = &sc->hw; + pbeccsts = IGC_READ_REG(hw, IGC_PBECCSTS); + if (pbeccsts & IGC_PBECCSTS_CORR_ERR) { + sc->corrected_error_dma_count++; + /* Preserve the enable bit while clearing the RW1C status. */ + IGC_WRITE_REG(hw, IGC_PBECCSTS, + pbeccsts & (IGC_PBECCSTS_ECC_ENABLE | + IGC_PBECCSTS_CORR_ERR)); + } + + pcieeccsts = IGC_READ_REG(hw, IGC_PCIEECCSTS) & + IGC_PCIEECCSTS_CORR_MASK; + if (pcieeccsts & IGC_PCIEECCSTS_TX_WR_DATA) + sc->corrected_error_pcie_tx_data_count++; + if (pcieeccsts & IGC_PCIEECCSTS_RETRY_BUF) + sc->corrected_error_pcie_retry_count++; + if (pcieeccsts != 0) + IGC_WRITE_REG(hw, IGC_PCIEECCSTS, pcieeccsts); +} + static void igc_update_stats_counters(struct igc_softc *sc) { @@ -2989,6 +3016,8 @@ igc_update_stats_counters(struct igc_softc *sc) sc->stats.tncrs += IGC_READ_REG(&sc->hw, IGC_TNCRS); sc->stats.htdpmc += IGC_READ_REG(&sc->hw, IGC_HTDPMC); sc->stats.tsctc += IGC_READ_REG(&sc->hw, IGC_TSCTC); + + igc_update_ecc_stats(sc); } static uint64_t @@ -3147,6 +3176,17 @@ igc_add_hw_stats(struct igc_softc *sc) SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, "fatal_unknown", CTLFLAG_RD, &sc->fatal_error_unknown_count, "Fatal memory errors without a reported region"); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, "corrected_dma", + CTLFLAG_RD, &sc->corrected_error_dma_count, + "Corrected DMA memory error indications"); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, + "corrected_pcie_tx_data", CTLFLAG_RD, + &sc->corrected_error_pcie_tx_data_count, + "Corrected PCIe transmit-data memory error indications"); + SYSCTL_ADD_UQUAD(ctx, memerr_list, OID_AUTO, + "corrected_pcie_retry", CTLFLAG_RD, + &sc->corrected_error_pcie_retry_count, + "Corrected PCIe retry-buffer memory error indications"); eee_node = SYSCTL_ADD_NODE(ctx, child, OID_AUTO, "eee", CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, "Energy Efficient Ethernet statistics"); diff --git a/sys/dev/igc/if_igc.h b/sys/dev/igc/if_igc.h index 8b35e1f59a60..3457f5e477ff 100644 --- a/sys/dev/igc/if_igc.h +++ b/sys/dev/igc/if_igc.h @@ -424,6 +424,9 @@ struct igc_softc { uint64_t fatal_error_pcie_count; uint64_t fatal_error_dma_count; uint64_t fatal_error_unknown_count; + uint64_t corrected_error_dma_count; + uint64_t corrected_error_pcie_tx_data_count; + uint64_t corrected_error_pcie_retry_count; struct igc_hw_stats stats; u16 vf_ifp; };