From nobody Wed Aug 12 02:58:54 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKY9B4NJhz6m9HS for ; Wed, 12 Aug 2026 02:58:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKY9B3Yd1z3gnR for ; Wed, 12 Aug 2026 02:58:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786503534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rMm7kOFHKiBptafrDIL32FkzZfh7n7zDm6OM7gD3y74=; b=cTOy2nIEvUbgEds+ZUwKlOozc8iyeB2Bsqxqb26rOd/VsMT0lt+SXpGAvlJODm0Vz7MNWp 4ubNl+CtFJGOaCLehgHfEixL/QSQ940Mwe5qJA4vl8eJAfXz6v3+rRi/sZHgzf7gjoa5t7 MnmPZHVKw03OVnDQ+HDWpiSmyo7wK9oWVYPVDXtfo0sp7Rn/47Bd4kfR3EzrzDcBxqrGyU KyzYl3LYbhjll+PqOzIwfre2srfQ74CfMm7qdO5+0G02rbZhVkLdEWvscm7QipNZq/2ziR Ad+gBCt/+K4M42AAkFVgCV+IsJJrEWjFEgR8OWAe+5sIIMYFvqUHSgYZ+MXyqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786503534; a=rsa-sha256; cv=none; b=DkX126SsAvNGGP41w3PKa/00Tkx3BX0Wn9wt8e/kcDNZI4FvjcqDNuHck2Tr5OM/OlT/Jn ive82TwzZvtYZF/+Qs+ux71QYUQdkjIb7xdVJ9HvO+y/ivB+u3mMsCULX9Vavv/IyHdvMM +kkdUQlxZfmGY2+U560b7OvhNarAmW/7mnVDjiJkatd3vKZMlSLb+2UWV0YGQo0bamQ5IV f1LgD0xEqzKiRwgoHoqjhjt8CUh5+CRMTHibPhLS0Zjocmakx+wFQJvClL5fQ2Aq29BgEu LNvfs2aoNE2+Vidfcg0SzLkw9YkhF5MIaSaP17A6LCcHUFpW6hcO9JZwnDp5VQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786503534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rMm7kOFHKiBptafrDIL32FkzZfh7n7zDm6OM7gD3y74=; b=eAiItfkchsr71MOu/l+lPxe6XHgaZ1zAsJawPieYuzV3W9+UQ+Xv1pTwDKHB1S6f+2VzAN pVpnd2ZKoc2UHdovDbAAXCtLOziP1llX+Yj8x5sBHdmBQUF1oqtUlAcS85ExYyHJfXygD2 3lwgORLfg0EJUNTyISRZlYF8uuJc6jiNVFBsPMJorPYSiD/T3BugQDLwwn0SNAO6AUGSfr CvO2m6JFnP392JyjSGjBujUZHCrMNe0DFv+wQsdNtpIccE/vqVofFQThe+NkzxQ/+zTNdO vR7tkHx1RN6/MVEVJzP2SHxYgd6Vk2HOE2vR/uZ5xGHsMUOcgFYFg6pNCVKXyQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKY9B248Zz1KWt for ; Wed, 12 Aug 2026 02:58:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36904 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 12 Aug 2026 02:58:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 28f96cc3748f - main - e1000: Identify SerDes adapters with LED blink List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 28f96cc3748fc46408cc6ab6172f09bc2182cad7 Auto-Submitted: auto-generated Date: Wed, 12 Aug 2026 02:58:54 +0000 Message-Id: <6a7be16e.36904.365fd219@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=28f96cc3748fc46408cc6ab6172f09bc2182cad7 commit 28f96cc3748fc46408cc6ab6172f09bc2182cad7 Author: Kevin Bowling AuthorDate: 2026-08-12 00:29:17 +0000 Commit: Kevin Bowling CommitDate: 2026-08-12 02:58:08 +0000 e1000: Identify SerDes adapters with LED blink The generic LED on and off operations do not handle internal SerDes media, leaving the led(4) device ineffective on my I210 fiber port. Use the hardware blink operation for the on phase on internal SerDes. The off phase restores the saved OEM LED configuration as before. MFC after: 2 weeks --- sys/dev/e1000/if_em.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 5a02514a89e3..66a298ecf21c 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -5517,7 +5517,10 @@ em_if_led_func(if_ctx_t ctx, int onoff) if (onoff) { e1000_setup_led(&sc->hw); - e1000_led_on(&sc->hw); + if (sc->hw.phy.media_type == e1000_media_type_internal_serdes) + e1000_blink_led(&sc->hw); + else + e1000_led_on(&sc->hw); } else { e1000_led_off(&sc->hw); e1000_cleanup_led(&sc->hw);