From nobody Tue Aug 11 22:35:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKRKB1y3Nz6X8cQ for ; Tue, 11 Aug 2026 22:35:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKRK95rrBz3HQB for ; Tue, 11 Aug 2026 22:35:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786487725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HuVqqyNnWSii5e64JSOtFB22wMIBQM3WS4Ns9KZdsmY=; b=YWsSEJ5iWsCgQuClySf3qwErx8XxbMBM7ofDIsEeXih9I9BKq8xx87eBMTY3ooIucYphzk t++UYLCNGsqbm5Ty2LDqaF3o+KLf2r2tPXha9PPjuoWzMYuTBs+DDH9hpoE4pKdu/uXX2m u8NF/rua0C5n6exAgtRao8vopLm5XRQcPMXsHaDkCDWhUKgWvZN7KLGLx5jtd+JasWzjpM H5hCeWNbsN0dBgA5AKkqrz0aq03pI2+GKfrPu35ErZAQlFDNFQ/J3bPk2wGb2Ju6kB6GWy w+fIwPMvVrdmhlnk5wAfhclx+BiyJ1MWFmYYMeXc0ouUnauLQLwaa6Aka0jEJQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786487725; a=rsa-sha256; cv=none; b=uM/VEcGZdRloDSEKZzCC5Dsy/TuGCgwPTbUo0TOXen0SUWdpNwPMXktVo2fG3Dc45eQx8J Ev/slyGg1hEKkTlx0PmgpPymrLU01g/ZfzHTI7ey2UpzSBU/1Qq9WWzvus92HWuPmm3dbY 5IBBDK9/WhqrSVZl9vDZsdpz3LT9QR1ZvmfGFMe9qY53JipG3bYilxVeF9K4/c5hmLRBH2 kSrsvxKQc63TBGPcOBhYz0ioZk9uXhXFXOZ01URDqD/s2Ff84phSCjYPbtojk5IvkYm4P5 B78eZOKep6iTBsnBVXO9ybT3EbSwWIoG0xAAYLmBdz6gCQARTXIqIeK1Mpkxzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786487725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HuVqqyNnWSii5e64JSOtFB22wMIBQM3WS4Ns9KZdsmY=; b=wWKM50+P7sH8RmHopBWmV1ZYEVg9VRgKlju9YIt4LiZpLdQlHrwDzqXuiubeY35miydEmi r2ZNNrlOA8QK8WK/He7AORi90mqbZ/MG4ULyZsec7Htq05wdJRVmCu2/7AwutWMIRKgBwG uR/mghB+pju9zkXfbm6mOcLhfaWwKi66MHdyltG0lYeX85vz5BvjAaejlSmiF9cssyFvc4 SEUKX/FGyPSRiBLJT4HmrVhPdOJL9Hcg1/ZxVoBGr6H53Bwxa04xMps2eYK7/3lNKYJh2G jYUN/CYDtN/Vp4aYbXBQAhLQkOlt/FLYgXxrfQMcxdjNqNJ0Z53+chZOUYJ/hw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKRK94329z1CsG for ; Tue, 11 Aug 2026 22:35:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41fcb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 22:35:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jose Luis Duran Subject: git: 59d6422d6f21 - main - makefs: Allow "legacy" as a valid ZFS mountpoint List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 59d6422d6f21fd5cf4709ce9fcada54d3925a4f6 Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 22:35:25 +0000 Message-Id: <6a7ba3ad.41fcb.2647af7f@gitrepo.freebsd.org> The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=59d6422d6f21fd5cf4709ce9fcada54d3925a4f6 commit 59d6422d6f21fd5cf4709ce9fcada54d3925a4f6 Author: Jose Luis Duran AuthorDate: 2026-08-11 22:34:16 +0000 Commit: Jose Luis Duran CommitDate: 2026-08-11 22:34:16 +0000 makefs: Allow "legacy" as a valid ZFS mountpoint Allow "legacy" alongside "none" as a valid value for the ZFS mountpoint property, matching zfsprops(7). Reviewed by: imp, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D58781 --- usr.sbin/makefs/tests/makefs_zfs_tests.sh | 39 +++++++++++++++++++++++++++++++ usr.sbin/makefs/zfs/dsl.c | 5 ++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/usr.sbin/makefs/tests/makefs_zfs_tests.sh b/usr.sbin/makefs/tests/makefs_zfs_tests.sh index 0a6e5597499f..5b6c701ca291 100644 --- a/usr.sbin/makefs/tests/makefs_zfs_tests.sh +++ b/usr.sbin/makefs/tests/makefs_zfs_tests.sh @@ -654,6 +654,44 @@ multi_dataset_4_cleanup() common_cleanup } +# +# Create a legacy dataset. +# +atf_test_case multi_dataset_5 cleanup +multi_dataset_5_body() +{ + create_test_dirs + cd $TEST_INPUTS_DIR + + mkdir dir1 + echo a > dir1/a + + cd - + + atf_check $MAKEFS -s 1g -o rootpath=/ -o poolname=$ZFS_POOL_NAME \ + -o fs=${ZFS_POOL_NAME}/dir1\;canmount=noauto\;mountpoint=legacy \ + $TEST_IMAGE $TEST_INPUTS_DIR + + import_image + + atf_check -o inline:legacy\\n \ + zfs list -H -o mountpoint ${ZFS_POOL_NAME}/dir1 + + check_image_contents + + atf_check zfs set mountpoint=/dir1 ${ZFS_POOL_NAME}/dir1 + atf_check zfs mount ${ZFS_POOL_NAME}/dir1 + atf_check -o inline:${TEST_MOUNT_DIR}/dir1\\n \ + zfs list -H -o mountpoint ${ZFS_POOL_NAME}/dir1 + + # dir1/a should be part of the root dataset, not dir1. + atf_check -s not-exit:0 -e not-empty stat ${TEST_MOUNT_DIR}/dir1/a +} +multi_dataset_5_cleanup() +{ + common_cleanup +} + # # Validate handling of multiple staging directories. # @@ -1043,6 +1081,7 @@ atf_init_test_cases() atf_add_test_case multi_dataset_2 atf_add_test_case multi_dataset_3 atf_add_test_case multi_dataset_4 + atf_add_test_case multi_dataset_5 atf_add_test_case multi_staging_1 atf_add_test_case multi_staging_2 atf_add_test_case reproducible diff --git a/usr.sbin/makefs/zfs/dsl.c b/usr.sbin/makefs/zfs/dsl.c index 7a634272b7d4..8c336131cea0 100644 --- a/usr.sbin/makefs/zfs/dsl.c +++ b/usr.sbin/makefs/zfs/dsl.c @@ -103,7 +103,8 @@ dsl_dir_get_mountpoint(zfs_opt_t *zfs, zfs_dsl_dir_t *dir) char *mountpoint; if (nvlist_find_string(dir->propsnv, "mountpoint", &mountpoint) == 0) { - if (strcmp(mountpoint, "none") == 0) + if (strcmp(mountpoint, "none") == 0 || + strcmp(mountpoint, "legacy") == 0) return (NULL); } else { /* @@ -165,7 +166,7 @@ dsl_dir_set_prop(zfs_opt_t *zfs, zfs_dsl_dir_t *dir, const char *key, errx(1, "property `%s' already set", key); if (strcmp(key, "mountpoint") == 0) { - if (strcmp(val, "none") != 0) { + if (strcmp(val, "none") != 0 && strcmp(val, "legacy") != 0) { if (val[0] != '/') errx(1, "mountpoint `%s' is not absolute", val); if (strcmp(val, zfs->rootpath) != 0 &&