From nobody Tue Aug 11 21:00:13 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCL2Zxwz6X1Qb for ; Tue, 11 Aug 2026 21:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKPCK62mTz4CfY for ; Tue, 11 Aug 2026 21:00:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L+Ml6DetaGjIqYXsZB6x58wtYJM7a1AkJGY19bJoCt4=; b=wuqgSV9KR9b2kDlohvekGDGb3w04aZeBolOKtYAaDjXw+JUMc2/nmD9zL+VUhd+lE1xR7B iIsqgX3w9/a9fg353JB/ycda0Qr+7hYdXmEd6qZtALSlIyEVT6jRAmwo48SxzaZT+okvT6 QRSIcpZaoR+D+jCX0SCdxfCyp4bg4ieYRbmmva5CYnsbEcVyHWBcsXG+1tF6boM86wJjoc jqZV7oIdNLtOOpjTtKY8f+2xNh3QUMGfxX6QZYNkqn9mbNtu83gPfYWOf5ASq55pqwcb+W 2Yz6GFo4wk+RpFOaWJJWoWvxjXzgVI/SqMWZ42WkPMMPWcQ7MmuiqOlfWm7CEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786482013; a=rsa-sha256; cv=none; b=dj9Vcw1LZJeBVqSO4h05V4O5Ojabta93M7MgwkbgPJRM/zeBTfWL+2664TosYwOTThIiLg i7qGXpzS4jQi2vByRhzfxdXiP+ahbKY/ClYnKvtJw1twKP01RikMAVZf3p9fP/dPB/e038 sCVPpuJfj6grbhbrb97zGLXh7mUZdJzvqt87vXEnX6IbdF32MEjCD3GzKjDCftU/24iNeq bAS9WzIHKY84UShTHbshpN59WLPN3JgyDPcn3ZUiwHOsohr7dDNuWVdSKRf++U+RD7gF81 4QcclN5aq0ZTry1dyHkBcC7JDBoHWZeH5Tkb722edLqnhk3697rggiqg202Yiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L+Ml6DetaGjIqYXsZB6x58wtYJM7a1AkJGY19bJoCt4=; b=s2oTVXeIa/Ki3CJ02ohfuq0RPdAxNTZnyIN0aYRjrJ/6m5IjHZYv6XwVms7E7Duji8r04v JISDEqEgNUThgvAPJt3pQJ7r5tgywRct3AXfNSsibBpMCjPdJUVPZ72bAVNYiDRPilVOnE NQBEE/uWfEb9OK3RsC3LxkYozQxJMI9eNA8nuMpvIcLiaSNtCYqN7rY2eknQFXfm1OSeD6 2Fw6UE2yhNYLav3EsKvNh3n01mdVn9CMBXntEMtJYs6SSAC0gvSaNfao/XzCq770rKEHAj nHuRWzsbTAV2SyULK/bYUugYeV/pr2IBcNkCVBPpo8ymaG3jZNcnlMSNeuMCGA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCK4fskz19fW for ; Tue, 11 Aug 2026 21:00:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38d8c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 21:00:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: f5fd839fe688 - main - igc: Avoid a signed shift while assembling the PHY ID List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f5fd839fe688181e57171850ce51e4dec71e62fd Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 21:00:13 +0000 Message-Id: <6a7b8d5d.38d8c.4cb527cc@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f5fd839fe688181e57171850ce51e4dec71e62fd commit f5fd839fe688181e57171850ce51e4dec71e62fd Author: Kevin Bowling AuthorDate: 2026-08-11 19:40:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-11 20:59:33 +0000 igc: Avoid a signed shift while assembling the PHY ID The PHY identifier word is promoted to signed int when the cast is applied after the shift. Cast the 16-bit register value first so identifiers with their high bit set are assembled as unsigned data. MFC after: 2 weeks --- sys/dev/igc/igc_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/igc/igc_phy.c b/sys/dev/igc/igc_phy.c index 24ecefb2c625..fffdfad3b237 100644 --- a/sys/dev/igc/igc_phy.c +++ b/sys/dev/igc/igc_phy.c @@ -143,7 +143,7 @@ s32 igc_get_phy_id(struct igc_hw *hw) if (ret_val) return ret_val; - phy->id = (u32)(phy_id << 16); + phy->id = (u32)phy_id << 16; usec_delay(200); ret_val = phy->ops.read_reg(hw, PHY_ID2, &phy_id); if (ret_val)