From nobody Tue Aug 11 21:00:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCD0rzyz6X1QB for ; Tue, 11 Aug 2026 21:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKPCC3DtYz4CVm for ; Tue, 11 Aug 2026 21:00:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jX/+AOG9Q2LB5MRWSw0bXZnlJwVkvkmCj/UJjyB1IjY=; b=QBF+ksc4JNE4U3ZHRNoC8GAQaJOApY+N7CJSp50DguZL+tKr8yHtApPNb4McYWBO4ePuh6 6r9ZUxu1/SFofvwAzv07/q2xGK6EGguSqIHX6yrf7Q/gZyR6fpPnGHU5gymRR1jsw1Kfm3 lisXINanTaPESLEZQ2lzFzltQ3sEb3RqlNnsED4WNmIu0yptKOnka0YPyA65DNR5GVJkCh 7GQsrvqZ2uOVx9FZGW3knHJEwHMAQj46WlrG0/h4x/QzBf81T1iS7RgcSJxIP27iy07DPT Z4idnzpSJDOfSEfF2QZs/M0BqHDsM5L0/xxFkZ/Kf+sSLopNFKm4o0jtEgsBjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786482007; a=rsa-sha256; cv=none; b=xnVMdis2PiukDIdcb6Y7DaX8MTjSM57SzUz4ToqQ5FynKxsi1LwPaGbz2z4aDu4gPy+T6V uHYicNLThqwQXy8R5D8lQFZ1LMXWtH0sNiTh7bOU2Mqh2xWqAFZShrZwZ5NN2CxrbHXDUm fF6wrlxoXQ0nEIThQPEB5cmh8PZ2d8x13at3reZ/AwsTmVFhVCfXv6lWmCn4Wo+8/s9d+Q qyM9WbPbyZOEVKWbL5hKY42y9+FmaYfQM+OX/EeV8E3AZtl4uiaVkDgJmVDlQi1gHodlAZ z+2sy4+KVOclunUWgdgDzVem2SsLwtqNF+nDdHjYnFiLx/6cAMrdOPf99jpinQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jX/+AOG9Q2LB5MRWSw0bXZnlJwVkvkmCj/UJjyB1IjY=; b=uGRpVkHdCM+u2qunlTDzVmeohhzT+As/jcOdAFYDU43CSDyLrXBC+2s86Ri86xo2M31be6 KiH/LkdzscofzBrGtX09uUEHufHhfC1oM1ukd4ZYKZha4lesaA2s3VJRJE0/qvTB83I6fe NJbCvQPAwJxWgaMsI6Xyeb5S0qFYuRYWNv4MD0LqZu8Gi2McYkyp5kPmTXoGeU7554U+sW B+dDGaaAAXIEK+2CYzlJpvIjW/SVlvATiH7gFbtOTZNxR6SaMOdm0zZcZpQkWyDna27+HJ hASrGNhG0qsPQoABjVSeOGZaY4oHQ5UH0U1FiVy/94kqYv0f7YjwEfg3IokIew== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCC2B4zz19mN for ; Tue, 11 Aug 2026 21:00:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38e87 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 21:00:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: bbdd3c4692e2 - main - ixgbe: Avoid signed overflow in LED register masks List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bbdd3c4692e2869817f77c359b4a2719e716921d Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 21:00:07 +0000 Message-Id: <6a7b8d57.38e87.4f0b835@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=bbdd3c4692e2869817f77c359b4a2719e716921d commit bbdd3c4692e2869817f77c359b4a2719e716921d Author: Kevin Bowling AuthorDate: 2026-08-11 19:34:50 +0000 Commit: Kevin Bowling CommitDate: 2026-08-11 20:59:33 +0000 ixgbe: Avoid signed overflow in LED register masks LED index three shifts the blink bit into bit 31. Convert the base to the register width before shifting so the operation is unsigned. This is the ixgbe counterpart of the e1000 correction imported from DPDK commit 214cb0d7f1. MFC after: 2 weeks --- sys/dev/ixgbe/ixgbe_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/ixgbe_type.h b/sys/dev/ixgbe/ixgbe_type.h index 4986673b65c4..9222d8d54fd0 100644 --- a/sys/dev/ixgbe/ixgbe_type.h +++ b/sys/dev/ixgbe/ixgbe_type.h @@ -2228,7 +2228,7 @@ enum { #define IXGBE_LED_IVRT_BASE 0x00000040 #define IXGBE_LED_BLINK_BASE 0x00000080 #define IXGBE_LED_MODE_MASK_BASE 0x0000000F -#define IXGBE_LED_OFFSET(_base, _i) (_base << (8 * (_i))) +#define IXGBE_LED_OFFSET(_base, _i) ((u32)(_base) << (8 * (_i))) #define IXGBE_LED_MODE_SHIFT(_i) (8*(_i)) #define IXGBE_LED_IVRT(_i) IXGBE_LED_OFFSET(IXGBE_LED_IVRT_BASE, _i) #define IXGBE_LED_BLINK(_i) IXGBE_LED_OFFSET(IXGBE_LED_BLINK_BASE, _i)