From nobody Tue Aug 11 21:00:03 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKPC754Q0z6X17c for ; Tue, 11 Aug 2026 21:00:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKPC71nQbz4CTX for ; Tue, 11 Aug 2026 21:00:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FKY0wimDrb1+fDyX/L4lqLK3CSlCQGl1vhzFpqPF+fQ=; b=CDh1ut/kgmQk/is9FRpz8D/FiEqQXn/Pxz0Nqjutn7YcbqNcLXgPksUTFPCreTLWjhkM+Z RpdqEaDUkqB4LJ1zgo2kRiftvNfpTBw+3TH79D4ruOlUzoc33iJQzSVPTdAlwxNpF7JWnM EsLBid7+v1CwYt2EPw4dRhWp04MtcArwvpuUeMfec6NROkzJUREhkaMPSAwR/BSe7MRB3d oRf0ixKrnuxrervuYrzE7ZPucVJjX3EsmFnEwxvH1xCEplzb9zlbEBmFQxDbkCh1N9Bd3a 5ymsA4MgrQJYNL6U2JVq58Ycd4VncuBq9O3prNBREqI5ZHTB91/DO3ToM7HxOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786482003; a=rsa-sha256; cv=none; b=h4rdRl9ebB7P0TkFuOnY/Tg77d6GFOaYy4yJqE5JA2fm2xkZtzYpOnOlaE/rLl0dzOnjBo +ACFHRlhMSaMwernFyF8DT5YqxnbEVFHtfdeX/zbFYMtdTjgDBIjPjkAGEKgyPLGnfWcE8 He9VNo0X/3BsEA4pndD9zMD1mZcq1u5pWx9Iw6wKI5wllWWOeTGZ37vPQgfZv7bz6S1UZe ID3Of2NB77C+e4IgJb4UARQIyGZVJwtOYf7f/SYaHiyLtoHEmc7Vok6aGLgQ9lE9GSQ+TQ daLMGvcdACaM271es3/aSI83geavR1m/b5MjBp4Huam4aUiFi2AhOOzwNQvMkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FKY0wimDrb1+fDyX/L4lqLK3CSlCQGl1vhzFpqPF+fQ=; b=E172+Y3EFl3zV8ZU0OCbi+NyOBU1JVvL7brTxGnWkk+nF+wZM16Cmnutk2F/At37EAtUMX E957SjZiOz5bsYhgZMNnZY5nP1VB229HNWmhk3vuMIpwoux0SqTdzg4YA/emmlrP60J2OI DwVq6pqw9v9Q0AeUG/HlAChWpjpL/u/yqPaSz7YPoZdQoQ3zlqJS+hg/bDLU60XFYgfZT+ CCf1SYIZBo/5R+xpNmkpSaXnAfY+Fihh2ySsq0+jycVqAt/HZnmATZF7QSaU3Wvuq8/LWE baH+rMJbkGYicSL+LE0wYfC816HrvPnkEk0lfR3TmZD2SlYMzGd27EOBV+8EJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKPC70rZhz19mH for ; Tue, 11 Aug 2026 21:00:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38f8e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 21:00:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Aleksandr Loktionov From: Kevin Bowling Subject: git: cba56bc3427d - main - igc: fix MAC address hash bit shift List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cba56bc3427db0bb4efc3d0117cda4bdc7717f98 Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 21:00:03 +0000 Message-Id: <6a7b8d53.38f8e.6be6eb8a@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=cba56bc3427db0bb4efc3d0117cda4bdc7717f98 commit cba56bc3427db0bb4efc3d0117cda4bdc7717f98 Author: Aleksandr Loktionov AuthorDate: 2026-08-11 19:34:01 +0000 Commit: Kevin Bowling CommitDate: 2026-08-11 20:59:32 +0000 igc: fix MAC address hash bit shift DPDK commit message net/e1000/base: fix MAC address hash bit shift In e1000_hash_mc_addr_generic() the expression: "mc_addr[4] >> 8 - bit_shift", right shifting "mc_addr[4]" shift by more than 7 bits always yields zero, so hash becomes not so different. Add initialization with bit_shift = 1, and add a loop condition to ensure bit_shift will be always in [1..8] range. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Aleksandr Loktionov Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (1749e662f6) MFC after: 2 weeks --- sys/dev/igc/igc_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/igc/igc_mac.c b/sys/dev/igc/igc_mac.c index 6a00867c7a8e..2c32f0c7a606 100644 --- a/sys/dev/igc/igc_mac.c +++ b/sys/dev/igc/igc_mac.c @@ -301,7 +301,7 @@ int igc_rar_set_generic(struct igc_hw *hw, u8 *addr, u32 index) u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) { u32 hash_value, hash_mask; - u8 bit_shift = 0; + u8 bit_shift = 1; DEBUGFUNC("igc_hash_mc_addr_generic"); @@ -311,7 +311,7 @@ u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) /* For a mc_filter_type of 0, bit_shift is the number of left-shifts * where 0xFF would still fall within the hash mask. */ - while (hash_mask >> bit_shift != 0xFF) + while (bit_shift < 4 && hash_mask >> bit_shift != 0xFF) bit_shift++; /* The portion of the address that is used for the hash table