From nobody Tue Aug 11 20:59:55 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKPC00ts7z6X17L for ; Tue, 11 Aug 2026 20:59:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKPBz5rYsz4CQX for ; Tue, 11 Aug 2026 20:59:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786481995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CRSncKViQX9qoQmfoeTEoeIXaBP8oqz8y23Mj8aClbU=; b=AO20aVrK6nqDQ0/sNYqCqxsRORG5PyZEbvPMF+cvigexXDAPzdquiPSNVm/OXlk9gDr02R JTVlNqVO8fbkzAG3VI/algukfedyxCJjvjN9/a4IT3qi5mx51Dy0nbbC8U8a9AOxc5x38L uWudyytF/VHpDZMPPptmt13cWx4jL0EDVmqcl2Rr0uoSiuABp7CGWw6lz+JtZ79AcRy5oC M6s5N7N4E5iMOKbLQ63EJ4zFfslzQtKLk5KQEPVuZu6ftnIF6yWxOQVjTozSlvfoRWTAf0 mSMxjPczPyjuAppH1mjV55g8f7e7HmItD+JDGREeUfNXVfu298X3EEvYHMXs4Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786481995; a=rsa-sha256; cv=none; b=VEdXXcThS4mOr95ijonXfdUAmyT4Qdh7mNOSnaTAIAMxs7hADEf7Ala8e7GjSXxiG99ESc VBMIiHdS6zYZ4C3PcgMmWo/8Kd3QdG3A0wTKP/AAzlcMWDs7C/CHxMV2UCoSdo5oGpj8lb 2fellF8l1Kv16a4OOay3bn6JhdA0gv7NsDcv741FSTacffdsKZoEuxS/4WR5cEmRIQ8L+B qkAD1oeQxps15X5U1gFGibeSkrR5BdestJsaQjad8ntEaDpf7vFm4WPoJcS1bPyOTpYHhH OeuWJkq7Lw7yL3jyudVpPddsLMvfjJT02e6OR5VAW/OEmFrE2NjUlWrecA87fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786481995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CRSncKViQX9qoQmfoeTEoeIXaBP8oqz8y23Mj8aClbU=; b=gVthPjwg+tVrAJpnJbkX4Q34TFeOtdjFjKKckMIOvQY4/uCwUaIHTZ0tcdQt0nEtEEBAW1 NleeGNHtBzMe3X3Y/zRybSjCFhPtrA/MRMWlORJdw/mqoObFqFLRpOsh5SL85K6vBZ2zSc yX4wU2zArufqbu3CYpPO22mwf4VXM8fLTL40lFJjIGIn3qMqtYto10osu7RI3GdT2uifj8 TkRpiJUrZjbjtVbkV9Dh7IuwGDmTgaeYY6cQMW5IzvEsKWn43bee049feXXK3nsXyreRWj lceULsVWqn7URZFqr7ALmWbpFayiMi9nn/8Vtdh6BnT5ANhkBv8GRFeH/DiJAA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKPBz3qqhz19SG for ; Tue, 11 Aug 2026 20:59:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36b57 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 20:59:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: a86d65b2c99b - main - e1000: Avoid a signed multicast bitmap shift List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a86d65b2c99bab3fe46389b3b51ad27956dccfe9 Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 20:59:55 +0000 Message-Id: <6a7b8d4b.36b57.6ee63e90@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=a86d65b2c99bab3fe46389b3b51ad27956dccfe9 commit a86d65b2c99bab3fe46389b3b51ad27956dccfe9 Author: Kevin Bowling AuthorDate: 2026-08-11 19:00:51 +0000 Commit: Kevin Bowling CommitDate: 2026-08-11 20:59:32 +0000 e1000: Avoid a signed multicast bitmap shift The multicast hash bit can be 31. Use an unsigned value so setting the bit cannot shift a signed integer into its sign bit. MFC after: 2 weeks --- sys/dev/e1000/e1000_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/e1000/e1000_mac.c b/sys/dev/e1000/e1000_mac.c index eb2c29d153dc..46e91773c126 100644 --- a/sys/dev/e1000/e1000_mac.c +++ b/sys/dev/e1000/e1000_mac.c @@ -611,7 +611,7 @@ void e1000_update_mc_addr_list_generic(struct e1000_hw *hw, hash_reg = (hash_value >> 5) & (hw->mac.mta_reg_count - 1); hash_bit = hash_value & 0x1F; - hw->mac.mta_shadow[hash_reg] |= (1 << hash_bit); + hw->mac.mta_shadow[hash_reg] |= 1U << hash_bit; mc_addr_list += (ETHER_ADDR_LEN); }