From nobody Tue Aug 11 14:59:54 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKFCf47NWz6nqyl; Tue, 11 Aug 2026 14:59:58 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKFCf3NDrz46XM; Tue, 11 Aug 2026 14:59:58 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786460398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K/yqFoB93iglOOojskZ5cLvDMCb6oV/X9SFdxNWzkjw=; b=IHXyWWqeZKGM9feh6e5hJVpqEHpx8uc92aESMLIQOmK3wlp7LhjgEhn9fTgmT/+j0pu34T BXp8BS+O7N6BIdmyzJUg+v9fYthssMz1l48nmRKJWnrTN7tcN7NQPmUBNvEfDuaL3LYgaj 5i6D3CPKIhxkhmUphhNGIduBKXo1bXkK+cKAjO6d3y4DB3pR2KIpnDuQwKS//RutU69FZ4 8B+5IoP4FPX48Hpv9+lZvU4N2o920imMpwWFgke1QXDu6Th36K8gtgUUoStGh/B+doNu5N dPOjdHnbhrdw85kVLLHfdiDJV2ZIterv8+MnicZj/P66KDuObF1VAGM2f2WyOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786460398; a=rsa-sha256; cv=none; b=FLDtkZ3EEsfvqnHLRsX8ZqTb0NkgcVDRd6fL4vZtEV7UA5PodbhsMGLgKOBS2ak+Aq22sK ZT2y6Wfl7zfAH4FYzrdD6LQ3Z4V6FC884IPKu9MmTfOPhlasWAX/Ai9olNt9NvwzXwuQoL nB/U6iosH0H36Xf9ncDTHln6Di1CcCH+br3O5CZYJHmkedyisA/y4TbQmnf/m55+TTdLAs cl2FuaNq9zimJOJRh5m8/rKb+ZHJXOaOQTavQDV/pO/YV2bbebYvSkGBgC/o56gEfAo1Vn e7kZVxRlOn2MUklNKmE5i3asgkhM/lRQCGWqPk8RSbh19ELw02wJxNEpmKXCBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786460398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K/yqFoB93iglOOojskZ5cLvDMCb6oV/X9SFdxNWzkjw=; b=PliGSLHVIeqzMsVcVYFRow2IRfAb/C4VOMlFn3QAZx5PjPPu/O5rjyR/SEwW2+9bPvE/z+ Ep7ONdenaY0GKlPS8FiGy9uwnIm1tlw6pOBVR2wiGUzjyaywVQrkuTpVOQKIWlEbuwu4PE gSlV+Yiw8HEaKPDpLnCkeLgauXdq/2vbpPeRWeB1OkCJm8p5c/n4WpiDu6aYuGrh0wMl+H OuAf+gl6/TZc1E8wITmcGoIDx8E0cPdHFqKWG3lDmcKRz+U3iX+y1i5c5bLjw1WJD9a+FL BYHx3oGfjZicgV18YphI21IGrv02CLQjHl0ou0I1hQS2vDx+zDYlebaF1V2lAA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hKFCd392TzKR0; Tue, 11 Aug 2026 14:59:57 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 11 Aug 2026 07:59:54 -0700 From: Gleb Smirnoff To: Kevin Bowling Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Eric Joyner Subject: Re: git: 1ccf543b21ef - main - ifconfig: Add SR-IOV VF status output Message-ID: References: <6a78228f.3fa89.2de83f53@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 10, 2026 at 12:03:00PM -0700, Kevin Bowling wrote: K> > On Sun, Aug 09, 2026 at 06:47:43AM +0000, Kevin Bowling wrote: K> > K> The branch main has been updated by kbowling: K> > K> K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=1ccf543b21eff6e0828142e5c1d09519247143f4 K> > K> K> > K> commit 1ccf543b21eff6e0828142e5c1d09519247143f4 K> > K> Author: Eric Joyner K> > K> AuthorDate: 2019-03-18 18:30:00 +0000 K> > K> Commit: Kevin Bowling K> > K> CommitDate: 2026-08-09 06:46:29 +0000 K> > K> K> > K> ifconfig: Add SR-IOV VF status output K> > K> K> > K> - Adds SR-IOV VF status to the existing ifconfig "-v" output K> > K> - Adds ioctl command for reporting VF status info from drivers K> > K> - Adds support to iflib for drivers to handle this new ioctl K> > K> - Add support for ioctl in ixl(4) K> > K> K> > K> Signed-off-by: Eric Joyner K> > K> K> > K> Relnotes: yes K> > K> Differential Revision: https://reviews.freebsd.org/D19647 K> > K> > This is not a reviewed change. The D19647 itself was not accepted 7 years ago. K> > Just an URL to reviews.freebsd.org doesn't warrant that change is reviewed. K> > Even if it was accepted, just 7 year lag itself requires a re-review. K> K> I reviewed it. K> K> > This particular change brings a lot of new ioctl(2) APIs. It is the opposite K> > of what other people were doing with ifconfig in the last years - reducing K> > ioctl use and switching to netlink. K> K> This was to give Eric proper credit and provenance, it is immediately K> replaced by an nvlist. A netlink interface is provided. What K> concretely is your suggestion? K> K> > Please revert this and start a proper review process. My suggestion was to revert the change and move towards reducing ioctl use in favor of netlink. Also, as Pouria rightfully noticed in response to other change, that packing of parameters should be bare netlink without nvlist as intermediate packing. -- Gleb Smirnoff