From nobody Mon Aug 10 19:03:00 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJkfv6NYXz6X92V for ; Mon, 10 Aug 2026 19:03:19 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJkfv2VFhz4Pfm for ; Mon, 10 Aug 2026 19:03:14 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-51c15bf5000so10655171cf.3 for ; Mon, 10 Aug 2026 12:03:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786388592; cv=none; d=google.com; s=arc-20260327; b=R3pIXg1lMZ+boXfx93CofHYcj56Z3Wlke1Wso1VG+vVm2e1sjuYqaXGfLZlNZVj5fo aZb/nnd1ewlexwofQg/SflLOxzehZk+fLSnVgDzLaHJ5kl5gZKcDrx8VOvLmj3W1eHYA ZpGeXi50XJE27/VasLJ6Oy3FD3PRkWU4YjEZnu8Bih/T/i4yV401voL2YTbLR3OCLZaj Q8UV3601MZP/D4J9j5ActDFbikIu7OTnJaokXCBBIqz/du0TO8LWBTVXXfLlH1RDr81g K/hujdn8OXNs6lPi5ebYagDQ1P6gUcaK7kcsVQR3bQ8VVpymLJ1wlru70y47bN2l06ZJ QXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IDJUH7UArpJOCcZKa/kpw5sK+2NBtpdEvThfb8jADW8=; fh=DmtpizWsCnbSgUlVQhLZoO4leJObQL5OTlKuCZkddNQ=; b=pEmEnetdfRA8v76Sme5XFUDkg3aUEgi/u/3KRfgTcxKcSQokJiBn3++fyk1riabSTj vMoRyW8b2isBYwyKFDVU4/jxL5XueB2cQrTpzOekjNq5HVJRBzmFIrYPWA19vMkG3jbR UUcsOLLQgrhMq+L3Cf/JbgkJBuFWCifkUAgk3SuWhlS6piwwJ64/47Nf8FrZ+maBL/Ko RCianHz4uC7AykqNt0AZ3uxIIog8hyIgOFmHfbCsxQbgUlnX5NaNjxWH7DRF8VgGbntb eUaKcjLXHWUOc02M6wRD2YTH61gSdYMywp25zE58spye7zGJOGDaiyf0FztjyLWXzn4O K9Tw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1786388592; x=1786993392; darn=freebsd.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IDJUH7UArpJOCcZKa/kpw5sK+2NBtpdEvThfb8jADW8=; b=FfBEl3ogHfSCCNA++FVqGxz8GfimPgApvny7dMBceHLk61GzJzYx4N6Rk6hJMZFsoL L4U/po2OjIFAj9ecNd9b3sc4j9cjsEiA0d8dImJkWhU6J595FH2tFPATm2hNnkAmTSul ELzQyiBGIIDgPwze6UiGLZKSYRAwgdaAqKKwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786388592; x=1786993392; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IDJUH7UArpJOCcZKa/kpw5sK+2NBtpdEvThfb8jADW8=; b=BjpsHwGSCOMuYmOEnzaekiE7knFu9hYBWjEhx1qxfbtwmiMn6jiWsKEqSg/n+k4Zgj eRbENGyC04EKz844j3S7R+7KU9ojK6inrIj3LWnvkRHrur2sH0UjuVvnrs6UVnEflld3 NqYSNb/YwsTVxUUO/1UzuVndwrifZLfX2MtwsA+2uzFQ+HYSzYEZd70k5ykrOY5CH62w u1NG6XD6evhGJCSyeESue9VI0BTR7GcQ97DeU1d8sp9YHb87BQsmm/Mxl/hE5Dye3yVq 7n0SyEfwABkzkzKAoBAZYsidIITEIMKWnPrLA3+z+r77wG8xI7WaiPfog95tTX3UCAlp mXww== X-Forwarded-Encrypted: i=1; AHgh+RpaWWnt9Qw7k800pIyL/KjKdiSyCsoGJiuCfNRMDKFqZcrKrBluPnZ1+4I/JS11mmXOTVFIig4pNuJgcWNrp5H/8j64vA==@freebsd.org X-Gm-Message-State: AOJu0YzrxtXQr+a0d/n+ln6b7hU002RSh8zKm57PcWVQLHNLmu7wLMWu 0pqsMqjvSHHqSDFZiwByOEnJknGlzdtKKyMW75Tb0COBpKYjsN7pOKC5yr8Gk0gmTzbO3kcnIDQ Fi5Fj3vziE/Y2nsaRARYBV460Yd9IS46EQm04NYGU X-Gm-Gg: AR+sD12HsaUIQRZ0LcYrzvljU62ejGjFEkgfz+Y4ntori1fSOFO6f5HzSl9AK5+ABdF xUH30+AmDxZUg3qdlnJD/p5Uz3/POxGMOCfYlkyPOvnriMpvzdqf9GDs5UkpWHTza2XamEsLIFs HSNxqt48JjvuLXxHdr03sIbwC9hI6ayoXIEao1p8rBIcuY6uMfsaUUT8g8C5HWckwRjz4ET7N/Z 5crYPM/7INkxc0NLQYFaWfIMf3/hOtsNYOvl0XHNYdxujA2XGxiY4l3FeCF/xZRsntmByb0xKpX PdcOSQH67yEen+XQU6eByDNaCasfi13DYjSmciqH5g5YwUyTExVl+YxFVgl1HRJKx4XdUR7seqM hBmAPFJQ3MhHwwIQWmCgcfJ71sh8rECSTRbfcAXPrL4bAgaQI6oGy+1h/bSyFNv1krojYxXk/Q8 oMc5NCaSGAlQ== X-Received: by 2002:ac8:7e86:0:b0:516:ea30:8756 with SMTP id d75a77b69052e-52d4c128000mr44603571cf.36.1786388591751; Mon, 10 Aug 2026 12:03:11 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a78228f.3fa89.2de83f53@gitrepo.freebsd.org> In-Reply-To: From: Kevin Bowling Date: Mon, 10 Aug 2026 12:03:00 -0700 X-Gm-Features: AUfX_mzdbagOJD1SAU1-BCRwhtln_NbTuKF6YwSg83lCAgx_QPjMijP63gzef2E Message-ID: Subject: Re: git: 1ccf543b21ef - main - ifconfig: Add SR-IOV VF status output To: Gleb Smirnoff Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Eric Joyner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4hJkfv2VFhz4Pfm X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- On Mon, Aug 10, 2026 at 11:57=E2=80=AFAM Gleb Smirnoff wrote: > > Kevin, > > On Sun, Aug 09, 2026 at 06:47:43AM +0000, Kevin Bowling wrote: > K> The branch main has been updated by kbowling: > K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=3D1ccf543b21eff6e0828142e= 5c1d09519247143f4 > K> > K> commit 1ccf543b21eff6e0828142e5c1d09519247143f4 > K> Author: Eric Joyner > K> AuthorDate: 2019-03-18 18:30:00 +0000 > K> Commit: Kevin Bowling > K> CommitDate: 2026-08-09 06:46:29 +0000 > K> > K> ifconfig: Add SR-IOV VF status output > K> > K> - Adds SR-IOV VF status to the existing ifconfig "-v" output > K> - Adds ioctl command for reporting VF status info from drivers > K> - Adds support to iflib for drivers to handle this new ioctl > K> - Add support for ioctl in ixl(4) > K> > K> Signed-off-by: Eric Joyner > K> > K> Relnotes: yes > K> Differential Revision: https://reviews.freebsd.org/D19647 > > This is not a reviewed change. The D19647 itself was not accepted 7 year= s ago. > Just an URL to reviews.freebsd.org doesn't warrant that change is reviewe= d. > Even if it was accepted, just 7 year lag itself requires a re-review. I reviewed it. > This particular change brings a lot of new ioctl(2) APIs. It is the oppo= site > of what other people were doing with ifconfig in the last years - reducin= g > ioctl use and switching to netlink. This was to give Eric proper credit and provenance, it is immediately replaced by an nvlist. A netlink interface is provided. What concretely is your suggestion? > Please revert this and start a proper review process. > > -- > Gleb Smirnoff