From nobody Mon Aug 10 18:57:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJkX72W3sz6X8dH; Mon, 10 Aug 2026 18:57:27 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJkX71xQRz4NDZ; Mon, 10 Aug 2026 18:57:27 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786388247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KWbppYHVxq5TLg6LjB2XEaD2cm+XKfTl6tL+7HrwsoU=; b=JDUZPg1oxjrvwfCAxCpwR3AFA5kK9X0M3uhYSYNal+7CPVgK5h4rq02E2No8RH0Tuej9jb mq8cQ5hFtvRe3XKeR3oGPlcz1wHYfFIH5VcIVKdGkBZio6/N5NuGDsYXr3/zg0ccDFd1Lz 1rt2Yri4bI0xhGYaRY6RfchNykeFkW8WNh1oywRCYlBckVXlknPe2kutdjvuA/FwZYoWyi w3xncKUMDFSP25Fxl0pEPwijurZzjrZGruYdOSNoUvWB+79rNGM980FsOfMl9cI7ZfSz5l AmO8lMhtABl4IWZ4tmqZR4klKdJX+5yf09Xbvw6uh1k2ObRS5gq7icUgzjaf5g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786388247; a=rsa-sha256; cv=none; b=X32E3H7REoS5AOw6fUN2N5BjUQw+Qj7UFCxBvjWAlnpVoRJzHbA/mbErM/2LaiDYjbO2hq PJd3MXtNIbBUB90z6jOvcDw1tmlDc0/ea5oUuAT6uJ6P3NTFCz+gEgFbzmD5sxAJS7m+m2 MFme48KLMEnHByeOUxshz7iZbbuxYWxQgrfousqWo4d2gtXOc+XZXIlPFVYNJqrURk4C9R aLW1OtQAr2EGQIiNgF3wsQqDpmg8ZVptqemYGNtKSNydwr+Zb8T96dkRGCxRNtATmUweCA +apND1TF655TFpe/4pEzzMjZ8YE+/1/ylFtxNKwNwlicOkNmVN2ww+Gdg9Jxag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786388247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KWbppYHVxq5TLg6LjB2XEaD2cm+XKfTl6tL+7HrwsoU=; b=PAYjMaSat0XdckkGXCyg0aOlvIE51lL2CwrN91w+OcXGT5OWwkI4TZnBDWrE0O/hpjx/oH wCA8n1QLUkG+jkAR0du5gwkxUEKU17CFT5U+DH5MVZCoZ6TIDMSjN5WQ2LamQvC5pNPTYc GXsdv1ys/IMkYiiwuBE/EI4D98uM+uy3PabkWLBl4/2fIIbPNbKfNSk1sK2lWARICjwg2f GPL9/ANdhqaxwFhyf/yjE2aGI8sBUSpOistwOZlO+1zz0/POGF8iX1r69tb3Y1soJLt1ML M6zRH2egm45wvBRL2qFd0lTESykP6h5uHsPqp18s0XW9X/XCYWBqWvqhfyCjIQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hJkX63Lnsz16r6; Mon, 10 Aug 2026 18:57:26 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 10 Aug 2026 11:57:22 -0700 From: Gleb Smirnoff To: Kevin Bowling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Eric Joyner Subject: Re: git: 1ccf543b21ef - main - ifconfig: Add SR-IOV VF status output Message-ID: References: <6a78228f.3fa89.2de83f53@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a78228f.3fa89.2de83f53@gitrepo.freebsd.org> Kevin, On Sun, Aug 09, 2026 at 06:47:43AM +0000, Kevin Bowling wrote: K> The branch main has been updated by kbowling: K> K> URL: https://cgit.FreeBSD.org/src/commit/?id=1ccf543b21eff6e0828142e5c1d09519247143f4 K> K> commit 1ccf543b21eff6e0828142e5c1d09519247143f4 K> Author: Eric Joyner K> AuthorDate: 2019-03-18 18:30:00 +0000 K> Commit: Kevin Bowling K> CommitDate: 2026-08-09 06:46:29 +0000 K> K> ifconfig: Add SR-IOV VF status output K> K> - Adds SR-IOV VF status to the existing ifconfig "-v" output K> - Adds ioctl command for reporting VF status info from drivers K> - Adds support to iflib for drivers to handle this new ioctl K> - Add support for ioctl in ixl(4) K> K> Signed-off-by: Eric Joyner K> K> Relnotes: yes K> Differential Revision: https://reviews.freebsd.org/D19647 This is not a reviewed change. The D19647 itself was not accepted 7 years ago. Just an URL to reviews.freebsd.org doesn't warrant that change is reviewed. Even if it was accepted, just 7 year lag itself requires a re-review. This particular change brings a lot of new ioctl(2) APIs. It is the opposite of what other people were doing with ifconfig in the last years - reducing ioctl use and switching to netlink. Please revert this and start a proper review process. -- Gleb Smirnoff