From nobody Mon Aug 10 16:33:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJgKx3Mljz6p2DG for ; Mon, 10 Aug 2026 16:33:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJgKw35mxz3xM6 for ; Mon, 10 Aug 2026 16:33:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786379604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3MoD2POmFb0IgiLn6kWXiFs0R1pUfZcKZfzAEaPz0p0=; b=nbNPXplvvsKRqTvm7WJExsVwAlJFC2Vezwd703IGK1wOyvU8YcJeMZUaLWoSoryOb2R8z+ u+ZCsUZ6b2lydr08rTAHq2NXlyzW92cKQg0HEvo7SgUiGQ3lr7OrJ64byH7fTQ5fawYQEy Sx2498QmxrzuVs5pkZzc8Udb+vfSRruLgiezDGav6kQZ/SD249dEZh4a07BCT8KjePbYRz keAsOhnW5gRUDQb0eP9lsMGm8DCt8xxQNBovyIu9A/WbLtTrxVoSRbpXufwpAA4gmdFn0s QX5vGXyC/Kw7eJCd/FtPPUmbKhT7KHOzA2r4iM+OQGJ5NUaXE7H2t0P4sb6rZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786379604; a=rsa-sha256; cv=none; b=vQO8gN0rD2wjgZGslY/UnmMtz3qo+iJLNzByy6VGgRpNQ1i+zvtiCHHzQ4XXYaECAbO4o7 9TvvOTcUQoC+yAe6EcPZ06z5bO3iscI4OVykkV89kso5npGa9t7BPsFLjZyvW0kDXIAsKr ox+jkRjIk9RfWXhK3FtOUA/+vWkR+JllcNb+acQyxAXUpZIeKeMe3A449KzAU6aYcb0byr aG1UFoYYSMps5g18GyPFH5PGlw+w2L3EjO1LxoqvcM92oN4uB3WMTAuQDU9OTwTEHPnEhN Udfb2Ar1X/V21IkMFrCiZBl1o8VdXWemYX1s4YCla7HT3dLfgS3O7GFYnDGfPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786379604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3MoD2POmFb0IgiLn6kWXiFs0R1pUfZcKZfzAEaPz0p0=; b=Be59BM2EjzrBa6zdH6Ey90oY6oMu1rfVAYOMK7xtfi5u7ovjGJmnZThW+QDlGwUdZG9F5m qzIEp9uY4iSqwEA9Fe1Wn+yyLhy3HZyJU2teAjOmrocMtC4pWX7rdIMObvF4cKozBcCgGh Los6LH+E8AnqqN7Vkdhj+WGtjTJVCQlYNfr+WPH+DCWwcBrE1updj+6tC4sZHcBFORZR9B WWPxrIhf2g5O0mcUgRJhSsxnqiSU8A+WDBz+DoQC+gFtCO6UBXIQRGc8x9a0Xof1FJXAtQ hRlu/GkNlMa4s00+2HEIauxcGKhyqwpKSfQKTzfUoFTHRAgn0ZaS61MK+roStg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJgKw1Qqdz2Gw for ; Mon, 10 Aug 2026 16:33:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a03e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 16:33:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: c410551b9fea - main - ixgbe: Compare flow control against requested mode List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c410551b9feadf9b65f920fd25714fcda8299a56 Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 16:33:24 +0000 Message-Id: <6a79fd54.3a03e.2b09023a@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c410551b9feadf9b65f920fd25714fcda8299a56 commit c410551b9feadf9b65f920fd25714fcda8299a56 Author: Kevin Bowling AuthorDate: 2026-08-10 15:09:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-10 16:33:12 +0000 ixgbe: Compare flow control against requested mode The flow-control sysctl represents the configured policy, while current_mode is the mode negotiated with the link partner. Comparing a new request with current_mode can needlessly reprogram an unchanged policy or skip a requested policy change that happens to match the current negotiation result. Compare with requested_mode before deciding that no update is needed. MFC after: 2 weeks --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 9a998b03dbd7..49b383518df4 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -5264,7 +5264,7 @@ ixgbe_sysctl_flowcntl(SYSCTL_HANDLER_ARGS) /* Serialize the live register update with the administrative task. */ ctx_lock = iflib_ctx_lock_get(sc->ctx); sx_xlock(ctx_lock); - if (fc == sc->hw.fc.current_mode) + if (fc == sc->hw.fc.requested_mode) error = 0; else error = ixgbe_set_flowcntl(sc, fc);