From nobody Mon Aug 10 14:34:21 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJchb1GNJz6nsZ9 for ; Mon, 10 Aug 2026 14:34:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJchY6BTHz3bKv for ; Mon, 10 Aug 2026 14:34:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786372462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OxhnzBfYYMVv4kfu9wgSt8Ni3ZvgDuMDkz+98HDRPuc=; b=r9GVy23Ttk6+q9qw1OzojEKJq3sbcz14uaOVo6ZrtrMgvBegVpg3Wzpb9UMdwRWgiu6Nz2 y4oJEnpzWBzIizI0Bhck625CpGpxXhxNzwltJgAR/KHZgDkXhAJvRlqIY44GsnFSd2F+xf aUaIJXWNUM0cS4FaBBo4f1axFdUwpdzUuFRKY9wb4sC4EEzaLpoRqaQumctu7ndZH6Ve/d 3Xxb0/2dZ7FcXMLHr/40+lVU8sWHNzxMfTeeiRmXq5PhzI8d6Cfaas+s08J2a4EVWiqlxE CoufItaOX7Y5zaGHeP8EOA2PFVkpmLxa7intxAZxIW8KmBUUJd95UCS1Dgk3tQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786372462; a=rsa-sha256; cv=none; b=mupRc9guSqfcO5K6alKWzBEyk1MiNBo7qBE77jbNUYz5GvoN4T7nriS4RAEQtNPBwf7dVP ZqPbrObidLGe76Vr30/javTUhQDPLdyNYYLctlHsDox51LC98ZAS4/fpIs2QYXCR2zdCy7 C7bI6yPcwAmKcEWAnJZs3ZXUeUUakDTiYFC7yBAGNUp4xcGnS9/2WkM+2s/RaYl44YjmRw 07NyYwEUObt4Yw3AX6PPKsgSeqE3uN8iF4aKU31dwKgn99lvrKSIGRQw93cEtxdlN3rcIA +dyG6JR0TZqXbkdyzNNBwIU38/UFAhfTX0lbqI7kBKV5KDfXL/BLz+e6gNW5MQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786372462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OxhnzBfYYMVv4kfu9wgSt8Ni3ZvgDuMDkz+98HDRPuc=; b=fJdZpHDeQvnaeXxp6cQrmK7EFYKK7nSTBCQQMV57FaRWcZyn7FDO2CKFEQAa5vLgynajP7 yjPGY9SteQpVe3DGa/2PkIzR2fVF4Gl/m6+nmzuZifuyV3NHrjs90ISvqfSZwa8/trzDxB tAXPwFx81GNiBms+mCUNCH3AHwGJKw77aTAKwCK3uwRlJIf8oJspm8aVCx+OryS3+eRIR1 QoliSf0Rlh6G9CiW4F+w6dhGnr7VUs8mxUphCqNw4AVTMSLHmWIsKyh7KOCjK42L9o6NU/ gSpykvX4YGmcSUI3xjTATEgGbBC/yewaDak3LGX2BY2rGeVlJ2gAwsiPOGVIKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJchY4JF5z1BsS for ; Mon, 10 Aug 2026 14:34:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24240 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 14:34:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ishan Agrawal From: Kristof Provost Subject: git: 2ef4baaffce0 - main - libsysdecode: avoid extra commas for undecoded netlink attributes List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2ef4baaffce0ab71491085e68fefc92eff8e715c Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 14:34:21 +0000 Message-Id: <6a79e16d.24240.518d20ec@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=2ef4baaffce0ab71491085e68fefc92eff8e715c commit 2ef4baaffce0ab71491085e68fefc92eff8e715c Author: Ishan Agrawal AuthorDate: 2026-08-08 06:40:20 +0000 Commit: Kristof Provost CommitDate: 2026-08-10 14:33:32 +0000 libsysdecode: avoid extra commas for undecoded netlink attributes Signed-off-by: Ishan Agrawal Sponsored-by: Google LLC (GSoC 2026) Reviewed by: kp --- lib/libsysdecode/netlink.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/libsysdecode/netlink.c b/lib/libsysdecode/netlink.c index 56b5671b129d..2785b23cb98b 100644 --- a/lib/libsysdecode/netlink.c +++ b/lib/libsysdecode/netlink.c @@ -256,13 +256,14 @@ nl_decode_attrs_raw(FILE *fp, const struct nlattr *nla_head, size_t len, fprintf(fp, "{"); NLA_FOREACH_CONST(nla, nla_head, len) { - if (!first) - fprintf(fp, ","); - s = search_decoders(ps, pslen, nla->nla_type & NLA_TYPE_MASK); - if (s != NULL && s->cb != NULL) - s->cb(fp, nla, s->attr_name, s->args); + if (s != NULL && s->cb != NULL) { + if (!first) + fprintf(fp, ","); + + s->cb(fp, nla, s->attr_name, s->args); + } first = false; }