From nobody Mon Aug 10 08:49:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJT2n2Hnsz6nPDV for ; Mon, 10 Aug 2026 08:49:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJT2n0yldz3kd9 for ; Mon, 10 Aug 2026 08:49:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786351777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hPyt388KkbwF5eLUR2QCKuMY2wcT8G0SJErK1dKU9nk=; b=p1W8Xcwmjul4/44CstbLsfA785ISjajSuehz/94kb5y7jLmfIF3nOIEiSbU7QVL+d/Lph6 fyVt7Dts0HieZtVDGvBZiBlizsmGZ8+e73aZ/tss13bXlchu8EWrm1NrQ+aOX6DNbr02gg Gasos39ElP0jroTHDNEKXh6sJ7TXTtk1vXS35MSv++/6+pp/6/SuEEFHmYGEeaGrsR7w/I usnND8mixSNa69p3CIcNPl4Iso6d+K0DG4U+NQ8mTv2xYng6kloLTbIT+u7KCsLrJ/0snL 3v+tGlE8yRNnnJ8V9Mgz7eNBQwAZLuahmPncVxY5BdfQVgwUf1Rtti/Ia3krtg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786351777; a=rsa-sha256; cv=none; b=CoV6PRTKK0oc7YfdmikogBfnAEPoQrhqXm/7Wg3rZUpNUK9/0HnkOIFM0QgI9gEprXE+do 3FynFgu5vZLxA1hJBF9Jfks7nga6F/C/uqpY9kiry9vemKlqqn8OdHDvTG08S61n4NEGph oOc/KInoGJ1X5qPoI35lGr12BaJLTvxhF2LyW+n7/l0Q+veBzMqBUbZvgG/+GaGFobEs9d o/2k+WoZQtoOiF8Q0dq4Z9DW64GMnWtoet3LWVb9onh1UpZTO7ftYAotEfjfj2N/MwJghA 47N2NlkwCJ5mOB7dWRp1G40KEh1Fq3Y+aoNVY8VoRN+nalyAsHma1tTn+EMOYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786351777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hPyt388KkbwF5eLUR2QCKuMY2wcT8G0SJErK1dKU9nk=; b=YiLrsfnJbV3MsGxxQdPoAFrfeIOo5Rwelzud2m8yrkKBqisYD/PM1EoflNHRIVorrl0PHB jtPC1Qwq6a5O+OaSHRgge2Kkj0l0EuDlyjZMRKHKjqsGOh2WBy4y9YaKS/Xek0ewHv9UkW aYqRhu7nguStdHpJ4NwjI5FcMQ+N0d+VwEU+p/vP+5VKgEt0Yv4b7BSRRA3hzihKiPazqR 12ymewRkl3LWAZk3Ue1VMwXt1BX+T3Ic5RJWFBH5JqzfluLRJBUOGrjh0Y9KGv8SHgfr+A z8IGPWJ5Aut8h+5LIA9pMV6IdSNR90QDklwe8rUJVF8jqfnYQY84cN6stFx5Wg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJT2m73KKz12B3 for ; Mon, 10 Aug 2026 08:49:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 271ae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 08:49:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: ae122c544388 - main - ixl: Initialize VF sysctl contexts before use List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ae122c5443882ae4d3d19aacfcfd16a2c8d7b688 Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 08:49:36 +0000 Message-Id: <6a7990a0.271ae.40301d65@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=ae122c5443882ae4d3d19aacfcfd16a2c8d7b688 commit ae122c5443882ae4d3d19aacfcfd16a2c8d7b688 Author: Kevin Bowling AuthorDate: 2026-08-10 04:53:08 +0000 Commit: Kevin Bowling CommitDate: 2026-08-10 08:44:53 +0000 ixl: Initialize VF sysctl contexts before use The VF array is zeroed at allocation, but its sysctl contexts were only populated after each VF was successfully added. If VF setup failed, IOV teardown still passed every requested VF context to sysctl_ctx_free(). An untouched context is not an initialized empty TAILQ and caused a page fault during teardown. Initialize every VF context with the array so both successful setup and partial-failure cleanup have a valid lifetime. MFC after: 2 weeks --- sys/dev/ixl/ixl_pf_iov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixl/ixl_pf_iov.c b/sys/dev/ixl/ixl_pf_iov.c index de8e2c27b9eb..e749797fa700 100644 --- a/sys/dev/ixl/ixl_pf_iov.c +++ b/sys/dev/ixl/ixl_pf_iov.c @@ -1654,7 +1654,7 @@ ixl_if_iov_init(if_ctx_t ctx, uint16_t num_vfs, const nvlist_t *params) struct i40e_hw *hw; struct ixl_vsi *pf_vsi; enum i40e_status_code ret; - int error; + int error, i; hw = &pf->hw; pf_vsi = &pf->vsi; @@ -1665,6 +1665,8 @@ ixl_if_iov_init(if_ctx_t ctx, uint16_t num_vfs, const nvlist_t *params) error = ENOMEM; goto fail; } + for (i = 0; i < num_vfs; i++) + sysctl_ctx_init(&pf->vfs[i].vsi.sysctl_ctx); /* * Add the VEB and ...