From nobody Mon Aug 10 02:31:33 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJJfZ4zrMz6pVZ6 for ; Mon, 10 Aug 2026 02:31:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJJfY6Pg6z40Vs for ; Mon, 10 Aug 2026 02:31:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786329093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=65JUSdnwGLTqb/rq9ebPJtrr7vo5PWq37EnxYASlGIk=; b=ISE5jCW3JyKKbj01NzuPnit3GBNX4OccVD3kbubvLwU2vJVH7/o6WYghjtPPBgBytLr+/i 8D2IvZFAXosDIUqwgl85vI/YfTaTna5o6ybZrOs8rwkGj5TyQN0CmwEvPGAD99Ig84ZMX9 nMnCZNMqH2eGV752A4z6ok0vYuZY67kR/OVVhoTXnOWUizbpQt/L1/ozwbduee9cxzoW/R uAeHMmKIyj/6FP/AzmsD7e58zg5K0mdN5bv7/a4NIayhs1p4KCh+1Fpi79SbXBC1DRBNKG 1yNTsvivxMcGRQgMfmCy7Rsdvoi2BzRKBM1/WuQeZdFPEOtmkYEU2HUfBc3czA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786329093; a=rsa-sha256; cv=none; b=OGZUqPt7nHOKH/0B1CQNTP7z0dmHvyFscPZ7ccPl7EdyXVCTDrlnJVd+RpAZg2Ln59keAj 8wzpvKeh73yplgVj7bl7nvvcvxMzIHu3db5syNYGyzZiIDvlnbvRkazLSUdgIes0hMeYsX UbdTC9uiHqvs4NEZyXpafuYe9jtImawEjM6HqMxouSsukIZlbXltYTkj4szZQVpBdO9r01 BsdYgJg+9EtMbM412jtBt4RLnSUeJo2s3VlFXSV46q2y0oPpfx/C+RB06hg/JFf5JCVOIV pyHGni6JNuT9wmX6wkT5CGmrz9qn74UKB053Eguz2lo/7ulfQLqQ1FLHQNfY7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786329093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=65JUSdnwGLTqb/rq9ebPJtrr7vo5PWq37EnxYASlGIk=; b=oyAGCW82lyR17XBLJfL7W7JQCwN3xJ0Wd9BLN2PatCbHTrd5R0I2Yq/j09pLud6rhi93Uy xAG5tuJi7yubidEXUnlmKUTv/lC9hzYTMrQrxkOr2+aBfOw1++Qgk0qSwuUK9hH454+9nH zacRsb4kz7AjBmsOG5VXp2FRLFM9GuJK6PNiJcO1uDnkFAsvNGf4AOiXCUKBB1zkel19uy pRFVXIrOgrA09jIYuzHQsn/BZ6Pe2Ha4PP0xLNtalA4bx8hfa91+0tO7A1rGISru+EaM/h CVbK1IDWAlmiOUUjVKSyzkStNhaTkkBKlVrtHkJhYCaGRuvlFV0x7MoN1g2FCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJJfY530mzqlH for ; Mon, 10 Aug 2026 02:31:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f0a6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 02:31:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jaeyoon Choi Subject: git: 2d3296131624 - main - ufshci: free the taskqueue on detach List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2d32961316248fdff54a2a9fc24ac8b712fee9b0 Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 02:31:33 +0000 Message-Id: <6a793805.1f0a6.3e16583d@gitrepo.freebsd.org> The branch main has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=2d32961316248fdff54a2a9fc24ac8b712fee9b0 commit 2d32961316248fdff54a2a9fc24ac8b712fee9b0 Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:52:37 +0000 Commit: Jaeyoon Choi CommitDate: 2026-08-10 02:28:54 +0000 ufshci: free the taskqueue on detach ufshci_ctrlr_destruct() never freed the taskqueue. Every load and unload cycle leaked the taskqueue and its kernel thread. A task that was still queued could also run after the module was gone. Free the taskqueue in destruct. Do it after the interrupt teardown so nothing enqueues new work. A reset task that is still queued at this point races the queue teardown. That race is older than this change. The planned in-flight recovery rework will close it. Sponsored by: Samsung Electronics Reviewed by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D58670 --- sys/dev/ufshci/ufshci_ctrlr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/dev/ufshci/ufshci_ctrlr.c b/sys/dev/ufshci/ufshci_ctrlr.c index 421aa1e28124..bb07ad5f76da 100644 --- a/sys/dev/ufshci/ufshci_ctrlr.c +++ b/sys/dev/ufshci/ufshci_ctrlr.c @@ -448,6 +448,15 @@ ufshci_ctrlr_destruct(struct ufshci_controller *ctrlr, device_t dev) bus_release_resource(ctrlr->dev, SYS_RES_IRQ, rman_get_rid(ctrlr->res), ctrlr->res); + /* + * The interrupt and the timers are gone, so nothing enqueues new + * tasks. Free the taskqueue before the SIM teardown below. + */ + if (ctrlr->taskqueue != NULL) { + taskqueue_free(ctrlr->taskqueue); + ctrlr->taskqueue = NULL; + } + ufshci_sim_release_wlun_periph(ctrlr); mtx_lock(&ctrlr->sc_mtx);