git: 8085c5a5c1e5 - main - nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 13 Apr 2026 00:21:02 UTC
The branch main has been updated by rlibby:
URL: https://cgit.FreeBSD.org/src/commit/?id=8085c5a5c1e50eb478fb7b59fae201d9ab4207f0
commit 8085c5a5c1e50eb478fb7b59fae201d9ab4207f0
Author: Ryan Libby <rlibby@FreeBSD.org>
AuthorDate: 2026-04-12 23:39:41 +0000
Commit: Ryan Libby <rlibby@FreeBSD.org>
CommitDate: 2026-04-12 23:39:41 +0000
nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array
The size broke when upages was converted from array to double pointer.
Reported by: gcc -Wsizeof-pointer-div
Reviewed by: imp
Fixes: 82ff1c334b97 ("nvme: Allow larger user request sizes")
Differential Revision: https://reviews.freebsd.org/D56368
---
sys/dev/nvme/nvme_ctrlr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c
index e5094e909a24..447a824df8be 100644
--- a/sys/dev/nvme/nvme_ctrlr.c
+++ b/sys/dev/nvme/nvme_ctrlr.c
@@ -1518,8 +1518,8 @@ nvme_ctrlr_linux_passthru_cmd(struct nvme_controller *ctrlr,
}
if (is_user) {
ret = nvme_user_ioctl_req(npc->addr, npc->data_len,
- npc->opcode & 0x1, &upages, nitems(upages), &npages,
- &req, nvme_npc_done, npc);
+ npc->opcode & 0x1, &upages, nitems(upages_small),
+ &npages, &req, nvme_npc_done, npc);
if (ret != 0)
return (ret);
} else