Re: git: 9cab9fde5eda - main - virtual_oss: Port to base
Date: Mon, 29 Sep 2025 19:11:53 UTC
On Mon Sep 29, 2025 at 11:58 AM CEST, Peter Jeremy wrote: > On 2025-Sep-28 09:58:53 +0000, Christos Margiolis <christos@FreeBSD.org> wrote: >>The branch main has been updated by christos: >> >>URL: https://cgit.FreeBSD.org/src/commit/?id=9cab9fde5edad9b409dd2317a2aec7815e6d6bed >> >>commit 9cab9fde5edad9b409dd2317a2aec7815e6d6bed >>Author: Christos Margiolis <christos@FreeBSD.org> >>AuthorDate: 2025-09-28 09:56:52 +0000 >>Commit: Christos Margiolis <christos@FreeBSD.org> >>CommitDate: 2025-09-28 09:56:52 +0000 >> >> virtual_oss: Port to base > > This fails to compile if "WITHOUT_BLUETOOTH=yes" is specified (see below) > because bluetooth.h isn't available (as expected). It looks like > virtual_oss isn't taking that option into account when working out what > to compile. > > # Meta data file /usr/obj/usr/src/arm64.aarch64/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.pieo.meta > CMD cc -target aarch64-unknown-freebsd16.0 --sysroot=/usr/obj/usr/src/arm64.aarch64/tmp -B/usr/obj/usr/src/arm64.aarch64/tmp/usr/bin -fpie -DPIC -O2 -pipe -fno-common -I/usr/src/usr.sbin/virtual_oss/virtual_oss -I/usr/src/lib/virtual_oss/bt -mcpu=cortex-a53 -fPIE -g -gz=zlib -std=gnu17 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter -Wno-error=cast-function-type-mismatch -Qunused-arguments -c /usr/src/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.c -o bt_speaker.pieo > CMD > CWD /usr/obj/usr/src/arm64.aarch64/usr.sbin/virtual_oss/virtual_bt_speaker > TARGET bt_speaker.pieo > OODATE /usr/src/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.c > -- command output -- > /usr/src/usr.sbin/virtual_oss/virtual_bt_speaker/bt_speaker.c:45:10: fatal error: 'bluetooth.h' file not found > 45 | #include <bluetooth.h> > | ^~~~~~~~~~~~~ > 1 error generated. > > *** Error code 1 I haven't had time to test yet, but I will try tomorrow. Does the build work if you build virtual_bt_speaker(8) conditionally in the Makefile (i.e., usr.sbin/virtual_oss/Makefile)? Christos