Re: git: 2352b89d2f73 - main - nanobsd: Fix regressions from last cleanup

In reply to: Warner Losh : "git: 2352b89d2f73 - main - nanobsd: Fix regressions from last cleanup"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Enji Cooper (yaneurabeya) <yaneurabeya_at_gmail.com>
Date: Wed, 24 Sep 2025 22:27:13 UTC

> On Sep 24, 2025, at 9:44 AM, Warner Losh <imp@FreeBSD.org> wrote:
> 
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=2352b89d2f732e3fa33fbd494267f0d4cb917e51
> 
> commit 2352b89d2f732e3fa33fbd494267f0d4cb917e51
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2025-09-24 15:43:42 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-09-24 15:43:42 +0000
> 
>    nanobsd: Fix regressions from last cleanup
> 
>    c99bb5747f5e changed ( ) grouping into { }, but in these cases we chdir
>    and depended on the subshell not changing it for the caller. Restore the
>    old behavior. It seems to work w/o this change, true, but the old code
>    was intentionally like this.
> 
>    Fixes: c99bb5747f5e
>    Sponsored by:           Netflix

Thank you for fixing my faux pas Warner :/. I was actually considering leaving the curly braces in place and just adding ellipses around the affected instructions (it would have made the sub-shell scope explicit), but this is a great fix too.
-Enji