Re: git: 94a0f9f63e16 - main - kern/vfs_vnops.c: generalize the lock primitive for file foffset

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Fri, 19 Sep 2025 18:05:28 UTC

On Fri, Sep 19, 2025 at 05:25:11PM +0000, Colin Percival wrote:
> On 9/19/25 07:19, Konstantin Belousov wrote:
> > commit 94a0f9f63e164e4f3791bc7d105d6f267b4d47bc
> > 
> >      kern/vfs_vnops.c: generalize the lock primitive for file foffset
> >
> > +	atomic_clear_16(flagsp, lock_bit | lock_wait_bit);
> 
> Jenkins says this breaks powerpc64:
> 
> /usr/src/sys/kern/vfs_vnops.c:852:2: error: call to undeclared function
> 'atomic_clear_16'; ISO C99 and later do not support implicit function
> declarations [-Werror,-Wimplicit-function-declaration]
>   852 |         atomic_clear_16(flagsp, lock_bit | lock_wait_bit);
>       |         ^
> /usr/src/sys/kern/vfs_vnops.c:852:2: note: did you mean 'atomic_clear_int'?

D52626