Re: git: fd9e09cb2ab0 - main - kern: replace several EBADF with EINVAL

Reply: Konstantin Belousov : "Re: git: fd9e09cb2ab0 - main - kern: replace several EBADF with EINVAL"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Gleb Popov <arrowd_at_freebsd.org>
Date: Sat, 13 Sep 2025 18:55:52 UTC

This change affects following code inside the Qt library:
https://github.com/qt/qtbase/blob/d6cc7562689d8a07bc933178ea367706ca38e4ac/src/3rdparty/forkfd/forkfd.c#L902

The code in question expects to receive EBADF when being fed a wrong
type of the descriptor. Returning EINVAL makes sense to me, so maybe
we should patch Qt rather than revert this change?