From nobody Fri Sep 12 14:47:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cNchs2YmDz67XFS; Fri, 12 Sep 2025 14:47:25 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cNchs1jLLz45d7; Fri, 12 Sep 2025 14:47:25 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757688445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RpFQWlevE64cfxWTVqicRTWixgLU3bRUyxDvL7DUWdA=; b=GI67onWRZFUs7Ml2IOJnSA3ihdZnAsSbI64D14lmMrVo/71R7B87mxjBlG3cBOWEJoWVdK mdmMxQicvSZPJOcWBd8khw+BFlMLRoHWcoow58VEh0UlSetzKNg18neZeG3ri3DocCSx40 YalGaZo/HTT84sYBuZ4xj7GrdlarWTxwbI+yY0Qz3dAguYHKqYiQZK0AhOzMc2kJSay6Ur 9z8AmrZqAYjDOftg2KQd7ewwzAqH0q3F7iAbnRT+IpTY6RZ0oWq2mh0Ey2G67sBhEsRNwZ fPhz1ekdvXhbBejG1ftIav2/hAu7MsfN0errtuSkGFJeIYxAYPp0sQQRm47llA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757688445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RpFQWlevE64cfxWTVqicRTWixgLU3bRUyxDvL7DUWdA=; b=JfDaGpFHK/oUQepvq3+T6SScPYur+lg4TrtDiZTvtKakYRTCoAnVKZZ9vbgx3e7ySbJAmA XdA3d353o0plFD52p/go8Yn9JYateamnEPifXOUJylsWaqM2y0X545LKKVUzgHBm9pbZty CGqvEI+pX8NHNeGb9wq75NOWYW5DTrOE7DRT73uxGmr7oOW8vKFPIGtj6GTmyu0ZRGsM36 EmJjzqNwO3KtsjgVOffDxSHAa1IgpSImJ90jwsUpC3HI+/y36Veu3j12smdPPBG4XxB5ID yYrW2vjMIav9Ecx8G+F+N/gte7Ckxj+N4BQ6sa6B8PZvEDWYF3CUaIeHMRDdgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757688445; a=rsa-sha256; cv=none; b=b10REeboLRVzp9KzspA8j1Fz7XkADnPxj+IiF4XgbBM/qFLg5mzDTdK+W33u6nyk8KSWy+ CBp1wESzUBHqRGz9DshgKwEHGj8Kf+uNvz9zws1FyHB9t5SJUnwtYpfxAQZJHCniMDRhZQ PTZtKARDa/EfgI/7X5BKzKhmExSJqCMHRPfR5V5Z0BAFF8u01JqM6kG0+TSt9AEMYtvz8t 1nvaSjT5O1LGyCtcyX3dZLuulaRVncJveH1G8ZSTuQMLxUsXjy6eumN3Qlnf+AMhDxiMeG jJdcIfYeCVcKyxXLW+whBYT/r32XH5lWMm2nDgTDVEIXN8xUHPBoV9wXL3eu9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2001:19f0:6001:9db:98f0:9fe0:3545:10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cNchm5yMlzmKS; Fri, 12 Sep 2025 14:47:20 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: 22238759c57d - main - sys/bus.h: Some style(9) fixes From: Zhenlei Huang In-Reply-To: Date: Fri, 12 Sep 2025 22:47:05 +0800 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202509120456.58C4uwVD027045@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Sep 12, 2025, at 7:59 PM, Konstantin Belousov = wrote: >=20 > On Fri, Sep 12, 2025 at 04:56:58AM +0000, Zhenlei Huang wrote: >> The branch main has been updated by zlei: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D22238759c57d942865cf9d1a355a0d04= 819eb621 >>=20 >> commit 22238759c57d942865cf9d1a355a0d04819eb621 >> Author: Zhenlei Huang >> AuthorDate: 2025-09-12 04:55:14 +0000 >> Commit: Zhenlei Huang >> CommitDate: 2025-09-12 04:55:14 +0000 >>=20 >> sys/bus.h: Some style(9) fixes >>=20 >> and whitespace cleanup. >>=20 >> MFC after: 3 days >> --- >> sys/sys/bus.h | 38 ++++++++++++++++++++------------------ >> 1 file changed, 20 insertions(+), 18 deletions(-) >>=20 >> diff --git a/sys/sys/bus.h b/sys/sys/bus.h >> index dda27f4737b2..e7ce152160f8 100644 >> --- a/sys/sys/bus.h >> +++ b/sys/sys/bus.h >> @@ -78,7 +78,7 @@ typedef enum device_property_type { >> * The strings are placed one after the other, separated by NUL = characters. >> * Fields should be added after the last one and order maintained for = compatibility >> */ >> -#define BUS_USER_BUFFER (3*1024) >> +#define BUS_USER_BUFFER (3 * 1024) >> struct u_device { >> uintptr_t dv_handle; >> uintptr_t dv_parent; >> @@ -247,8 +247,8 @@ typedef struct devclass *devclass_t; >> * and may use regular mutexes. However, it is prohibited from >> * sleeping on a sleep queue. >> */ >> -typedef int driver_filter_t(void*); >> -typedef void driver_intr_t(void*); >> +typedef int driver_filter_t(void *); >> +typedef void driver_intr_t(void *); > What are the fixes there, specifically? >=20 One space is required between the type and *. >>=20 >> /** >> * @brief Interrupt type bits. >> @@ -476,18 +476,18 @@ int bus_generic_resume(device_t dev); >> int bus_generic_resume_child(device_t dev, device_t child); >> int bus_generic_setup_intr(device_t dev, device_t child, >> struct resource *irq, int flags, >> - driver_filter_t *filter, driver_intr_t = *intr,=20 >> + driver_filter_t *filter, driver_intr_t = *intr, >> void *arg, void **cookiep); > And there? >=20 > The continuation indent is completely wrong from the style(9) guide, > and the change just kept it, there and everywhere. Yes you're right, the fix is not complete. tools/build/checkstyle.pl = does not complain about the indent so I kept them the same style. Let me try to fix the indent ~ Best regards, Zhenlei