From nobody Tue Sep 09 18:54:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLtK474Tsz67J3g for ; Tue, 09 Sep 2025 18:54:16 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLtK42KCVz3tbj for ; Tue, 09 Sep 2025 18:54:16 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-45df09c7128so9475945e9.1 for ; Tue, 09 Sep 2025 11:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757444054; x=1758048854; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E8ecDhIQxGMoOaKlbPKiFmulcr00wJjRC6zeQeLMs4I=; b=XR0VCLVxOtKLoOKjGiDcf+S2PMsU1xEWu50cVM1wV93YddcBswB0ATbiuQ2fPuFvBB F2atBYjbi7htwKhw2qKIKRgkA74d/pNQjSt1sQa2tnKBaGKn8DaQGL7xX//lcN6TtlOi MYUqFsN7jJUfxR9vCaeRpVu39ccTFADOZdzFovzbmM9XlmdQRTGUG2GxQiufyWadTXAb RmK8wA6kK/AKfUYX+RmdIob/0oCgqvqKHFMEYDoYBLNbagae+Y3Or8tZ/Ldnpq4RPsQ2 QJ4d8xkX+nAVRMP7kJXXLKerpfzlg/+cFRsDgdLK67F+0DADaV1rikz5OaJP9EZ0vOK5 D0Sg== X-Forwarded-Encrypted: i=1; AJvYcCXOwbgQ/ukzEtVw3IcljTB32Ew7DBRzBMWrZf/qsG2gew2/PZ6u0ypQjYf4tW/8m4mmNVkQYSLhmwI4Gq58x6Gl126Mnw==@freebsd.org X-Gm-Message-State: AOJu0Ywbzdhh52oJ3tPyp9LS8AaA+KoSPOFSW25L/BKD1Ueyd12eLAEW hNEjgQqAfCzpicI8ZRR9tI5t9zP1onuBBZC8hKBZACy0Qs6Mp73fev3/1ehVzcYTgJQ= X-Gm-Gg: ASbGncuukvBP2mt1Qs0Xn3UqbKyavFTGodiGijAfSWshMSwXg4qFRJTs3bapyM4lSXY yTLLHQrXyFAiommr00jXo/NE71CFGWHG0VOJD0G8EcZ0Xo+ZRy9BHGlPJMzpRoac7KhdBJqaiSU 1qQTnryIPWJ4JUDH20143YpvAF1OniLGQsxSjBh8oW64RoIuBNkNIIAUCZpTVKKh9TiQ/qmwqOU nl8F7zQWEvG4LVc76Y83bIk5WgPq+L6g5yWaAf44RMnXC+siQI2KIzVlIfAL45t2Xmv0FonmxQ/ 6lq0GydQrElrk3/muRqmPwjzbyMQfJ3LzZNFFgU3XhfdCPjjUYQH9QnSJAl9UuBerJ4/NuRbZ1W QWnLZ1njQkiwCUST5RZztOy3GSezE/ixx9Mx2hwuhZ6f2F5NFgXlCoVQ5++4= X-Google-Smtp-Source: AGHT+IHPdB9ts1ARL2zQYX5jFejYCYBdMMIx8YuTHcR5lYhmQZUatySUBSBmi/h9ELEcjN1bQHPWwA== X-Received: by 2002:a05:600c:8b5c:b0:45b:9b9f:88cb with SMTP id 5b1f17b1804b1-45dd5b78584mr148088965e9.16.1757444053827; Tue, 09 Sep 2025 11:54:13 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7521c9a2esm4010877f8f.14.2025.09.09.11.54.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Sep 2025 11:54:13 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 16f600dc30b7 - main - jaildesc: replace EBADF with EINVAL From: Jessica Clarke In-Reply-To: Date: Tue, 9 Sep 2025 19:54:02 +0100 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202509091818.589II2D2005924@gitrepo.freebsd.org> <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> To: James Gritton X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cLtK42KCVz3tbj On 9 Sep 2025, at 19:52, James Gritton wrote: > On 2025-09-09 11:42, Jessica Clarke wrote: >> On 9 Sep 2025, at 19:18, Jamie Gritton wrote: >>> The branch main has been updated by jamie: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D16f600dc30b7bb82429660e540da802a= 1e3f7449 >>> commit 16f600dc30b7bb82429660e540da802a1e3f7449 >>> Author: Jamie Gritton >>> AuthorDate: 2025-09-09 18:13:11 +0000 >>> Commit: Jamie Gritton >>> CommitDate: 2025-09-09 18:13:11 +0000 >>> jaildesc: replace EBADF with EINVAL >>> Following fd9e09cb, EBADF is not the suitable error code for a = non- >>> jail descriptor passed to jail_set, jail_get, jail_attach_fd, and >>> jail_remove_fd. >>> Reported by: kib >> Will you be MFC=E2=80=99ing this fix, the error checking one and any = future >> fixes to the new jaildesc code? The original jaildesc commit made it = in >> in time for stable/15 so will be part of 15.0, so either important >> fixes need to be MFC=E2=80=99ed to ensure we release something = without bugs or >> it should be reverted in stable/15 and the whole series later = MFC=E2=80=99ed >> once deemed ready. Especially given the discussion about file object >> ownership I=E2=80=99m a bit concerned that we have something in = stable/15 that >> has a design, rather than implementation, aspect that might be wrong, >> and we really don=E2=80=99t want to be shipping a broken syscall ABI = if so. >> Jessica >=20 > Yes, I just forgot to set the MFC tag in the commit. This and some > following commits are all slated for MFC. >=20 > This will include the file permission API concerns, and the missing > jail descriptor kevent support. Those are coming soon (next few days) > but I'm pushing the low-hanging fruit out right now. Great, thank you for the quick confirmation that it was just that, as I hoped, and that the bigger items are being worked on. Jessica