Re: git: 458ac2b6e445 - main - umb.4: Improve synposis, add netmap

> On Aug 21, 2025, at 11:02 PM, Zhenlei Huang <zlei@FreeBSD.org> wrote:
> 
> 
> 
>> On Aug 21, 2025, at 10:08 PM, Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> wrote:
>> 
>> On 2025-08-20 23:21 -04:00 EDT, "Zhenlei Huang" <zlei@FreeBSD.org <mailto:zlei@FreeBSD.org>> wrote:
>>> Hi Alexander,
>>> 
>>> I'd presume umb(4) does not depends on netmap. A quick search of DEV_NETMAP
>>> 
>>> ```
>>> #ifdef DEV_NETMAP
>>> static void      umb_input(if_t , struct mbuf *);
>>> #endif
>>> ...
>>> #ifdef DEV_NETMAP
>>>        if_setinputfn(ifp, umb_input);
>>> #endif
>>> ```
>>> 
>>> I think the #ifdef can be removed. I currently do not have that hardware so I'd appreciate if someone can test it.
>> 
>> I didn't get that far myself, this commit was partially in response to comment 67 [0] on the original bug where a user got the driver working on FreeBSD 14 by adding `device netmap` to their kernconf, and it didn't work without that.
>> 
>> Should we send this to khorben?
>> 
>> [0] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67>
> 
> I replied to PR 263783. 

Hi Alexander,

I have just committed https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa <https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa> .
The man page now can be revised, I mean the netmap part should be removed.

> +.Cd "device netmap"

Best regards,
Zhenlei

> 
>> 
>> Best,
>> Alex
>> 
>>> 
>>> Best regards,
>>> Zhenlei
>>> 
>>>> On Aug 21, 2025, at 9:50 AM, Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> wrote:
>>>> 
>>>> The branch main has been updated by ziaee:
>>>> 
>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0 <https://cgit.freebsd.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0>
>>>> 
>>>> commit 458ac2b6e4452acc1a614352c8945ecc37667aa0
>>>> Author:     Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>>
>>>> AuthorDate: 2025-08-20 14:45:08 +0000
>>>> Commit:     Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>>
>>>> CommitDate: 2025-08-21 01:48:13 +0000
>>>> 
>>>>   umb.4: Improve synposis, add netmap
>>>> 
>>>>   Rewrite synopsis in a more consistent style, and add "device netmap",
>>>>   In FreeBSD 15, netmap is included in GENERIC/{amd64,arm64,powerpc64},
>>>>   but it still needs to be used in FreeBSD 14 or custom kernels which
>>>>   don't include GENERIC.
>>>> 
>>>>   MFC after:              umb does not mfc
>>>>   Reviewed by:            gbe
>>>>   Differential Revision:  https://reviews.freebsd.org/D51732 <https://reviews.freebsd.org/D51732>
>>>> ---
>>>> share/man/man4/umb.4 | 28 ++++++++++++++--------------
>>>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>>> 
>>>> diff --git a/share/man/man4/umb.4 b/share/man/man4/umb.4
>>>> index 7ecc9a39c1ca..311a50faf8e7 100644
>>>> --- a/share/man/man4/umb.4
>>>> +++ b/share/man/man4/umb.4
>>>> @@ -17,34 +17,34 @@
>>>> .\"
>>>> .\" $NetBSD: umb.4,v 1.4 2019/08/30 09:22:17 wiz Exp $
>>>> .\"
>>>> -.Dd May 11, 2025
>>>> +.Dd August 4, 2025
>>>> .Dt UMB 4
>>>> .Os
>>>> .Sh NAME
>>>> .Nm umb
>>>> .Nd USB Mobile Broadband Interface Model (MBIM) cellular modem driver
>>>> .Sh SYNOPSIS
>>>> -To compile this driver into the kernel,
>>>> -place the following lines in your
>>>> -kernel configuration file:
>>>> -.Bd -ragged -offset indent
>>>> +.Cd "device netmap"
>>>> .Cd "device usb"
>>>> .Cd "device umb"
>>>> -.Ed
>>>> .Pp
>>>> -Alternatively, to load the driver as a
>>>> -module at boot time, place the following line in
>>>> +In
>>>> .Xr loader.conf 5 :
>>>> -.Bd -literal -offset indent
>>>> -umb_load="YES"
>>>> -.Ed
>>>> -.Pp
>>>> -If neither of the above is done, the driver will automatically be loaded
>>>> -by devd(8) when the device is connected.
>>>> +.Cd umb_load="YES"
>>>> .Sh DESCRIPTION
>>>> The
>>>> .Nm
>>>> driver provides support for USB MBIM devices.
>>>> +If the appropriate hardware is detected,
>>>> +the driver will be loaded automatically by
>>>> +.Xr devmatch 8 .
>>>> +To load the driver manually,
>>>> +.Cm load
>>>> +it in
>>>> +.Xr loader.conf 5
>>>> +or at the
>>>> +.Xr loader 8
>>>> +prompt.
>>>> .Pp
>>>> MBIM devices establish connections via cellular networks such as
>>>> GPRS, UMTS, and LTE.