From nobody Wed Oct 29 17:58:39 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cxZjq65K8z6F5Gn; Wed, 29 Oct 2025 17:58:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cxZjq4txdz3ldZ; Wed, 29 Oct 2025 17:58:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761760719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E95zBf/nGYvEcIEE3cX5HCodYBbU9l7CfJGvCEpghHc=; b=ChpJ9MI69aifjl/TX7keXBoxS1t4VdYvcWQq2+plgiWoRW8ctMI2HzrMgUFh/Wz+WHjgL0 xp/F11RtLFos6GdS8cwZk/VwXH+IBH2U60PRJpJAnQLWwKNzQk+uxK6Kz6lAy0TNIM87+O CRR1nGHhZkmnPTeb4FxfFwR7LG9Yodnc0n1vxSMN6KeKEXLenodEa6RYF4LCa/U4GXRfL6 MrivJFXgFXGPeH+VztDphlKreZ9mZ9SxTLm4JsXsSqOmVByez8p+gwt3SvziTPqvgL1uyL GZcrkdNrWWeYsLqSPzaDzxJFxalNbQOlAnjJjkuUYwBJrKsuck8qdrL/rDpGfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761760719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E95zBf/nGYvEcIEE3cX5HCodYBbU9l7CfJGvCEpghHc=; b=oAmQedlOPCD5Atedi3lnncGQ3RNtyFbeKRsbnef7Xm0IYU5SoFDBcpM68/36IaQQa2guNp esMx7qQMy89MCLgjxbiJtgWqP8v1PO70sE5dxF92ghUDYy436u88RuNOSFHSAwg3ZNf5hG xIkh0kXwJ9X4MLShJ9ve4U+nhTBznj3ULLBIuVuDMhEy7KS8uWZVqUD5DqKOuYierlX6Ny TyF6YKMw9RdeJdQG9llaKAtiTBvOdHk7D2QmCBBzUr52VZUf+nNn9LIzCz5V4HedfM5e3F EtG7rbiWvW64NXjEhWR+eXpIhv0zcy4w8xFugR4NJa3KvhAScvwg1t/msQZtqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761760719; a=rsa-sha256; cv=none; b=MXo30wzAB0G4o8l3Jho6G0fFGGOy8LwunrWdMy0eWi8EoyhOgRCzk1BGrGxVOJZQR7Sv6C NtEw8D/+PGxhTwoVut50sThgHp1ULFi8jaT9tmNhxkmRejv61uvpJycqnPMFl2dfMLFqE6 SXBW1f0iwKkMqnQETlvfdkeVn2EXIlR+kalfuVpk1c7sUf0zd5KKr0PO+5IVZomipZsveB 1M3wDEOe3ZRAl3fTph/O+wPn3jx5m+Kld/Wnsh0FttOFrkniQI5BVvC2zZxq4iQ2F7MbWo 9fYBbsIswN1n1qR8+8KR9Ln1doT/XiBpQrVdRv+mV+0vWCikrLRw6kv44lGWOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cxZjq4SzZznQL; Wed, 29 Oct 2025 17:58:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59THwdsw096372; Wed, 29 Oct 2025 17:58:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59THwdHF096369; Wed, 29 Oct 2025 17:58:39 GMT (envelope-from git) Date: Wed, 29 Oct 2025 17:58:39 GMT Message-Id: <202510291758.59THwdHF096369@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 3bbdc0223a7c - main - acpi_gpiobus: implement bus_child_deleted List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3bbdc0223a7c1efaf734d3d9f3cb818e79e11d54 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=3bbdc0223a7c1efaf734d3d9f3cb818e79e11d54 commit 3bbdc0223a7c1efaf734d3d9f3cb818e79e11d54 Author: Ahmad Khalifa AuthorDate: 2025-10-29 17:52:51 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-29 17:58:00 +0000 acpi_gpiobus: implement bus_child_deleted Implement bus_child_deleted and attach the gpio_aei dev to it's ACPI handle. Reviewed by: wulf Differential Revision: https://reviews.freebsd.org/D51585 --- sys/dev/gpio/acpi_gpiobus.c | 17 +++++++++++++++++ sys/dev/gpio/gpiobus.c | 2 +- sys/dev/gpio/gpiobus_internal.h | 1 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c index 0d2455cab399..0c31f4fec16d 100644 --- a/sys/dev/gpio/acpi_gpiobus.c +++ b/sys/dev/gpio/acpi_gpiobus.c @@ -304,6 +304,12 @@ acpi_gpiobus_attach_aei(struct acpi_gpiobus_softc *sc, ACPI_HANDLE handle) devi->gpiobus.pins[i] = pins[i + 1]; free(pins, M_DEVBUF); + status = AcpiAttachData(aei_handle, acpi_fake_objhandler, child); + if (ACPI_FAILURE(status)) { + printf("WARNING: Unable to attach object data to %s - %s\n", + acpi_name(aei_handle), AcpiFormatException(status)); + } + bus_attach_children(sc->super_sc.sc_busdev); } @@ -427,6 +433,16 @@ acpi_gpiobus_child_location(device_t bus, device_t child, struct sbuf *sb) return (0); } +static void +acpi_gpiobus_child_deleted(device_t bus, device_t child) +{ + struct acpi_gpiobus_ivar *devi = device_get_ivars(child); + + if (acpi_get_device(devi->handle) == child) + AcpiDetachData(devi->handle, acpi_fake_objhandler); + gpiobus_child_deleted(bus, child); +} + static device_method_t acpi_gpiobus_methods[] = { /* Device interface */ DEVMETHOD(device_probe, acpi_gpiobus_probe), @@ -437,6 +453,7 @@ static device_method_t acpi_gpiobus_methods[] = { DEVMETHOD(bus_read_ivar, acpi_gpiobus_read_ivar), DEVMETHOD(bus_add_child, acpi_gpiobus_add_child), DEVMETHOD(bus_child_location, acpi_gpiobus_child_location), + DEVMETHOD(bus_child_deleted, acpi_gpiobus_child_deleted), DEVMETHOD_END }; diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c index 0fca02c41ca7..596e468d35f3 100644 --- a/sys/dev/gpio/gpiobus.c +++ b/sys/dev/gpio/gpiobus.c @@ -734,7 +734,7 @@ gpiobus_add_child(device_t dev, u_int order, const char *name, int unit) sizeof(struct gpiobus_ivar))); } -static void +void gpiobus_child_deleted(device_t dev, device_t child) { struct gpiobus_ivar *devi; diff --git a/sys/dev/gpio/gpiobus_internal.h b/sys/dev/gpio/gpiobus_internal.h index 58f862343403..be76450b2432 100644 --- a/sys/dev/gpio/gpiobus_internal.h +++ b/sys/dev/gpio/gpiobus_internal.h @@ -43,6 +43,7 @@ int gpiobus_read_ivar(device_t, device_t, int, uintptr_t *); int gpiobus_acquire_pin(device_t, uint32_t); void gpiobus_release_pin(device_t, uint32_t); int gpiobus_child_location(device_t, device_t, struct sbuf *); +void gpiobus_child_deleted(device_t, device_t); device_t gpiobus_add_child_common(device_t, u_int, const char *, int, size_t); int gpiobus_add_gpioc(device_t);