From nobody Wed Oct 29 17:58:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cxZjp4xsmz6F56c; Wed, 29 Oct 2025 17:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cxZjp4Bt4z3lZk; Wed, 29 Oct 2025 17:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761760718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TOn0FU1xUm8Uqn02cVHywyNikt+1LoSQNu/UVDW9vpM=; b=ex4gXKugzENydFn/sYcQ6ai4sXiOHu7UDHIxPpVE86L04MEiNl8O8dp6HlPfqK99sWc5/M DKo7/oAQO51+mxw3FfI3hVDxBaokDvplo60eETM+Y1BaSlcEHALJUpJcnG83f8WwHBw73O NKlMipIbD+A46De/rckWQf8IoXhQkcn3sHaj4aJqs2LgjQ9sPzOe8ZZG75K8I2UEBKBSUj 8629MhjnmuNn6oaYJDFLqiqSbYw24Z7BbE5v6ptlx1799P8n5ViCDPiC/3/HyPPMhw3Pgt QTdeHCBsBBRZ8iKuO4e7vWoNwKmj8mPeUwmt21N3b7d1ObSReDKVO37NBjNC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761760718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TOn0FU1xUm8Uqn02cVHywyNikt+1LoSQNu/UVDW9vpM=; b=WudswZK7Lg0DULTx3PEy45n45/X5KXm9H2dEfG+uHxpqpupMBymnVKtxD7SkpY8Cin47r1 X64idhFJbEUTtd9Ng4FFiS0YoyQyPIG8bFiGWAUYsKfHED2mSU3JUaoiaADK1oEWHHXf3L ACcvd9JSK5mcWKyPLT/KgKgXuerPYP+Su8M1/+h3BwzvB2rm/cLYJCjghMcO+BJzG5tMn/ J257hYmg5DARM2sehhdTadhQp3LBU3wrPGS+5aTx9TgQjan6ZgFr4FcbRXUCg7QFZ6cTZ1 zLTVboZSvn0ql1bgX2wWMVIhdKdvDGDtyxKSXexxf3UDKlXlbk/l2QkOa8iqAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761760718; a=rsa-sha256; cv=none; b=lOjpAe5svgTzp9Dw9syPqGWF5HaCq/AzmI2dyLY7d0tbFo6dmnqUOYh5s1us1rXZt78zKE Vp6YUc4EINmrHC92jfifiViolww9RUniLrlrqMb006l7FpICzZR0Hl+H/NtcrWH/0gUJCu iOP6nC/I4cMQ4ieJYOA3LAY2N93fG2jQhUjo69HLaEK+PO7Jf90hdI2BxnL51h4kN4inRH tlrN0b/uKv7DwOyaPsw7Pc8nbF7I3fPTTtpfpQ6Ra6hMp08Omewyfv8N72dbWsUf5AHQYD cCBdEtpoDoe858qa6W1ODiqEQ4s2mnaGuzcjRS2vwHjdeTxlAEluViiSazwY/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cxZjp3mHfzmtB; Wed, 29 Oct 2025 17:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59THwcln096338; Wed, 29 Oct 2025 17:58:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59THwcOZ096335; Wed, 29 Oct 2025 17:58:38 GMT (envelope-from git) Date: Wed, 29 Oct 2025 17:58:38 GMT Message-Id: <202510291758.59THwcOZ096335@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 330b4f470280 - main - gpiobus: use bus_generic_detach when detaching List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 330b4f470280ec42d1498f875b8873f6eb32a7dd Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=330b4f470280ec42d1498f875b8873f6eb32a7dd commit 330b4f470280ec42d1498f875b8873f6eb32a7dd Author: Ahmad Khalifa AuthorDate: 2025-10-29 17:53:05 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-29 17:57:59 +0000 gpiobus: use bus_generic_detach when detaching Use bus_generic_detach instead of bus_detach_children so the children actually get deleted. Reviewed by: jhb MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52305 --- sys/dev/gpio/gpiobus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c index 698b5e5fdd01..0fca02c41ca7 100644 --- a/sys/dev/gpio/gpiobus.c +++ b/sys/dev/gpio/gpiobus.c @@ -618,7 +618,7 @@ gpiobus_detach(device_t dev) ("gpiobus mutex not initialized")); GPIOBUS_LOCK_DESTROY(sc); - if ((err = bus_detach_children(dev)) != 0) + if ((err = bus_generic_detach(dev)) != 0) return (err); rman_fini(&sc->sc_intr_rman);