From nobody Tue Oct 28 22:36:14 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cx4wZ5mzPz6Dbd5; Tue, 28 Oct 2025 22:36:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cx4wZ4D89z3v9w; Tue, 28 Oct 2025 22:36:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761690974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHwLheLWLuobCAws3gSjkVaeVYZTh5VNemG8JlFnM2I=; b=m5mQ1hUUh1iqj2bST2LLJGB+3Aum2NHzrvYmKU+9oVvqEsHdcFgCjyU9oMfvCeLHZrlg9I vQ7CuHWJFO5z/ot0lnF7GGajfRq2zyZitICixJEf6UjUPfnB2eczzaBsQMHh8vxucHHczI kEOw9uzzPxJ5FEaSfY8bYXm8TerVxcxcplgi6tMM6ofJsfAqWQU+FZIjvVOypwKgc55rtg 2Yp4fLkXyRNPYih7JKWSyKzazBoELeWnW3jbNuzBe/GGsMkMzmgl0ugqolie/HaAhGe31E Mg/fXd9qIOG8PopzaSjrlW3h8DIOeN2rKELhEgfYXsr7QuHWa5zok9uHLuy0Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761690974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHwLheLWLuobCAws3gSjkVaeVYZTh5VNemG8JlFnM2I=; b=ttcUL/ar3Vyz81yY5sic5cB4GCyBwthUPYtkxzjw7rQT8Hwj7jPtJPCT++n1fi2PKQYaTW 5WijRg2uijmM6vH32aNG1dJK2oBjQuFSoroCk/vyo1HQ7mau+5S14P+Z98Vzw6OxmJ0qIe 0BQ8SlMyIa60H/Y6gdjBXyOdZMUMWOW1/Lq2msS47YK+CAKpCxh+mRC4MUP5SawcLD53/S QKyPyHKLnshZ1RQBahaSJ8mB7cXz0ohhru5uM9QpCPR4dqJwa/Tys7agHra2wDsim7YW1E XSlAalKtb8lQJr5Y/gSd4z+Oy0lXD0SD19r3wmk/R51w2PDT98VTXYFz9xx1Kg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761690974; a=rsa-sha256; cv=none; b=v8c5p2Mhyf9u2CUS/eFST3zxaBCDMRKhbdU6ACIeACm/A8Em6Q0fIuNO+S5P37rruEAzB/ JG0wxwCLyhyhEHwMl/cJ9SAFMZxGrYuwfvvEUFkzMVXx70oU8VWJNS9GPfzGsBJlkl0GwO 6ML4F/FfzqVRV3OQzA+WG4IH2O4lhIX5x7AG4GzPVq/GDvgotrhB+C0J0jVltlFwKZ7RVc sTKxzv0r4euYlImaZRZGWAyTTzZv0nzJln1Rz7JMkE6ePOz6gwCD8m0Fjrk0W8cLhnJvVz ECD6AGyqQiNCKJvMHIx/dM1yxtRyFtEjoejQMBZyt7WM5O0r2KcwkNWxxgrB9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cx4wZ3XsZz17pm; Tue, 28 Oct 2025 22:36:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59SMaEMW008576; Tue, 28 Oct 2025 22:36:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59SMaE3S008573; Tue, 28 Oct 2025 22:36:14 GMT (envelope-from git) Date: Tue, 28 Oct 2025 22:36:14 GMT Message-Id: <202510282236.59SMaE3S008573@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 471743e1315c - main - nvme: Remove a todo comment List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 471743e1315cdc54d85e3e77b53e3841b3647ea1 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=471743e1315cdc54d85e3e77b53e3841b3647ea1 commit 471743e1315cdc54d85e3e77b53e3841b3647ea1 Author: Warner Losh AuthorDate: 2025-10-28 22:33:36 +0000 Commit: Warner Losh CommitDate: 2025-10-28 22:35:33 +0000 nvme: Remove a todo comment The storage subsystem really wants one of a very small number of I/O errors. And since we started to do this I/O, EIO is the right error to return. Other errors may get different and weirder treatment up the stack, or even converted to just EIO. So remove this TODO comment that's been there since the initial nvme driver commit. It wouldn't be helpful to do this, and could likely hurt. Sponsored by: Netflix --- sys/dev/nvme/nvme_ns.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/nvme/nvme_ns.c b/sys/dev/nvme/nvme_ns.c index a759181a8c16..f4a588373c98 100644 --- a/sys/dev/nvme/nvme_ns.c +++ b/sys/dev/nvme/nvme_ns.c @@ -142,10 +142,6 @@ nvme_ns_strategy_done(void *arg, const struct nvme_completion *cpl) { struct bio *bp = arg; - /* - * TODO: add more extensive translation of NVMe status codes - * to different bio error codes (i.e. EIO, EINVAL, etc.) - */ if (nvme_completion_is_error(cpl)) { bp->bio_error = EIO; bp->bio_flags |= BIO_ERROR;