From nobody Mon Oct 27 16:19:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwJcM3ckcz6F0xj for ; Mon, 27 Oct 2025 16:19:31 +0000 (UTC) (envelope-from jlduran@gmail.com) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwJcL2ZHrz4MLR for ; Mon, 27 Oct 2025 16:19:30 +0000 (UTC) (envelope-from jlduran@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8a3c0086c41so29051085a.1 for ; Mon, 27 Oct 2025 09:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761581969; x=1762186769; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rYL/wyGYcPvp4j/Z/tLdDYawtPQ1slIuvDM9Hk8mueU=; b=DQA0foisoziMtcChasjHYYSDFCVADZYfnuWHgsRhu3YRGzNNJraEekmvByOLi5w3yR Xn4GRBanlTSHUojaMS/21XXgEhSI0EmqOu/DsM/BgbJSGwD9UV4QjJ/b/k+gSo8Bt6Y/ MAGhiI7SvbP6B9lHP8r1duyuRswrOcs5R9lxW6C56v4yBPcc6JoLXnSxk/tjm5E7WZ9H bW0kYSHE3OanxQEWBNdy3mFjZR4Rt2obzzTYiTeqNnL/5GBuVUqRC5/i+ie4f4XbHBgI qsoRoPHHDQcInAVF+bW2Z8dMiSAcQ9M1Y6e8qe2prANQbFWnw5jDEEN1A0y1vndSgaMb yQvw== X-Forwarded-Encrypted: i=1; AJvYcCUI2ICCW7GztcQMru7AOBBTwdRsqh5BWCrqKcRZYcKaqozmoHrhioo41taxaXCZSIfWdHuq7HLRVjhexTf98UEHBRj+Yw==@freebsd.org X-Gm-Message-State: AOJu0YztRJFx1kZkJMKz4LEdPag1tXHaVlxoJP7E72mVezi+pnNR5MUl WWoFekDZyBRfScXSyp0ndIstcC/Kjc7YRqdZU2RiiF5UWAHBoMGTbeRiQkBxeKzk4nY= X-Gm-Gg: ASbGncssK6+nHr/j17MnJtLry2/oNPYcTTTn20XcPa9QREPKuI7+SNx4GRDw7h3sju+ +Gw6ZEb94ec82N2/WqCH19ZYbvtPoWt2mEx3N938ZgvolfKwPh/fzb4phNH1aWNLyiVDZRUJolk tfH0LcOX9PCAuuvybbW+ZM8pm6Pyh09+7My2QVWDzqA1AarZCIcp6fP8ZecR3Dt5hfFQ23++OyW /Bm1CWu6YNcj0Z9wKgAxtDZto67MDtFr1olyBT4hy3gEiE0bsWYk7px3aeeYBd+i0+vURe0FQA2 7FRTWqjZoA+wI8w21dXImmGm0yUnMokmHMGDHzJAAJWDf8kHPB8NE/Bi4F5L90l4dvTakAUQLXT ZrJGEfBY5DRqf9jxpXDFaDCW/sJiS6YSHixX82YdkkKsiJHa858VeZXYra7VTROh/E9t0w4QmKx 6IeQXSQWYpi42TAUyDL8hLNuSelFua7On2sxwiJCc0 X-Google-Smtp-Source: AGHT+IHBds+X0/ki8ZPOE7nxGkaRsOEceMzeuty2twx+7SILTFYmptt0VFZCyVZl03XZWT+5nD+Zkg== X-Received: by 2002:a05:620a:31a4:b0:89f:7feb:fd6d with SMTP id af79cd13be357-8a6f63c55dcmr38179485a.6.1761581968803; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com. [209.85.160.169]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25896d52sm627844785a.38.2025.10.27.09.19.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 09:19:28 -0700 (PDT) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4eba82bc42cso1190671cf.1 for ; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXHUupz6FYxHn1UKB4z7+rD8eILq9OisuLFxW5h0FJeUd+ryDgdwXR4PCjN/YYtfdiq882PNWhEnskKCZwLuEso8z2aFA==@freebsd.org X-Received: by 2002:ac8:7c43:0:b0:4e0:b24a:6577 with SMTP id d75a77b69052e-4ed0745ac40mr5912671cf.2.1761581968063; Mon, 27 Oct 2025 09:19:28 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> <20251027155808.A4532201@slippy.cwsent.com> <20251027161755.0D67A40B@slippy.cwsent.com> In-Reply-To: <20251027161755.0D67A40B@slippy.cwsent.com> Reply-To: jlduran@freebsd.org From: Jose Luis Duran Date: Mon, 27 Oct 2025 13:19:16 -0300 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bndW8kFlEDVHbSfRyd3orHaIwTj9C7Ksp24nx6Uh7E4HTDC9I51RfTFdvI Message-ID: Subject: Re: git: 79e374217d69 - main - blocklist: Fix rcorder(8) To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cwJcL2ZHrz4MLR On Mon, Oct 27, 2025 at 1:18=E2=80=AFPM Cy Schubert wrote: > > In message om> > , Jose Luis Duran writes: > > On Mon, Oct 27, 2025 at 12:58=3DE2=3D80=3DAFPM Cy Schubert > .com> wrote: > > > > > > In message <202510271547.59RFlnxW096622@gitrepo.freebsd.org>, Jose Lu= is > > > Duran w > > > rites: > > > > The branch main has been updated by jlduran: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3D79e374217d69a98161= fc91a2=3D > > 86dacf1f > > > > 78090894 > > > > > > > > commit 79e374217d69a98161fc91a286dacf1f78090894 > > > > Author: Jose Luis Duran > > > > AuthorDate: 2025-10-27 15:46:32 +0000 > > > > Commit: Jose Luis Duran > > > > CommitDate: 2025-10-27 15:46:32 +0000 > > > > > > > > blocklist: Fix rcorder(8) > > > > > > > > The blocklist daemon depends on a packet filter in order to blo= ck. > > > > > > > > Add all supported packet filters to the REQUIRE line, not just = pf, =3D > > to > > > > indicate rcorder(8) that it should start after the packet filte= r se=3D > > rvice > > > > has started. > > > > > > > > While here, change the mode of the rc file to include the execu= tabl=3D > > e > > > > bit, just like the rest of the files in the rc.d source directo= ry. > > > > > > > > Reviewed by: 0mp > > > > MFC after: 2 days > > > > Differential Revision: https://reviews.freebsd.org/D53364 > > > > --- > > > > libexec/rc/rc.d/blacklistd | 2 +- > > > > libexec/rc/rc.d/blocklistd | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklist= d > > > > index 9157e258f43f..175e3e8c56b3 100755 > > > > --- a/libexec/rc/rc.d/blacklistd > > > > +++ b/libexec/rc/rc.d/blacklistd > > > > @@ -29,7 +29,7 @@ > > > > # > > > > > > > > # PROVIDE: blacklistd > > > > -# REQUIRE: netif pf > > > > +# REQUIRE: netif ipfilter ipfw pf > > > > > > This means all three, ipfilter AND ipfw AND pf, must be enabled and > > > started. What if one uses only one of the three? > > > > No, per rcorder(8) BUGS section: > > > > The REQUIRE keyword is misleading: > > It does not describe which daemons have to be running before a script > > will be started. > > It describes which scripts must be placed before it in the dependency o= rder=3D > > ing. > > > > 0mp@ even suggests creating a FIREWALL(S) script to represent that an > > rc script should start after the firewall (any one or many) has > > started. I agree, but I cannot immediately submit a patch for it. > > I stand corrected. Thanks. No problem! It is indeed misleading. > > > > > > > > > > > . /etc/rc.subr > > > > > > > > diff --git a/libexec/rc/rc.d/blocklistd b/libexec/rc/rc.d/blocklist= d > > > > old mode 100644 > > > > new mode 100755 > > > > index 24cbae77fd40..f979162ec3e0 > > > > --- a/libexec/rc/rc.d/blocklistd > > > > +++ b/libexec/rc/rc.d/blocklistd > > > > @@ -29,7 +29,7 @@ > > > > # > > > > > > > > # PROVIDE: blocklistd > > > > -# REQUIRE: netif pf > > > > +# REQUIRE: netif ipfilter ipfw pf > > > > > > Ditto. > > > > > > > > > > > . /etc/rc.subr > > > > > > > > > > > > > > > > > -- > > > Cheers, > > > Cy Schubert > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > NTP: Web: https://nwtime.org > > > > > > e**(i*pi)+1=3D3D0 > > > > > > > > > > > > --=3D20 > > Jose Luis Duran > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e**(i*pi)+1=3D0 > > --=20 Jose Luis Duran