From nobody Mon Oct 27 16:04:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwJH1476Hz6DwKn for ; Mon, 27 Oct 2025 16:04:29 +0000 (UTC) (envelope-from jlduran@gmail.com) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwJH12DDcz3xd5 for ; Mon, 27 Oct 2025 16:04:29 +0000 (UTC) (envelope-from jlduran@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-89f888a0575so61911385a.1 for ; Mon, 27 Oct 2025 09:04:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761581068; x=1762185868; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KDzBbXKSsbQwwuJBb8DKmInuLmoUf3/HmablsfyDsgs=; b=PLVJXRUmryU5AanoJVW7l9QsRlCnUpu8QBO4qY9z+aB61fUbNekwyobD6l3Gw/Xa82 PCmzWMRSxTZrRqBbJge0M9Kdk7Arur5+qfgFksx5KWedqUCyDnG7qY2vcm2LxaO9muTa uymUurdoZFh8aRBr7VGuz8z1oubGqvWUVNooGvs/0eT5jNoeUFPzBmlRJA8Ewdkuvjj4 LART8DzMrkeXxYq4a4PvQY8KfjUCAy6S23a16IupufkJ44y50VC+/ZD/TwRqo8wmgkey YtCDqxRn4o+saVloOlFbkBbHw/WGW1xf/GfXLE9KhtHs2x8ybQ+s76zkRel0C4tzuTIY gczQ== X-Forwarded-Encrypted: i=1; AJvYcCXd7haindl32SmFx4Ki20fgUPw1L0zHSmmczbmxuazaQ7Rnk2wme2PU0SCTm3TtmOhzVxDS99F0XunrNDZPRPJIJtCzuA==@freebsd.org X-Gm-Message-State: AOJu0YwNkdy0H0Ujt5WZa8qCwC1kcTPXaa8GDjVBN/QdZakRz8MmW5eJ 1ZhTS6ldI0bRBR/EOLe5k3wu7/fQmb07dkcSn9caj4V76SdaPZvIrp8Kecx2vDMrkGY= X-Gm-Gg: ASbGnct5VHgFngAv/CA5cELR0SXdlVYo9DkeiHtQxi5si4Mx3+CC0ow3NWXm6gailLH wp/zrrmluOJdQBqtLM5WoO+pI+mJnUn+5FAN4KxX0zeek7q/ZoJm0zf878unXpG9yOxX8wz3xpM HaxuNMC0c2Biy7aCSsJBw1jnCYBxC+AQSuZrr5v/9lCGV+a2Qoy/HRie1iEDiq3hEzbcmbZl7gV ITmImeY5x6VKwM6iq9ae5i3cEp1k+h7lYfTl0ca/gB0aO0PeHsTokxjS1S3xIunffK0aFwawSsT 4SPd54brXlFO7p2iSmLwgOJMiLjXKX2202K8sDLGhIIuWdEtIAVjORpAQfUbk7SV4dHiMJxxVlp iU9SxYg2vBMdcOGuoc3uF9xlJeExKquqj38SZQhdKjyfLt55bN7D5tzD2MuBHmlv51GmxXusAba lhpEJmued8A/xzmN/tKWhL2exIvC3mfdWY2R2aUSKIwO22Nq+wg8M= X-Google-Smtp-Source: AGHT+IFBVM3ulfG3eLqu054vPT6T0trlRPL4zKO4JCUrjjj39VgRF/HABvd/ptGX3MrwZx1P+2gPAw== X-Received: by 2002:a05:620a:2908:b0:8a2:c42f:9951 with SMTP id af79cd13be357-8a6f4f8a0damr33574485a.6.1761581068231; Mon, 27 Oct 2025 09:04:28 -0700 (PDT) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com. [209.85.160.172]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba38491e3sm53389951cf.27.2025.10.27.09.04.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 09:04:28 -0700 (PDT) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4ecfe642fe4so761591cf.0 for ; Mon, 27 Oct 2025 09:04:27 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW5zh+tBEC37iJ/fsSvK9b96g/pRNuCLnNhc7rQ5viO6s4S/bqXawx1H5BNBjseXw55DB3KOzo4Z2I6yl7KfChdN5gw7w==@freebsd.org X-Received: by 2002:a05:622a:255:b0:4d0:3985:e425 with SMTP id d75a77b69052e-4ed074c8e00mr4568781cf.7.1761581067677; Mon, 27 Oct 2025 09:04:27 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> <20251027155808.A4532201@slippy.cwsent.com> In-Reply-To: <20251027155808.A4532201@slippy.cwsent.com> Reply-To: jlduran@freebsd.org From: Jose Luis Duran Date: Mon, 27 Oct 2025 13:04:16 -0300 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bngSGx7HVmvD7hSuyek4edz0BXVjpJ6w90Zk1SnmCTyYb66LGEhIPEiaoo Message-ID: Subject: Re: git: 79e374217d69 - main - blocklist: Fix rcorder(8) To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cwJH12DDcz3xd5 On Mon, Oct 27, 2025 at 12:58=E2=80=AFPM Cy Schubert wrote: > > In message <202510271547.59RFlnxW096622@gitrepo.freebsd.org>, Jose Luis > Duran w > rites: > > The branch main has been updated by jlduran: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D79e374217d69a98161fc91a2= 86dacf1f > > 78090894 > > > > commit 79e374217d69a98161fc91a286dacf1f78090894 > > Author: Jose Luis Duran > > AuthorDate: 2025-10-27 15:46:32 +0000 > > Commit: Jose Luis Duran > > CommitDate: 2025-10-27 15:46:32 +0000 > > > > blocklist: Fix rcorder(8) > > > > The blocklist daemon depends on a packet filter in order to block. > > > > Add all supported packet filters to the REQUIRE line, not just pf, = to > > indicate rcorder(8) that it should start after the packet filter se= rvice > > has started. > > > > While here, change the mode of the rc file to include the executabl= e > > bit, just like the rest of the files in the rc.d source directory. > > > > Reviewed by: 0mp > > MFC after: 2 days > > Differential Revision: https://reviews.freebsd.org/D53364 > > --- > > libexec/rc/rc.d/blacklistd | 2 +- > > libexec/rc/rc.d/blocklistd | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklistd > > index 9157e258f43f..175e3e8c56b3 100755 > > --- a/libexec/rc/rc.d/blacklistd > > +++ b/libexec/rc/rc.d/blacklistd > > @@ -29,7 +29,7 @@ > > # > > > > # PROVIDE: blacklistd > > -# REQUIRE: netif pf > > +# REQUIRE: netif ipfilter ipfw pf > > This means all three, ipfilter AND ipfw AND pf, must be enabled and > started. What if one uses only one of the three? No, per rcorder(8) BUGS section: The REQUIRE keyword is misleading: It does not describe which daemons have to be running before a script will be started. It describes which scripts must be placed before it in the dependency order= ing. 0mp@ even suggests creating a FIREWALL(S) script to represent that an rc script should start after the firewall (any one or many) has started. I agree, but I cannot immediately submit a patch for it. > > > > . /etc/rc.subr > > > > diff --git a/libexec/rc/rc.d/blocklistd b/libexec/rc/rc.d/blocklistd > > old mode 100644 > > new mode 100755 > > index 24cbae77fd40..f979162ec3e0 > > --- a/libexec/rc/rc.d/blocklistd > > +++ b/libexec/rc/rc.d/blocklistd > > @@ -29,7 +29,7 @@ > > # > > > > # PROVIDE: blocklistd > > -# REQUIRE: netif pf > > +# REQUIRE: netif ipfilter ipfw pf > > Ditto. > > > > > . /etc/rc.subr > > > > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e**(i*pi)+1=3D0 > > --=20 Jose Luis Duran