From nobody Fri Oct 24 11:16:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ctL1b5rD8z6DB3b; Fri, 24 Oct 2025 11:16:03 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ctL1b3XGFz3mYp; Fri, 24 Oct 2025 11:16:03 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Authentication-Results: mx1.freebsd.org; none Received: from critter.freebsd.dk (unknown [192.168.55.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by phk.freebsd.dk (Postfix) with ESMTPS id CCDBCC3F3D; Fri, 24 Oct 2025 11:16:01 +0000 (UTC) Received: (from phk@localhost) by critter.freebsd.dk (8.18.1/8.16.1/Submit) id 59OBG1ii003074; Fri, 24 Oct 2025 11:16:01 GMT (envelope-from phk) Message-Id: <202510241116.59OBG1ii003074@critter.freebsd.dk> To: Konstantin Belousov cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2612f1b8649b - main - deadfs: Return ENXIO instead of EIO when the device is gone. In-reply-to: From: "Poul-Henning Kamp" References: <202510240741.59O7fBAe041995@gitrepo.freebsd.org> <202510241012.59OACUDA002781@critter.freebsd.dk> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3072.1761304561.1@critter.freebsd.dk> Date: Fri, 24 Oct 2025 11:16:01 +0000 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:1835, ipnet:130.225.0.0/16, country:EU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4ctL1b3XGFz3mYp -------- Konstantin Belousov writes: > On Fri, Oct 24, 2025 at 10:12:30AM +0000, Poul-Henning Kamp wrote: > I do not think that DRM really affects the code path for io. 100% agreement. But it can change the order of thread/interrupt/event-handling scheduling. When I tested the ENXIO patch, I started booting an unmodified kernel in single-user and immediately got ENXIO when I pulled the USB stick - quite to my surprise. Then I kldloaded i915kms, still in single-user, and now I got the observed bad EIO behaviour. With a fixed kernel and i915kms loaded, I saw four or five reads return EIO before one got ENXIO and terminated recoverdisk. Getting a handful of EIO's before the ENXIO finally appears strongly suggests that some of the eventhandling related to the disappearing USB stick is being held up by something. As soon as I can, I'll try to gather more data. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.