Re: git: 885e8f272f75 - main - LinuxKPI: add skeleton pci_enable_wake()

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Tue, 21 Oct 2025 15:06:11 UTC
On Tue, 21 Oct 2025, John Baldwin wrote:

> On 10/21/25 03:53, Bjoern A. Zeeb wrote:
>> The branch main has been updated by bz:
>> 
>> URL: 
>> https://cgit.FreeBSD.org/src/commit/?id=885e8f272f7515b0325974de72d18b73318eff07
>> 
>> commit 885e8f272f7515b0325974de72d18b73318eff07
>> Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
>> AuthorDate: 2025-10-17 20:38:11 +0000
>> Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
>> CommitDate: 2025-10-21 07:49:39 +0000
>>
>>      LinuxKPI: add skeleton pci_enable_wake()
>>           Given we do not yet support "wake" bits in device there is little 
>> need
>>      doing it in PCI if we cannot check if we are supposed to do the
>>      operation in first place.  Once we would implement this, we would need
>>      to also do the appropriate PCI (pme) checks before enabling 
>> (disabling)
>>      it.
>>           MFC after:      3 days
>>      Reviewed by:    dumbbell
>>      Differential Revision: https://reviews.freebsd.org/D53208
>
> FWIW, we have pci_enable_pme() that this probably maps to.  Similarly, 
> pci_has_pm()
> is a helper routine to see if a device supports power management.  The 
> various NIC
> drivers supporting WOL use these helper routines to manage PME.

Thank you.  LinuxKPI also has pci_pme_capable() already.

I'll try to implement the lower device bits in LinuxKPI at some point
(at least it's on my list) and this will hopefully help then to do the
PCI bits quickly.

/bz

-- 
Bjoern A. Zeeb                                                     r15:7