From nobody Mon Oct 20 18:32:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cr3th4VwTz6Ctyt; Mon, 20 Oct 2025 18:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cr3th3splz43dt; Mon, 20 Oct 2025 18:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760985132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iT7ccAFVTpUebj4ovDV5xQ0ZKEcTEFyEeOMAAetYvEA=; b=QtiYz0LqJPQiZHAtEx04u3+D5qMid7XppyY/NKRn8cKH6EUZ5WdzXGR7+m/Er8wBybdSYN D1HSel/Lv9L5gJVixNtyVKTjfjYjaZljgsqrgDfJOqhH800Y5ZJMn2ccfG9aczicxeC/Za +Pvy1R8bEVcXuh/LbjkKb/ypqWmHyZIWVzKM8M5AsyIeuqWMu8esNFfamwQ/A85dqlyG6C JM3eY9Om+/q/nIuFqBJ+Bog9RrRgzJxcZwVt8D+X1m1PwBZqrisuQ2hsT46K/RpDIj1Unz qx3Zkc2vfLfDcbfaiE5S4apUauLvtPanMlZ9ZgaFncLICSgsFfDnk5VkN39kjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760985132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iT7ccAFVTpUebj4ovDV5xQ0ZKEcTEFyEeOMAAetYvEA=; b=a6I0lF7w2QSs2sPzxpV2TA5lT606rRYEjjcXyyXjEOEs/bGe534BDUUKGzpls43clZhcLa AwLHKIHF7XEVRFdk492LplLE+ZHshYESeEMpRNEvpTOwKoYIz6DAPjrIwhRsqk+Yu6eCUa nQt7bc608yhSth7HCscWTwe4JFQKdNF0B5O2DaCnkWvQMfltd0V1kpyrpHq//bXVR1Kvtr DDa/eux+bsG9Wl2f3x8QSNs1T2PWD5C32KRFUIOkIYp4rFZeS3jvh7dHSILujOT7jkQVP1 JVsojVuiEQZQZxl9eU8AiAGr7zynd+K5qUiY8akMLf8pJn8z3+cXd8A3bZSgZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760985132; a=rsa-sha256; cv=none; b=VKHHHJGcviIRhb5F0ZjsOXVoxT8svqa6kSFYPmbN8jJ42HmpSaBzGHWKb1mg3YnuuJh11s 9AsOMhf7WZ/ZMc7JKNpEA+Hgsp0ci3IX3/eB5SyxKXWDO6FPfR65T1QJ3tSh6/hQrfTCnw j8+tDIRSVq77dumuTLHpsJAJ3bxjkjMtO74AOorfvJa6OzkZjje+7V9c4vOH49UsxxNOsu PmVsj66g4QL1E7tsZn4PvjZ6kFiG+BT4AGYt9zuV9UHoduW0BraUs8po8RZdlMLCddhydD XqBbmz0eV4pz+tRcJlGLnzPrdx6S5Wz99KiAn7O8lS/nwkVJbuCE1GjP4akjAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cr3th3Qwsz7Xq; Mon, 20 Oct 2025 18:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59KIWCaL006627; Mon, 20 Oct 2025 18:32:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59KIWCG0006624; Mon, 20 Oct 2025 18:32:12 GMT (envelope-from git) Date: Mon, 20 Oct 2025 18:32:12 GMT Message-Id: <202510201832.59KIWCG0006624@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: e1aeb58cbbc3 - main - inet_net_test: Use int to hold expected return values from inet_net_pton List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e1aeb58cbbc3839db93ec38ce491b7b9383d5649 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=e1aeb58cbbc3839db93ec38ce491b7b9383d5649 commit e1aeb58cbbc3839db93ec38ce491b7b9383d5649 Author: John Baldwin AuthorDate: 2025-10-20 18:31:41 +0000 Commit: John Baldwin CommitDate: 2025-10-20 18:31:41 +0000 inet_net_test: Use int to hold expected return values from inet_net_pton GCC warns about the sign mismatch in comparisons: lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet4::body() const': lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 86 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet6::body() const': lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 205 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ Fixes: 8f4a0d2f7b96 ("libc: Import OpenBSD's inet_net_{ntop,pton}") --- lib/libc/tests/net/inet_net_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libc/tests/net/inet_net_test.cc b/lib/libc/tests/net/inet_net_test.cc index 4ecf5a3de492..c4411373165e 100644 --- a/lib/libc/tests/net/inet_net_test.cc +++ b/lib/libc/tests/net/inet_net_test.cc @@ -50,7 +50,7 @@ ATF_TEST_CASE_BODY(inet_net_inet4) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; }; @@ -134,7 +134,7 @@ ATF_TEST_CASE_BODY(inet_net_inet6) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; };