git: edbbf26e2650 - main - pci/n1sdp: Disable HotPlug

From: Andrew Turner <andrew_at_FreeBSD.org>
Date: Fri, 17 Oct 2025 15:02:42 UTC
The branch main has been updated by andrew:

URL: https://cgit.FreeBSD.org/src/commit/?id=edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0

commit edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0
Author:     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: 2025-10-17 15:02:19 +0000
Commit:     Andrew Turner <andrew@FreeBSD.org>
CommitDate: 2025-10-17 15:02:19 +0000

    pci/n1sdp: Disable HotPlug
    
    Work around an issue when HotPlug is enabled where pcib3 and pcib5
    continuously report the following:
    
    pcib3: HotPlug interrupt: 0x30
    pcib3: Command Completed
    pcib3: HotPlug interrupt: 0x30
    pcib3: Command Completed
    ...
    
    As a workaround disable HotPlug on the N1SDP as it's unlikely anyone
    will depend on it.
    
    Reviewed by:    br
    Fixes:  1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI")
    Sponsored by:   Arm Ltd
    Differential Revision:  https://reviews.freebsd.org/D53134
---
 sys/dev/pci/controller/pci_n1sdp.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sys/dev/pci/controller/pci_n1sdp.c b/sys/dev/pci/controller/pci_n1sdp.c
index 487041bc78e4..22f0ea27d45b 100644
--- a/sys/dev/pci/controller/pci_n1sdp.c
+++ b/sys/dev/pci/controller/pci_n1sdp.c
@@ -345,6 +345,17 @@ n1sdp_pcie_write_config(device_t dev, u_int bus, u_int slot,
 	bus_space_write_4(t, h, offset & ~3, data);
 }
 
+static int
+n1sdp_pcie_acpi_request_feature(device_t pcib __unused, device_t dev __unused,
+    enum pci_feature feature __unused)
+{
+	/*
+	 * HotPlug isn't supported on the N1SDP as it causes an interrupt storm
+	 */
+	return (EINVAL);
+}
+
+
 static device_method_t n1sdp_pcie_acpi_methods[] = {
 	DEVMETHOD(device_probe,		n1sdp_pcie_acpi_probe),
 	DEVMETHOD(device_attach,	n1sdp_pcie_acpi_attach),
@@ -352,6 +363,7 @@ static device_method_t n1sdp_pcie_acpi_methods[] = {
 	/* pcib interface */
 	DEVMETHOD(pcib_read_config,	n1sdp_pcie_read_config),
 	DEVMETHOD(pcib_write_config,	n1sdp_pcie_write_config),
+	DEVMETHOD(pcib_request_feature, n1sdp_pcie_acpi_request_feature),
 
 	DEVMETHOD_END
 };