Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators

From: Enji Cooper (yaneurabeya) <yaneurabeya_at_gmail.com>
Date: Fri, 17 Oct 2025 07:38:20 UTC
> On Oct 16, 2025, at 10:29 PM, Alexander Leidinger <Alexander@Leidinger.net> wrote:
> 
> Am 2025-10-17 01:29, schrieb Rick Macklem:
>> On Thu, Oct 16, 2025 at 4:21 PM Rick Macklem <rick.macklem@gmail.com> wrote:
>>> Please be aware of the following snippets from "man 9 style":
>>> In general code can be considered "new code" when it makes up about 50%
>>> or more of the file(s) involved. This is enough to break precedents in
>>> the existing code and use the current style guidelines.
>>> Stylistic changes (including whitespace changes) are hard on the source
>>> repository and are to be avoided without good reason.
>>> rick
>> Just to be clear, I am not asking that this commit be reverted.
>> I am just suggesting that you be aware that style(9) changes to
>> extant code is not, in general, encouraged, afaik unless you are
>> re-writing a large portion of the code (over 50%).
> 
> Does someone remember why? We have now the possibility to exclude commits from the VCS attribution of lines to commits (git blame), as such, does the reason of not doing it still hold?

Hi Alexander,
	I’m not sure about the percentage Rick mentioned, but I think Mark’s comment about avoiding merge conflicts is a key point (for FreeBSD as well as downstream consumers of FreeBSD.
	Unnecessary churn can also make reconciling changes with other sources, e.g., NetBSD, OpenBSD, more difficult for little to no gain.
Cheers,
-Enji

PS Has anyone tried running `clang-format -i` on these files to see how in compliance they are with style(9) *ducks to avoid flying fruit*?